potential bug in maven plugin and/or openejb shutdown code

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

potential bug in maven plugin and/or openejb shutdown code

Christofer Dutz
Hi,

I’m currently struggling to get some integration-tests running and have stumbled over something that i might think could be a problem.

Then using the tomee-maven-plugin 1.7.0 to start tomee before my tests, this works fine. After my tests I have maven call the stop goal. It seems tomee is correctly shut down (All ports are closed and processes killed), but the plugin seemed to be waiting for ages.

To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE this then issues the server stop and goes into waitForServerShutdown()

This method now tries to connect to the shutdown port of tomcat for MAXINT times. If the connection is successful the socket is closed again and true is returned and waitForServerShutdown while loop just calls it again. When looking at that method, to me it seems that the only option in which the while loop in RemoteServer.waitForServerShutdown() can end, is that the plugin has waited MAXINT seconds and has opened MAXINT sockets. Why do you do that much recursion anyway? To me a simple while loop would have made sense here.

In my case the first connection attempt already fails, but even if if didn’t that wouldn’t change the fact that I have to wait almost 70 years for my test suite to finish ;-)

Am I doing something wrong or does this code sort of smell a little strange?

Chris



signature.asc (859 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Romain Manni-Bucau
Hi

before going further is it still the case with 1.7.1 version?


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-25 15:52 GMT+02:00 Christofer Dutz <[hidden email]>:

> Hi,
>
> I’m currently struggling to get some integration-tests running and have stumbled over something that i might think could be a problem.
>
> Then using the tomee-maven-plugin 1.7.0 to start tomee before my tests, this works fine. After my tests I have maven call the stop goal. It seems tomee is correctly shut down (All ports are closed and processes killed), but the plugin seemed to be waiting for ages.
>
> To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE this then issues the server stop and goes into waitForServerShutdown()
>
> This method now tries to connect to the shutdown port of tomcat for MAXINT times. If the connection is successful the socket is closed again and true is returned and waitForServerShutdown while loop just calls it again. When looking at that method, to me it seems that the only option in which the while loop in RemoteServer.waitForServerShutdown() can end, is that the plugin has waited MAXINT seconds and has opened MAXINT sockets. Why do you do that much recursion anyway? To me a simple while loop would have made sense here.
>
> In my case the first connection attempt already fails, but even if if didn’t that wouldn’t change the fact that I have to wait almost 70 years for my test suite to finish ;-)
>
> Am I doing something wrong or does this code sort of smell a little strange?
>
> Chris
>
>
Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Christofer Dutz
Hi Romain,

No change in 1.7.1 Š Same thing Š but as the code for stopping is
identical, I would not have expected any difference. I even checked with
HEAD and as the code is still the same, I would assume the problem to
still be present in 2.0.0-SNAPSHOT

Chris
--


Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
Consultant

codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
<http://blog.codecentric.de/> | www.meettheexperts.de
<http://www.meettheexperts.de/> | www.more4fi.de <http://www.more4fi.de/>
 

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz

Diese E-Mail einschließlich evtl. beigefügter Dateien enthält vertrauliche
und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie
bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder Öffnen
evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail ist
nicht gestattet.






Am 25.09.14 15:55 schrieb "Romain Manni-Bucau" unter
<[hidden email]>:

>Hi
>
>before going further is it still the case with 1.7.1 version?
>
>
>Romain Manni-Bucau
>Twitter: @rmannibucau
>Blog: http://rmannibucau.wordpress.com/
>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>Github: https://github.com/rmannibucau
>
>
>2014-09-25 15:52 GMT+02:00 Christofer Dutz
><[hidden email]>:
>> Hi,
>>
>> I¹m currently struggling to get some integration-tests running and have
>>stumbled over something that i might think could be a problem.
>>
>> Then using the tomee-maven-plugin 1.7.0 to start tomee before my tests,
>>this works fine. After my tests I have maven call the stop goal. It
>>seems tomee is correctly shut down (All ports are closed and processes
>>killed), but the plugin seemed to be waiting for ages.
>>
>> To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE
>>this then issues the server stop and goes into waitForServerShutdown()
>>
>> This method now tries to connect to the shutdown port of tomcat for
>>MAXINT times. If the connection is successful the socket is closed again
>>and true is returned and waitForServerShutdown while loop just calls it
>>again. When looking at that method, to me it seems that the only option
>>in which the while loop in RemoteServer.waitForServerShutdown() can end,
>>is that the plugin has waited MAXINT seconds and has opened MAXINT
>>sockets. Why do you do that much recursion anyway? To me a simple while
>>loop would have made sense here.
>>
>> In my case the first connection attempt already fails, but even if if
>>didn¹t that wouldn¹t change the fact that I have to wait almost 70 years
>>for my test suite to finish ;-)
>>
>> Am I doing something wrong or does this code sort of smell a little
>>strange?
>>
>> Chris
>>
>>


Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Romain Manni-Bucau
You are right! You should be able to workaround it setting
connect.tries system property.


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-25 17:14 GMT+02:00 Christofer Dutz <[hidden email]>:

> Hi Romain,
>
> No change in 1.7.1 Š Same thing Š but as the code for stopping is
> identical, I would not have expected any difference. I even checked with
> HEAD and as the code is still the same, I would assume the problem to
> still be present in 2.0.0-SNAPSHOT
>
> Chris
> --
>
>
> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
> Consultant
>
> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
> <http://blog.codecentric.de/> | www.meettheexperts.de
> <http://www.meettheexperts.de/> | www.more4fi.de <http://www.more4fi.de/>
>
>
> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz
>
> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält vertrauliche
> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie
> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder Öffnen
> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail ist
> nicht gestattet.
>
>
>
>
>
>
> Am 25.09.14 15:55 schrieb "Romain Manni-Bucau" unter
> <[hidden email]>:
>
>>Hi
>>
>>before going further is it still the case with 1.7.1 version?
>>
>>
>>Romain Manni-Bucau
>>Twitter: @rmannibucau
>>Blog: http://rmannibucau.wordpress.com/
>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>Github: https://github.com/rmannibucau
>>
>>
>>2014-09-25 15:52 GMT+02:00 Christofer Dutz
>><[hidden email]>:
>>> Hi,
>>>
>>> I¹m currently struggling to get some integration-tests running and have
>>>stumbled over something that i might think could be a problem.
>>>
>>> Then using the tomee-maven-plugin 1.7.0 to start tomee before my tests,
>>>this works fine. After my tests I have maven call the stop goal. It
>>>seems tomee is correctly shut down (All ports are closed and processes
>>>killed), but the plugin seemed to be waiting for ages.
>>>
>>> To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE
>>>this then issues the server stop and goes into waitForServerShutdown()
>>>
>>> This method now tries to connect to the shutdown port of tomcat for
>>>MAXINT times. If the connection is successful the socket is closed again
>>>and true is returned and waitForServerShutdown while loop just calls it
>>>again. When looking at that method, to me it seems that the only option
>>>in which the while loop in RemoteServer.waitForServerShutdown() can end,
>>>is that the plugin has waited MAXINT seconds and has opened MAXINT
>>>sockets. Why do you do that much recursion anyway? To me a simple while
>>>loop would have made sense here.
>>>
>>> In my case the first connection attempt already fails, but even if if
>>>didn¹t that wouldn¹t change the fact that I have to wait almost 70 years
>>>for my test suite to finish ;-)
>>>
>>> Am I doing something wrong or does this code sort of smell a little
>>>strange?
>>>
>>> Chris
>>>
>>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Christofer Dutz
Oh great

Good to know it wasn’t me using the thing wrong. But I had the impression
the number of reties was hard-coded to MAXINT and only overridden to 0 for
one subclass.

If you like, I could whip up  fix for that first thing tomorrow morning.

Chris


--


Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
Consultant

codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
<http://blog.codecentric.de/> | www.meettheexperts.de
<http://www.meettheexperts.de/> | www.more4fi.de <http://www.more4fi.de/>
 

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz

Diese E-Mail einschließlich evtl. beigefügter Dateien enthält vertrauliche
und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie
bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder Öffnen
evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail ist
nicht gestattet.






Am 25.09.14 17:43 schrieb "Romain Manni-Bucau" unter
<[hidden email]>:

>You are right! You should be able to workaround it setting
>connect.tries system property.
>
>
>Romain Manni-Bucau
>Twitter: @rmannibucau
>Blog: http://rmannibucau.wordpress.com/
>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>Github: https://github.com/rmannibucau
>
>
>2014-09-25 17:14 GMT+02:00 Christofer Dutz
><[hidden email]>:
>> Hi Romain,
>>
>> No change in 1.7.1 Š Same thing Š but as the code for stopping is
>> identical, I would not have expected any difference. I even checked with
>> HEAD and as the code is still the same, I would assume the problem to
>> still be present in 2.0.0-SNAPSHOT
>>
>> Chris
>> --
>>
>>
>> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
>> Consultant
>>
>> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
>> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
>> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
>> <http://blog.codecentric.de/> | www.meettheexperts.de
>> <http://www.meettheexperts.de/> | www.more4fi.de
>><http://www.more4fi.de/>
>>
>>
>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
>> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>>Schütz
>>
>> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält
>>vertrauliche
>> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
>> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren
>>Sie
>> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
>> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder
>>Öffnen
>> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail
>>ist
>> nicht gestattet.
>>
>>
>>
>>
>>
>>
>> Am 25.09.14 15:55 schrieb "Romain Manni-Bucau" unter
>> <[hidden email]>:
>>
>>>Hi
>>>
>>>before going further is it still the case with 1.7.1 version?
>>>
>>>
>>>Romain Manni-Bucau
>>>Twitter: @rmannibucau
>>>Blog: http://rmannibucau.wordpress.com/
>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>Github: https://github.com/rmannibucau
>>>
>>>
>>>2014-09-25 15:52 GMT+02:00 Christofer Dutz
>>><[hidden email]>:
>>>> Hi,
>>>>
>>>> I¹m currently struggling to get some integration-tests running and
>>>>have
>>>>stumbled over something that i might think could be a problem.
>>>>
>>>> Then using the tomee-maven-plugin 1.7.0 to start tomee before my
>>>>tests,
>>>>this works fine. After my tests I have maven call the stop goal. It
>>>>seems tomee is correctly shut down (All ports are closed and processes
>>>>killed), but the plugin seemed to be waiting for ages.
>>>>
>>>> To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE
>>>>this then issues the server stop and goes into waitForServerShutdown()
>>>>
>>>> This method now tries to connect to the shutdown port of tomcat for
>>>>MAXINT times. If the connection is successful the socket is closed
>>>>again
>>>>and true is returned and waitForServerShutdown while loop just calls it
>>>>again. When looking at that method, to me it seems that the only option
>>>>in which the while loop in RemoteServer.waitForServerShutdown() can
>>>>end,
>>>>is that the plugin has waited MAXINT seconds and has opened MAXINT
>>>>sockets. Why do you do that much recursion anyway? To me a simple while
>>>>loop would have made sense here.
>>>>
>>>> In my case the first connection attempt already fails, but even if if
>>>>didn¹t that wouldn¹t change the fact that I have to wait almost 70
>>>>years
>>>>for my test suite to finish ;-)
>>>>
>>>> Am I doing something wrong or does this code sort of smell a little
>>>>strange?
>>>>
>>>> Chris
>>>>
>>>>
>>
>>


Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Romain Manni-Bucau
yep jira + patch would be awesome. Think it just needs a boolean
goesOutOnFailure ;)


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-25 21:36 GMT+02:00 Christofer Dutz <[hidden email]>:

> Oh great
>
> Good to know it wasn’t me using the thing wrong. But I had the impression
> the number of reties was hard-coded to MAXINT and only overridden to 0 for
> one subclass.
>
> If you like, I could whip up  fix for that first thing tomorrow morning.
>
> Chris
>
>
> --
>
>
> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
> Consultant
>
> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
> <http://blog.codecentric.de/> | www.meettheexperts.de
> <http://www.meettheexperts.de/> | www.more4fi.de <http://www.more4fi.de/>
>
>
> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz
>
> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält vertrauliche
> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie
> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder Öffnen
> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail ist
> nicht gestattet.
>
>
>
>
>
>
> Am 25.09.14 17:43 schrieb "Romain Manni-Bucau" unter
> <[hidden email]>:
>
>>You are right! You should be able to workaround it setting
>>connect.tries system property.
>>
>>
>>Romain Manni-Bucau
>>Twitter: @rmannibucau
>>Blog: http://rmannibucau.wordpress.com/
>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>Github: https://github.com/rmannibucau
>>
>>
>>2014-09-25 17:14 GMT+02:00 Christofer Dutz
>><[hidden email]>:
>>> Hi Romain,
>>>
>>> No change in 1.7.1 Š Same thing Š but as the code for stopping is
>>> identical, I would not have expected any difference. I even checked with
>>> HEAD and as the code is still the same, I would assume the problem to
>>> still be present in 2.0.0-SNAPSHOT
>>>
>>> Chris
>>> --
>>>
>>>
>>> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
>>> Consultant
>>>
>>> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
>>> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
>>> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
>>> <http://blog.codecentric.de/> | www.meettheexperts.de
>>> <http://www.meettheexperts.de/> | www.more4fi.de
>>><http://www.more4fi.de/>
>>>
>>>
>>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
>>> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>>>Schütz
>>>
>>> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält
>>>vertrauliche
>>> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
>>> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren
>>>Sie
>>> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
>>> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder
>>>Öffnen
>>> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail
>>>ist
>>> nicht gestattet.
>>>
>>>
>>>
>>>
>>>
>>>
>>> Am 25.09.14 15:55 schrieb "Romain Manni-Bucau" unter
>>> <[hidden email]>:
>>>
>>>>Hi
>>>>
>>>>before going further is it still the case with 1.7.1 version?
>>>>
>>>>
>>>>Romain Manni-Bucau
>>>>Twitter: @rmannibucau
>>>>Blog: http://rmannibucau.wordpress.com/
>>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>Github: https://github.com/rmannibucau
>>>>
>>>>
>>>>2014-09-25 15:52 GMT+02:00 Christofer Dutz
>>>><[hidden email]>:
>>>>> Hi,
>>>>>
>>>>> I¹m currently struggling to get some integration-tests running and
>>>>>have
>>>>>stumbled over something that i might think could be a problem.
>>>>>
>>>>> Then using the tomee-maven-plugin 1.7.0 to start tomee before my
>>>>>tests,
>>>>>this works fine. After my tests I have maven call the stop goal. It
>>>>>seems tomee is correctly shut down (All ports are closed and processes
>>>>>killed), but the plugin seemed to be waiting for ages.
>>>>>
>>>>> To me it seems the StopTomEEMojo calls server.forceStop to stop TomEE
>>>>>this then issues the server stop and goes into waitForServerShutdown()
>>>>>
>>>>> This method now tries to connect to the shutdown port of tomcat for
>>>>>MAXINT times. If the connection is successful the socket is closed
>>>>>again
>>>>>and true is returned and waitForServerShutdown while loop just calls it
>>>>>again. When looking at that method, to me it seems that the only option
>>>>>in which the while loop in RemoteServer.waitForServerShutdown() can
>>>>>end,
>>>>>is that the plugin has waited MAXINT seconds and has opened MAXINT
>>>>>sockets. Why do you do that much recursion anyway? To me a simple while
>>>>>loop would have made sense here.
>>>>>
>>>>> In my case the first connection attempt already fails, but even if if
>>>>>didn¹t that wouldn¹t change the fact that I have to wait almost 70
>>>>>years
>>>>>for my test suite to finish ;-)
>>>>>
>>>>> Am I doing something wrong or does this code sort of smell a little
>>>>>strange?
>>>>>
>>>>> Chris
>>>>>
>>>>>
>>>
>>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: potential bug in maven plugin and/or openejb shutdown code

Christofer Dutz
Ok … I’m currently trying out my patch,
But unfortunately your system property solution won’t work as  line 764 of
AbstractTomEEMojo explicitly creates a RemoteServer with MAXINT tried and
no way to override this.

        server = new RemoteServer(getConnectAttempts(), false);

The issue is available at https://issues.apache.org/jira/browse/TOMEE-1364




Chris

--


Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
Consultant

codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
<http://blog.codecentric.de/> | www.meettheexperts.de
<http://www.meettheexperts.de/> | www.more4fi.de <http://www.more4fi.de/>
 

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz

Diese E-Mail einschließlich evtl. beigefügter Dateien enthält vertrauliche
und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie
bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder Öffnen
evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail ist
nicht gestattet.






Am 25.09.14 23:15 schrieb "Romain Manni-Bucau" unter
<[hidden email]>:

>yep jira + patch would be awesome. Think it just needs a boolean
>goesOutOnFailure ;)
>
>
>Romain Manni-Bucau
>Twitter: @rmannibucau
>Blog: http://rmannibucau.wordpress.com/
>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>Github: https://github.com/rmannibucau
>
>
>2014-09-25 21:36 GMT+02:00 Christofer Dutz
><[hidden email]>:
>> Oh great
>>
>> Good to know it wasn’t me using the thing wrong. But I had the
>>impression
>> the number of reties was hard-coded to MAXINT and only overridden to 0
>>for
>> one subclass.
>>
>> If you like, I could whip up  fix for that first thing tomorrow morning.
>>
>> Chris
>>
>>
>> --
>>
>>
>> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
>> Consultant
>>
>> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main | Deutschland
>> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
>> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
>> <http://blog.codecentric.de/> | www.meettheexperts.de
>> <http://www.meettheexperts.de/> | www.more4fi.de
>><http://www.more4fi.de/>
>>
>>
>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
>> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>>Schütz
>>
>> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält
>>vertrauliche
>> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige
>> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren
>>Sie
>> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
>> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder
>>Öffnen
>> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail
>>ist
>> nicht gestattet.
>>
>>
>>
>>
>>
>>
>> Am 25.09.14 17:43 schrieb "Romain Manni-Bucau" unter
>> <[hidden email]>:
>>
>>>You are right! You should be able to workaround it setting
>>>connect.tries system property.
>>>
>>>
>>>Romain Manni-Bucau
>>>Twitter: @rmannibucau
>>>Blog: http://rmannibucau.wordpress.com/
>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>Github: https://github.com/rmannibucau
>>>
>>>
>>>2014-09-25 17:14 GMT+02:00 Christofer Dutz
>>><[hidden email]>:
>>>> Hi Romain,
>>>>
>>>> No change in 1.7.1 Š Same thing Š but as the code for stopping is
>>>> identical, I would not have expected any difference. I even checked
>>>>with
>>>> HEAD and as the code is still the same, I would assume the problem to
>>>> still be present in 2.0.0-SNAPSHOT
>>>>
>>>> Chris
>>>> --
>>>>
>>>>
>>>> Mit freundlichen Grüßen | Best regardsChristofer Dutz | Senior IT
>>>> Consultant
>>>>
>>>> codecentric AG | An der Welle 4 | 60322 Frankfurt am Main |
>>>>Deutschland
>>>> mobil: +49 (0) 1525.3057806 | fax: +49 (0) 69.7593-8200
>>>> www.codecentric.de <http://www.codecentric.de/> | blog.codecentric.de
>>>> <http://blog.codecentric.de/> | www.meettheexperts.de
>>>> <http://www.meettheexperts.de/> | www.more4fi.de
>>>><http://www.more4fi.de/>
>>>>
>>>>
>>>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht
>>>> WuppertalVorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>>>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>>>>Schütz
>>>>
>>>> Diese E-Mail einschließlich evtl. beigefügter Dateien enthält
>>>>vertrauliche
>>>> und/oder rechtlich geschützte Informationen. Wenn Sie nicht der
>>>>richtige
>>>> Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren
>>>>Sie
>>>> bitte sofort den Absender und löschen Sie diese E-Mail und evtl.
>>>> beigefügter Dateien umgehend. Das unerlaubte Kopieren, Nutzen oder
>>>>Öffnen
>>>> evtl. beigefügter Dateien sowie die unbefugte Weitergabe dieser E-Mail
>>>>ist
>>>> nicht gestattet.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Am 25.09.14 15:55 schrieb "Romain Manni-Bucau" unter
>>>> <[hidden email]>:
>>>>
>>>>>Hi
>>>>>
>>>>>before going further is it still the case with 1.7.1 version?
>>>>>
>>>>>
>>>>>Romain Manni-Bucau
>>>>>Twitter: @rmannibucau
>>>>>Blog: http://rmannibucau.wordpress.com/
>>>>>LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>>>>Github: https://github.com/rmannibucau
>>>>>
>>>>>
>>>>>2014-09-25 15:52 GMT+02:00 Christofer Dutz
>>>>><[hidden email]>:
>>>>>> Hi,
>>>>>>
>>>>>> I¹m currently struggling to get some integration-tests running and
>>>>>>have
>>>>>>stumbled over something that i might think could be a problem.
>>>>>>
>>>>>> Then using the tomee-maven-plugin 1.7.0 to start tomee before my
>>>>>>tests,
>>>>>>this works fine. After my tests I have maven call the stop goal. It
>>>>>>seems tomee is correctly shut down (All ports are closed and
>>>>>>processes
>>>>>>killed), but the plugin seemed to be waiting for ages.
>>>>>>
>>>>>> To me it seems the StopTomEEMojo calls server.forceStop to stop
>>>>>>TomEE
>>>>>>this then issues the server stop and goes into
>>>>>>waitForServerShutdown()
>>>>>>
>>>>>> This method now tries to connect to the shutdown port of tomcat for
>>>>>>MAXINT times. If the connection is successful the socket is closed
>>>>>>again
>>>>>>and true is returned and waitForServerShutdown while loop just calls
>>>>>>it
>>>>>>again. When looking at that method, to me it seems that the only
>>>>>>option
>>>>>>in which the while loop in RemoteServer.waitForServerShutdown() can
>>>>>>end,
>>>>>>is that the plugin has waited MAXINT seconds and has opened MAXINT
>>>>>>sockets. Why do you do that much recursion anyway? To me a simple
>>>>>>while
>>>>>>loop would have made sense here.
>>>>>>
>>>>>> In my case the first connection attempt already fails, but even if
>>>>>>if
>>>>>>didn¹t that wouldn¹t change the fact that I have to wait almost 70
>>>>>>years
>>>>>>for my test suite to finish ;-)
>>>>>>
>>>>>> Am I doing something wrong or does this code sort of smell a little
>>>>>>strange?
>>>>>>
>>>>>> Chris
>>>>>>
>>>>>>
>>>>
>>>>
>>
>>