[VOTE] Release Apache TomEE 8.0.0 (take 1)

classic Classic list List threaded Threaded
36 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Hi All,

Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
careful look, review, test and provide feedback.

Maven Repo:

https://repository.apache.org/content/repositories/orgapachetomee-1145

Binaries & Source:

https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/

Tag:

https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0

Release notes:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635

Please VOTE:

[+1] Yes, release it
[+0] Not fussed
[-1] Don't release, there's a showstopper (please specify what the
showstopper is)

Vote will be open for 72 hours or as needed.

Thanks

Jon
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Hi

To assist with the review - here are the library changes from 8.0.0-M3:

https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt

To save you clicking, here's the content:

apache-tomee 8.0.0 webprofile

  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
  ADD jackson-annotations-2.9.0.jar [66.52 ko]
  ADD jackson-core-2.9.9.jar [325.63 ko]
  ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]

  change: +2.01 MB
  total : 43.72 MB


apache-tomee 8.0.0 microprofile

  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]

  change: +0.52 MB
  total : 45.07 MB


apache-tomee 8.0.0 plus

  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
  ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]

  change: +0.57 MB
  total : 61.92 MB


apache-tomee 8.0.0 plume

  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
  ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]

  change: +0.57 MB
  total : 68.76 MB


openejb-standalone 8.0.0

  DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
  ADD jackson-annotations-2.9.0.jar [66.52 ko]
  ADD jackson-core-2.9.9.jar [325.63 ko]
  ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
  ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]

  change: +1.98 MB
  total : 42.08 MB

On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi All,
>
> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
> careful look, review, test and provide feedback.
>
> Maven Repo:
>
> https://repository.apache.org/content/repositories/orgapachetomee-1145
>
> Binaries & Source:
>
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
>
> Tag:
>
>
> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
>
> Release notes:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
>
> Please VOTE:
>
> [+1] Yes, release it
> [+0] Not fussed
> [-1] Don't release, there's a showstopper (please specify what the
> showstopper is)
>
> Vote will be open for 72 hours or as needed.
>
> Thanks
>
> Jon
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

Cesar Hernandez
Thanks for the update, Jonathan.
+1

El jue., 12 sept. 2019 a las 8:09, Jonathan Gallimore (<
[hidden email]>) escribió:

> Hi
>
> To assist with the review - here are the library changes from 8.0.0-M3:
>
>
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
>
> To save you clicking, here's the content:
>
> apache-tomee 8.0.0 webprofile
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>   ADD jackson-core-2.9.9.jar [325.63 ko]
>   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
>   change: +2.01 MB
>   total : 43.72 MB
>
>
> apache-tomee 8.0.0 microprofile
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
>   change: +0.52 MB
>   total : 45.07 MB
>
>
> apache-tomee 8.0.0 plus
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +0.57 MB
>   total : 61.92 MB
>
>
> apache-tomee 8.0.0 plume
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +0.57 MB
>   total : 68.76 MB
>
>
> openejb-standalone 8.0.0
>
>   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>   ADD jackson-core-2.9.9.jar [325.63 ko]
>   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +1.98 MB
>   total : 42.08 MB
>
> On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > Hi All,
> >
> > Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
> > careful look, review, test and provide feedback.
> >
> > Maven Repo:
> >
> > https://repository.apache.org/content/repositories/orgapachetomee-1145
> >
> > Binaries & Source:
> >
> > https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
> >
> > Tag:
> >
> >
> >
> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
> >
> > Release notes:
> >
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
> >
> > Please VOTE:
> >
> > [+1] Yes, release it
> > [+0] Not fussed
> > [-1] Don't release, there's a showstopper (please specify what the
> > showstopper is)
> >
> > Vote will be open for 72 hours or as needed.
> >
> > Thanks
> >
> > Jon
> >
>


--
Atentamente:
César Hernández.
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
In reply to this post by jgallimore
I've spent some time reviewing:

* Build looks ok
* Libraries added and licenses look ok
* Upgraded a production application to this RC running on Java 11 - looks
good
* Getting a RAT report has proved to be a pain. Running RAT standalone
produces this report:
https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a

Looks like we have 43 java files and 62 XML files without headers. I'll
correct these and re-roll. If there's any other feedback, please let me
know here and I'll incorporate that into a re-roll tonight.

Thanks

Jon

On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi
>
> To assist with the review - here are the library changes from 8.0.0-M3:
>
>
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
>
> To save you clicking, here's the content:
>
> apache-tomee 8.0.0 webprofile
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>   ADD jackson-core-2.9.9.jar [325.63 ko]
>   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
>   change: +2.01 MB
>   total : 43.72 MB
>
>
> apache-tomee 8.0.0 microprofile
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
>   change: +0.52 MB
>   total : 45.07 MB
>
>
> apache-tomee 8.0.0 plus
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +0.57 MB
>   total : 61.92 MB
>
>
> apache-tomee 8.0.0 plume
>
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +0.57 MB
>   total : 68.76 MB
>
>
> openejb-standalone 8.0.0
>
>   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
>   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>   ADD jackson-core-2.9.9.jar [325.63 ko]
>   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>
>   change: +1.98 MB
>   total : 42.08 MB
>
> On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
>> Hi All,
>>
>> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
>> careful look, review, test and provide feedback.
>>
>> Maven Repo:
>>
>> https://repository.apache.org/content/repositories/orgapachetomee-1145
>>
>> Binaries & Source:
>>
>> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
>>
>> Tag:
>>
>>
>> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
>>
>> Release notes:
>>
>>
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
>>
>> Please VOTE:
>>
>> [+1] Yes, release it
>> [+0] Not fussed
>> [-1] Don't release, there's a showstopper (please specify what the
>> showstopper is)
>>
>> Vote will be open for 72 hours or as needed.
>>
>> Thanks
>>
>> Jon
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

Emerson Castañeda
I am getting  this error during the build

[ERROR] Failed to execute goal on project openejb-core: Could not resolve
dependencies for project org.apache.tomee:openejb-core:jar:8.0.0: The
following artifacts could not be resolved:
org.apache.tomee:openejb-itests-app:jar:8.0.0,
org.apache.openejb.itests:failover-ejb:jar:8.0.0,
org.apache.tomee:openejb-itests-beans:jar:8.0.0,
org.apache.tomee:openejb-itests-interceptor-beans:jar:8.0.0,
org.apache.tomee:openejb-itests-client:jar:8.0.0: Could not find artifact
org.apache.tomee:openejb-itests-app:jar:8.0.0 in central_maven (
http://central.maven.org/maven2/) -> [Help 1]

It makes sense since all:  org.apache.tomee:openejb-itests-*:jar:8.0.0 are
not available in http://central.maven.org/maven2/

Only this artifacts are available:

8.0.0-M1/
8.0.0-M2/
8.0.0-M3/

Do I have to build/install those locally to be able to build tomme?

I'm using this command:

mvn -X -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true
-DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false
clean install

Thanks

Emerson

On Thu, Sep 12, 2019 at 12:40 PM Jonathan Gallimore <
[hidden email]> wrote:

> I've spent some time reviewing:
>
> * Build looks ok
> * Libraries added and licenses look ok
> * Upgraded a production application to this RC running on Java 11 - looks
> good
> * Getting a RAT report has proved to be a pain. Running RAT standalone
> produces this report:
> https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a
>
> Looks like we have 43 java files and 62 XML files without headers. I'll
> correct these and re-roll. If there's any other feedback, please let me
> know here and I'll incorporate that into a re-roll tonight.
>
> Thanks
>
> Jon
>
> On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > Hi
> >
> > To assist with the review - here are the library changes from 8.0.0-M3:
> >
> >
> >
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
> >
> > To save you clicking, here's the content:
> >
> > apache-tomee 8.0.0 webprofile
> >
> >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
> >   ADD jackson-core-2.9.9.jar [325.63 ko]
> >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
> >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> >
> >   change: +2.01 MB
> >   total : 43.72 MB
> >
> >
> > apache-tomee 8.0.0 microprofile
> >
> >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> >
> >   change: +0.52 MB
> >   total : 45.07 MB
> >
> >
> > apache-tomee 8.0.0 plus
> >
> >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> >
> >   change: +0.57 MB
> >   total : 61.92 MB
> >
> >
> > apache-tomee 8.0.0 plume
> >
> >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> >
> >   change: +0.57 MB
> >   total : 68.76 MB
> >
> >
> > openejb-standalone 8.0.0
> >
> >   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
> >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
> >   ADD jackson-core-2.9.9.jar [325.63 ko]
> >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
> >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> >
> >   change: +1.98 MB
> >   total : 42.08 MB
> >
> > On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> >> Hi All,
> >>
> >> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
> >> careful look, review, test and provide feedback.
> >>
> >> Maven Repo:
> >>
> >> https://repository.apache.org/content/repositories/orgapachetomee-1145
> >>
> >> Binaries & Source:
> >>
> >> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
> >>
> >> Tag:
> >>
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
> >>
> >> Release notes:
> >>
> >>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
> >>
> >> Please VOTE:
> >>
> >> [+1] Yes, release it
> >> [+0] Not fussed
> >> [-1] Don't release, there's a showstopper (please specify what the
> >> showstopper is)
> >>
> >> Vote will be open for 72 hours or as needed.
> >>
> >> Thanks
> >>
> >> Jon
> >>
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Hi Emerson!

Thanks for taking the time to review this! I assume you're building from
the source zip? I'll test it on a clean box. You won't see the 8.0.0
artifacts on Maven central until the release passes, but there are
available in the staging repository -
https://repository.apache.org/content/repositories/orgapachetomee-1145.
These artifacts should be in the project itself, so Maven shouldn't be
going off to look for them, so there's something potentially wrong there.

Jon



On Thu, Sep 12, 2019 at 6:00 PM Emerson Castañeda <[hidden email]> wrote:

> I am getting  this error during the build
>
> [ERROR] Failed to execute goal on project openejb-core: Could not resolve
> dependencies for project org.apache.tomee:openejb-core:jar:8.0.0: The
> following artifacts could not be resolved:
> org.apache.tomee:openejb-itests-app:jar:8.0.0,
> org.apache.openejb.itests:failover-ejb:jar:8.0.0,
> org.apache.tomee:openejb-itests-beans:jar:8.0.0,
> org.apache.tomee:openejb-itests-interceptor-beans:jar:8.0.0,
> org.apache.tomee:openejb-itests-client:jar:8.0.0: Could not find artifact
> org.apache.tomee:openejb-itests-app:jar:8.0.0 in central_maven (
> http://central.maven.org/maven2/) -> [Help 1]
>
> It makes sense since all:  org.apache.tomee:openejb-itests-*:jar:8.0.0 are
> not available in http://central.maven.org/maven2/
>
> Only this artifacts are available:
>
> 8.0.0-M1/
> 8.0.0-M2/
> 8.0.0-M3/
>
> Do I have to build/install those locally to be able to build tomme?
>
> I'm using this command:
>
> mvn -X -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true
> -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false
> clean install
>
> Thanks
>
> Emerson
>
> On Thu, Sep 12, 2019 at 12:40 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > I've spent some time reviewing:
> >
> > * Build looks ok
> > * Libraries added and licenses look ok
> > * Upgraded a production application to this RC running on Java 11 - looks
> > good
> > * Getting a RAT report has proved to be a pain. Running RAT standalone
> > produces this report:
> > https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a
> >
> > Looks like we have 43 java files and 62 XML files without headers. I'll
> > correct these and re-roll. If there's any other feedback, please let me
> > know here and I'll incorporate that into a re-roll tonight.
> >
> > Thanks
> >
> > Jon
> >
> > On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> > > Hi
> > >
> > > To assist with the review - here are the library changes from 8.0.0-M3:
> > >
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
> > >
> > > To save you clicking, here's the content:
> > >
> > > apache-tomee 8.0.0 webprofile
> > >
> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> > >
> > >   change: +2.01 MB
> > >   total : 43.72 MB
> > >
> > >
> > > apache-tomee 8.0.0 microprofile
> > >
> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> > >
> > >   change: +0.52 MB
> > >   total : 45.07 MB
> > >
> > >
> > > apache-tomee 8.0.0 plus
> > >
> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> > >
> > >   change: +0.57 MB
> > >   total : 61.92 MB
> > >
> > >
> > > apache-tomee 8.0.0 plume
> > >
> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> > >
> > >   change: +0.57 MB
> > >   total : 68.76 MB
> > >
> > >
> > > openejb-standalone 8.0.0
> > >
> > >   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
> > >
> > >   change: +1.98 MB
> > >   total : 42.08 MB
> > >
> > > On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
> > > [hidden email]> wrote:
> > >
> > >> Hi All,
> > >>
> > >> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take a
> > >> careful look, review, test and provide feedback.
> > >>
> > >> Maven Repo:
> > >>
> > >>
> https://repository.apache.org/content/repositories/orgapachetomee-1145
> > >>
> > >> Binaries & Source:
> > >>
> > >>
> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
> > >>
> > >> Tag:
> > >>
> > >>
> > >>
> >
> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
> > >>
> > >> Release notes:
> > >>
> > >>
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
> > >>
> > >> Please VOTE:
> > >>
> > >> [+1] Yes, release it
> > >> [+0] Not fussed
> > >> [-1] Don't release, there's a showstopper (please specify what the
> > >> showstopper is)
> > >>
> > >> Vote will be open for 72 hours or as needed.
> > >>
> > >> Thanks
> > >>
> > >> Jon
> > >>
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

David Blevins-2
In reply to this post by jgallimore

> On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore <[hidden email]> wrote:
>
>  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]

Befor the reroll, do a quick check to see if any of the above are already in other jars. (the javaee-8 jar)

>  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]

We should cut this one out in favor of geronimo-activation_1.1_spec-1.1.jar.


-David

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Will do! Thanks for pointer.

Jon

On Thu, Sep 12, 2019 at 7:39 PM David Blevins <[hidden email]>
wrote:

>
> > On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore <
> [hidden email]> wrote:
> >
> >  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>
> Befor the reroll, do a quick check to see if any of the above are already
> in other jars. (the javaee-8 jar)
>
> >  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
> We should cut this one out in favor of
> geronimo-activation_1.1_spec-1.1.jar.
>
>
> -David
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
In reply to this post by jgallimore
Hi Emerson,

Can you try your build again, but without the -Pquick parameter?

Thanks

Jon

On Thu, Sep 12, 2019 at 7:30 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi Emerson!
>
> Thanks for taking the time to review this! I assume you're building from
> the source zip? I'll test it on a clean box. You won't see the 8.0.0
> artifacts on Maven central until the release passes, but there are
> available in the staging repository -
> https://repository.apache.org/content/repositories/orgapachetomee-1145.
> These artifacts should be in the project itself, so Maven shouldn't be
> going off to look for them, so there's something potentially wrong there.
>
> Jon
>
>
>
> On Thu, Sep 12, 2019 at 6:00 PM Emerson Castañeda <[hidden email]>
> wrote:
>
>> I am getting  this error during the build
>>
>> [ERROR] Failed to execute goal on project openejb-core: Could not resolve
>> dependencies for project org.apache.tomee:openejb-core:jar:8.0.0: The
>> following artifacts could not be resolved:
>> org.apache.tomee:openejb-itests-app:jar:8.0.0,
>> org.apache.openejb.itests:failover-ejb:jar:8.0.0,
>> org.apache.tomee:openejb-itests-beans:jar:8.0.0,
>> org.apache.tomee:openejb-itests-interceptor-beans:jar:8.0.0,
>> org.apache.tomee:openejb-itests-client:jar:8.0.0: Could not find artifact
>> org.apache.tomee:openejb-itests-app:jar:8.0.0 in central_maven (
>> http://central.maven.org/maven2/) -> [Help 1]
>>
>> It makes sense since all:  org.apache.tomee:openejb-itests-*:jar:8.0.0 are
>> not available in http://central.maven.org/maven2/
>>
>> Only this artifacts are available:
>>
>> 8.0.0-M1/
>> 8.0.0-M2/
>> 8.0.0-M3/
>>
>> Do I have to build/install those locally to be able to build tomme?
>>
>> I'm using this command:
>>
>> mvn -X -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true
>> -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false
>> clean install
>>
>> Thanks
>>
>> Emerson
>>
>> On Thu, Sep 12, 2019 at 12:40 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > I've spent some time reviewing:
>> >
>> > * Build looks ok
>> > * Libraries added and licenses look ok
>> > * Upgraded a production application to this RC running on Java 11 -
>> looks
>> > good
>> > * Getting a RAT report has proved to be a pain. Running RAT standalone
>> > produces this report:
>> > https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a
>> >
>> > Looks like we have 43 java files and 62 XML files without headers. I'll
>> > correct these and re-roll. If there's any other feedback, please let me
>> > know here and I'll incorporate that into a re-roll tonight.
>> >
>> > Thanks
>> >
>> > Jon
>> >
>> > On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore <
>> > [hidden email]> wrote:
>> >
>> > > Hi
>> > >
>> > > To assist with the review - here are the library changes from
>> 8.0.0-M3:
>> > >
>> > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
>> > >
>> > > To save you clicking, here's the content:
>> > >
>> > > apache-tomee 8.0.0 webprofile
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
>> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >
>> > >   change: +2.01 MB
>> > >   total : 43.72 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 microprofile
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >
>> > >   change: +0.52 MB
>> > >   total : 45.07 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 plus
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +0.57 MB
>> > >   total : 61.92 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 plume
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +0.57 MB
>> > >   total : 68.76 MB
>> > >
>> > >
>> > > openejb-standalone 8.0.0
>> > >
>> > >   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
>> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +1.98 MB
>> > >   total : 42.08 MB
>> > >
>> > > On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
>> > > [hidden email]> wrote:
>> > >
>> > >> Hi All,
>> > >>
>> > >> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take
>> a
>> > >> careful look, review, test and provide feedback.
>> > >>
>> > >> Maven Repo:
>> > >>
>> > >>
>> https://repository.apache.org/content/repositories/orgapachetomee-1145
>> > >>
>> > >> Binaries & Source:
>> > >>
>> > >>
>> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
>> > >>
>> > >> Tag:
>> > >>
>> > >>
>> > >>
>> >
>> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
>> > >>
>> > >> Release notes:
>> > >>
>> > >>
>> > >>
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
>> > >>
>> > >> Please VOTE:
>> > >>
>> > >> [+1] Yes, release it
>> > >> [+0] Not fussed
>> > >> [-1] Don't release, there's a showstopper (please specify what the
>> > >> showstopper is)
>> > >>
>> > >> Vote will be open for 72 hours or as needed.
>> > >>
>> > >> Thanks
>> > >>
>> > >> Jon
>> > >>
>> > >
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
In reply to this post by David Blevins-2
Hi David!

Thanks for pointing this out. I've got the list of duplicate - I'd
appreciate yours (and anyone else's) view on the conflicts below:

Full set of duplicate classes is here:
https://gist.github.com/jgallimore/9f653f4fa3aec515051f6cd76af7c48f

Essentially we have the following conflicts:

javax.activation:

- jakarta.activation-1.2.1.jar
- jakarta.activation-api-1.2.1.jar (*)
- geronimo-activation_1.1_spec-1.1.jar (*)

javax.interceptor:

- javaee-api-8.0-2.jar
- geronimo-interceptor_1.2_spec-1.0.jar (*)

javax.mail:

- geronimo-javamail_1.4_spec-1.7.1.jar (*)
- geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar

javax.persistence:

- javaee-api-8.0-2.jar
- geronimo-jpa_2.2_spec-1.0.jar (*)

javax.xml.soap:

- javaee-api-8.0-2.jar
- jakarta.xml.soap-api-1.4.1.jar (*)

javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
and javax/xml/ws/wsaddressing/W3CEndpointReference.class:

- javaee-api-8.0-2.jar
- openejb-client-8.0.0.jar

org.apache.geronimo.mail:

- geronimo-javamail_1.4_spec-1.7.1.jar (*)
- geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar

org.apache.geronimo.osgi.locator:

- geronimo-javamail_1.4_spec-1.7.1.jar (*)
- geronimo-activation_1.1_spec-1.1.jar (*)
- geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar

The lines with a (*) are the jars I'd suggest *removing*, but I'd
appreciate guidance. The set to remove would be:

geronimo-activation_1.1_spec-1.1.jar (covered
by jakarta.activation-1.2.1.jar)
jakarta.activation-api-1.2.1.jar  (covered by jakarta.activation-1.2.1.jar)
<-- this seems strange to me, but I can confirm that
jakarta.activation-1.2.1.jar contains both the api and impl - is that
intended?
geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
geronimo-javamail_1.4_spec-1.7.1.jar (covered
by geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)

Does that sound reasonable?

Jon


On Thu, Sep 12, 2019 at 7:39 PM David Blevins <[hidden email]>
wrote:

>
> > On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore <
> [hidden email]> wrote:
> >
> >  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
> >  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
> >  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>
> Befor the reroll, do a quick check to see if any of the above are already
> in other jars. (the javaee-8 jar)
>
> >  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>
> We should cut this one out in favor of
> geronimo-activation_1.1_spec-1.1.jar.
>
>
> -David
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Also, I'll take a look at openejb-client, but I'm not too sure what do with
this conflict:

javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
and javax/xml/ws/wsaddressing/W3CEndpointReference.class:

- javaee-api-8.0-2.jar
- openejb-client-8.0.0.jar

Any thoughts?

Jon

On Thu, Sep 12, 2019 at 9:02 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi David!
>
> Thanks for pointing this out. I've got the list of duplicate - I'd
> appreciate yours (and anyone else's) view on the conflicts below:
>
> Full set of duplicate classes is here:
> https://gist.github.com/jgallimore/9f653f4fa3aec515051f6cd76af7c48f
>
> Essentially we have the following conflicts:
>
> javax.activation:
>
> - jakarta.activation-1.2.1.jar
> - jakarta.activation-api-1.2.1.jar (*)
> - geronimo-activation_1.1_spec-1.1.jar (*)
>
> javax.interceptor:
>
> - javaee-api-8.0-2.jar
> - geronimo-interceptor_1.2_spec-1.0.jar (*)
>
> javax.mail:
>
> - geronimo-javamail_1.4_spec-1.7.1.jar (*)
> - geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar
>
> javax.persistence:
>
> - javaee-api-8.0-2.jar
> - geronimo-jpa_2.2_spec-1.0.jar (*)
>
> javax.xml.soap:
>
> - javaee-api-8.0-2.jar
> - jakarta.xml.soap-api-1.4.1.jar (*)
>
> javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>
> - javaee-api-8.0-2.jar
> - openejb-client-8.0.0.jar
>
> org.apache.geronimo.mail:
>
> - geronimo-javamail_1.4_spec-1.7.1.jar (*)
> - geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar
>
> org.apache.geronimo.osgi.locator:
>
> - geronimo-javamail_1.4_spec-1.7.1.jar (*)
> - geronimo-activation_1.1_spec-1.1.jar (*)
> - geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar
>
> The lines with a (*) are the jars I'd suggest *removing*, but I'd
> appreciate guidance. The set to remove would be:
>
> geronimo-activation_1.1_spec-1.1.jar (covered
> by jakarta.activation-1.2.1.jar)
> jakarta.activation-api-1.2.1.jar  (covered
> by jakarta.activation-1.2.1.jar) <-- this seems strange to me, but I can
> confirm that jakarta.activation-1.2.1.jar contains both the api and impl -
> is that intended?
> geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> geronimo-javamail_1.4_spec-1.7.1.jar (covered
> by geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
> geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)
>
> Does that sound reasonable?
>
> Jon
>
>
> On Thu, Sep 12, 2019 at 7:39 PM David Blevins <[hidden email]>
> wrote:
>
>>
>> > On Sep 12, 2019, at 7:09 AM, Jonathan Gallimore <
>> [hidden email]> wrote:
>> >
>> >  ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> >  ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> >  ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>>
>> Befor the reroll, do a quick check to see if any of the above are already
>> in other jars. (the javaee-8 jar)
>>
>> >  ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>>
>> We should cut this one out in favor of
>> geronimo-activation_1.1_spec-1.1.jar.
>>
>>
>> -David
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
In reply to this post by jgallimore
Hi Emerson,

My build on a clean VM worked here. For reference, I ran:

mvn -Dsurefire.useFile=false -DdisableXmlReport=true -DuniqueVersion=false
-ff -Dassemble -DskipTests -DfailIfNoTests=false clean install | tee
build.log

(note, no -Pquick)

Cheers!

Jon

On Thu, Sep 12, 2019 at 7:30 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi Emerson!
>
> Thanks for taking the time to review this! I assume you're building from
> the source zip? I'll test it on a clean box. You won't see the 8.0.0
> artifacts on Maven central until the release passes, but there are
> available in the staging repository -
> https://repository.apache.org/content/repositories/orgapachetomee-1145.
> These artifacts should be in the project itself, so Maven shouldn't be
> going off to look for them, so there's something potentially wrong there.
>
> Jon
>
>
>
> On Thu, Sep 12, 2019 at 6:00 PM Emerson Castañeda <[hidden email]>
> wrote:
>
>> I am getting  this error during the build
>>
>> [ERROR] Failed to execute goal on project openejb-core: Could not resolve
>> dependencies for project org.apache.tomee:openejb-core:jar:8.0.0: The
>> following artifacts could not be resolved:
>> org.apache.tomee:openejb-itests-app:jar:8.0.0,
>> org.apache.openejb.itests:failover-ejb:jar:8.0.0,
>> org.apache.tomee:openejb-itests-beans:jar:8.0.0,
>> org.apache.tomee:openejb-itests-interceptor-beans:jar:8.0.0,
>> org.apache.tomee:openejb-itests-client:jar:8.0.0: Could not find artifact
>> org.apache.tomee:openejb-itests-app:jar:8.0.0 in central_maven (
>> http://central.maven.org/maven2/) -> [Help 1]
>>
>> It makes sense since all:  org.apache.tomee:openejb-itests-*:jar:8.0.0 are
>> not available in http://central.maven.org/maven2/
>>
>> Only this artifacts are available:
>>
>> 8.0.0-M1/
>> 8.0.0-M2/
>> 8.0.0-M3/
>>
>> Do I have to build/install those locally to be able to build tomme?
>>
>> I'm using this command:
>>
>> mvn -X -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true
>> -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false
>> clean install
>>
>> Thanks
>>
>> Emerson
>>
>> On Thu, Sep 12, 2019 at 12:40 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > I've spent some time reviewing:
>> >
>> > * Build looks ok
>> > * Libraries added and licenses look ok
>> > * Upgraded a production application to this RC running on Java 11 -
>> looks
>> > good
>> > * Getting a RAT report has proved to be a pain. Running RAT standalone
>> > produces this report:
>> > https://gist.github.com/jgallimore/be3e120b76c5424ed4903fe06ff6337a
>> >
>> > Looks like we have 43 java files and 62 XML files without headers. I'll
>> > correct these and re-roll. If there's any other feedback, please let me
>> > know here and I'll incorporate that into a re-roll tonight.
>> >
>> > Thanks
>> >
>> > Jon
>> >
>> > On Thu, Sep 12, 2019 at 3:09 PM Jonathan Gallimore <
>> > [hidden email]> wrote:
>> >
>> > > Hi
>> > >
>> > > To assist with the review - here are the library changes from
>> 8.0.0-M3:
>> > >
>> > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/DIFF.txt
>> > >
>> > > To save you clicking, here's the content:
>> > >
>> > > apache-tomee 8.0.0 webprofile
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
>> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >
>> > >   change: +2.01 MB
>> > >   total : 43.72 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 microprofile
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >
>> > >   change: +0.52 MB
>> > >   total : 45.07 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 plus
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +0.57 MB
>> > >   total : 61.92 MB
>> > >
>> > >
>> > > apache-tomee 8.0.0 plume
>> > >
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +0.57 MB
>> > >   total : 68.76 MB
>> > >
>> > >
>> > > openejb-standalone 8.0.0
>> > >
>> > >   DEL javax.xml.soap-api-1.3.5.jar [40.81 ko]
>> > >   ADD geronimo-activation_1.1_spec-1.1.jar [47.47 ko]
>> > >   ADD geronimo-javamail_1.4_spec-1.7.1.jar [223.30 ko]
>> > >   ADD geronimo-jpa_2.2_spec-1.0.jar [128.50 ko]
>> > >   ADD jackson-annotations-2.9.0.jar [66.52 ko]
>> > >   ADD jackson-core-2.9.9.jar [325.63 ko]
>> > >   ADD jackson-databind-2.9.9.3.jar [1348.39 ko]
>> > >   ADD jakarta.activation-api-1.2.1.jar [44.40 ko]
>> > >   ADD jakarta.xml.soap-api-1.4.1.jar [36.16 ko]
>> > >
>> > >   change: +1.98 MB
>> > >   total : 42.08 MB
>> > >
>> > > On Wed, Sep 11, 2019 at 11:54 PM Jonathan Gallimore <
>> > > [hidden email]> wrote:
>> > >
>> > >> Hi All,
>> > >>
>> > >> Here's a first attempt at roll of a TomEE 8.0.0. Please can you take
>> a
>> > >> careful look, review, test and provide feedback.
>> > >>
>> > >> Maven Repo:
>> > >>
>> > >>
>> https://repository.apache.org/content/repositories/orgapachetomee-1145
>> > >>
>> > >> Binaries & Source:
>> > >>
>> > >>
>> https://dist.apache.org/repos/dist/dev/tomee/staging-1145/tomee-8.0.0/
>> > >>
>> > >> Tag:
>> > >>
>> > >>
>> > >>
>> >
>> https://gitbox.apache.org/repos/asf?p=tomee.git;a=tag;h=refs/tags/tomee-8.0.0
>> > >>
>> > >> Release notes:
>> > >>
>> > >>
>> > >>
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12312320&version=12344635
>> > >>
>> > >> Please VOTE:
>> > >>
>> > >> [+1] Yes, release it
>> > >> [+0] Not fussed
>> > >> [-1] Don't release, there's a showstopper (please specify what the
>> > >> showstopper is)
>> > >>
>> > >> Vote will be open for 72 hours or as needed.
>> > >>
>> > >> Thanks
>> > >>
>> > >> Jon
>> > >>
>> > >
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

David Blevins-2
In reply to this post by jgallimore
> On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <[hidden email]> wrote:
>
> Also, I'll take a look at openejb-client, but I'm not too sure what do with
> this conflict:
>
> javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>
> - javaee-api-8.0-2.jar
> - openejb-client-8.0.0.jar
>
> Any thoughts?

Only suspecting it might have already been there in a past release.

If that's the case, IMO, any conflicts that were there in 7.x, we ignore for now.  So if this one is status quo, it's fine.


-David

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

Emerson Castañeda
 Hi Jon

Thank you for your reply
I am building directly from the repo on the tag (tomee-8.0.0)

I have re-run the build removing  -Pquick

Now the process is going further, right now, (49/322) and going, it usually
takes about 25 minutes, I'm not sure why it is too long.

Thanks

Emerson

On Thu, Sep 12, 2019 at 4:19 PM David Blevins <[hidden email]>
wrote:

> > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
> [hidden email]> wrote:
> >
> > Also, I'll take a look at openejb-client, but I'm not too sure what do
> with
> > this conflict:
> >
> > javax/xml/ws/EndpointReference.class,
> javax/xml/ws/WebServiceFeature.class
> > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> >
> > - javaee-api-8.0-2.jar
> > - openejb-client-8.0.0.jar
> >
> > Any thoughts?
>
> Only suspecting it might have already been there in a past release.
>
> If that's the case, IMO, any conflicts that were there in 7.x, we ignore
> for now.  So if this one is status quo, it's fine.
>
>
> -David
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
-Pquick skips quite a lot of stuff, including examples. In your case, it
was also skipping the itests module, and Maven isn't able to get those from
Maven central (yet). The command I ran here, with a clean ~/.m2/repository
took 58 minutes.

Jon

On Thu, Sep 12, 2019 at 9:24 PM Emerson Castañeda <[hidden email]> wrote:

>  Hi Jon
>
> Thank you for your reply
> I am building directly from the repo on the tag (tomee-8.0.0)
>
> I have re-run the build removing  -Pquick
>
> Now the process is going further, right now, (49/322) and going, it usually
> takes about 25 minutes, I'm not sure why it is too long.
>
> Thanks
>
> Emerson
>
> On Thu, Sep 12, 2019 at 4:19 PM David Blevins <[hidden email]>
> wrote:
>
> > > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
> > [hidden email]> wrote:
> > >
> > > Also, I'll take a look at openejb-client, but I'm not too sure what do
> > with
> > > this conflict:
> > >
> > > javax/xml/ws/EndpointReference.class,
> > javax/xml/ws/WebServiceFeature.class
> > > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> > >
> > > - javaee-api-8.0-2.jar
> > > - openejb-client-8.0.0.jar
> > >
> > > Any thoughts?
> >
> > Only suspecting it might have already been there in a past release.
> >
> > If that's the case, IMO, any conflicts that were there in 7.x, we ignore
> > for now.  So if this one is status quo, it's fine.
> >
> >
> > -David
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
In reply to this post by David Blevins-2
Here's the same analysis on TomEE 7.0.6:

javax.activation:
- lib/activation-1.1.jar
- lib/javaee-api-7.0-1.jar

javax.xml.stream:
- lib/stax-api-1.0-2.jar
- lib/javaee-api-7.0-1.jar

javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
- lib/openejb-client-7.0.6.jar
- lib/javaee-api-7.0-1.jar

So I think removing the following is the way to go:

geronimo-activation_1.1_spec-1.1.jar (covered by
jakarta.activation-1.2.1.jar)
jakarta.activation-api-1.2.1.jar  (covered by jakarta.activation-1.2.1.jar)
geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
geronimo-javamail_1.4_spec-1.7.1.jar (covered by
geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)

I'll get started, but please do shout if that looks wrong.

Jon

On Thu, Sep 12, 2019 at 9:19 PM David Blevins <[hidden email]>
wrote:

> > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
> [hidden email]> wrote:
> >
> > Also, I'll take a look at openejb-client, but I'm not too sure what do
> with
> > this conflict:
> >
> > javax/xml/ws/EndpointReference.class,
> javax/xml/ws/WebServiceFeature.class
> > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> >
> > - javaee-api-8.0-2.jar
> > - openejb-client-8.0.0.jar
> >
> > Any thoughts?
>
> Only suspecting it might have already been there in a past release.
>
> If that's the case, IMO, any conflicts that were there in 7.x, we ignore
> for now.  So if this one is status quo, it's fine.
>
>
> -David
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

David Blevins
Had a longer response but the planet started boarding and now I have to
start again on cell :)

Agree with all your removals.  Note on Jakarta activation 1.2, we’ll want
to eventually switch to Geronimo Activation 1.2 when we get that ready.

We need to update the LICENSE and NOTICE files of each dust to add the EPL
v2.  When I looked at this a few days ago, I also noticed only some of them
had the EPL v1, so that should get fixed as well; all our dists have the
ecj jar so need the EPL v1.



On Thu, Sep 12, 2019 at 1:38 PM Jonathan Gallimore <
[hidden email]> wrote:

> Here's the same analysis on TomEE 7.0.6:
>
> javax.activation:
> - lib/activation-1.1.jar
> - lib/javaee-api-7.0-1.jar
>
> javax.xml.stream:
> - lib/stax-api-1.0-2.jar
> - lib/javaee-api-7.0-1.jar
>
> javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> - lib/openejb-client-7.0.6.jar
> - lib/javaee-api-7.0-1.jar
>
> So I think removing the following is the way to go:
>
> geronimo-activation_1.1_spec-1.1.jar (covered by
> jakarta.activation-1.2.1.jar)
> jakarta.activation-api-1.2.1.jar  (covered by jakarta.activation-1.2.1.jar)
> geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> geronimo-javamail_1.4_spec-1.7.1.jar (covered by
> geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
> geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)
>
> I'll get started, but please do shout if that looks wrong.
>
> Jon
>
> On Thu, Sep 12, 2019 at 9:19 PM David Blevins <[hidden email]>
> wrote:
>
> > > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
> > [hidden email]> wrote:
> > >
> > > Also, I'll take a look at openejb-client, but I'm not too sure what do
> > with
> > > this conflict:
> > >
> > > javax/xml/ws/EndpointReference.class,
> > javax/xml/ws/WebServiceFeature.class
> > > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> > >
> > > - javaee-api-8.0-2.jar
> > > - openejb-client-8.0.0.jar
> > >
> > > Any thoughts?
> >
> > Only suspecting it might have already been there in a past release.
> >
> > If that's the case, IMO, any conflicts that were there in 7.x, we ignore
> > for now.  So if this one is status quo, it's fine.
> >
> >
> > -David
> >
> >
>
--
Sent from Gmail Mobile
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

David Blevins
Plane, but planet works too — although a slight exaggeration :)

On Thu, Sep 12, 2019 at 1:53 PM David Blevins <[hidden email]>
wrote:

> Had a longer response but the planet started boarding and now I have to
> start again on cell :)
>
> Agree with all your removals.  Note on Jakarta activation 1.2, we’ll want
> to eventually switch to Geronimo Activation 1.2 when we get that ready.
>
> We need to update the LICENSE and NOTICE files of each dust to add the EPL
> v2.  When I looked at this a few days ago, I also noticed only some of them
> had the EPL v1, so that should get fixed as well; all our dists have the
> ecj jar so need the EPL v1.
>
>
>
> On Thu, Sep 12, 2019 at 1:38 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
>> Here's the same analysis on TomEE 7.0.6:
>>
>> javax.activation:
>> - lib/activation-1.1.jar
>> - lib/javaee-api-7.0-1.jar
>>
>> javax.xml.stream:
>> - lib/stax-api-1.0-2.jar
>> - lib/javaee-api-7.0-1.jar
>>
>> javax/xml/ws/EndpointReference.class, javax/xml/ws/WebServiceFeature.class
>> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>> - lib/openejb-client-7.0.6.jar
>> - lib/javaee-api-7.0-1.jar
>>
>> So I think removing the following is the way to go:
>>
>> geronimo-activation_1.1_spec-1.1.jar (covered by
>> jakarta.activation-1.2.1.jar)
>> jakarta.activation-api-1.2.1.jar  (covered by
>> jakarta.activation-1.2.1.jar)
>> geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
>> geronimo-javamail_1.4_spec-1.7.1.jar (covered by
>> geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
>> geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
>> jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)
>>
>> I'll get started, but please do shout if that looks wrong.
>>
>> Jon
>>
>> On Thu, Sep 12, 2019 at 9:19 PM David Blevins <[hidden email]>
>> wrote:
>>
>> > > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
>> > [hidden email]> wrote:
>> > >
>> > > Also, I'll take a look at openejb-client, but I'm not too sure what do
>> > with
>> > > this conflict:
>> > >
>> > > javax/xml/ws/EndpointReference.class,
>> > javax/xml/ws/WebServiceFeature.class
>> > > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>> > >
>> > > - javaee-api-8.0-2.jar
>> > > - openejb-client-8.0.0.jar
>> > >
>> > > Any thoughts?
>> >
>> > Only suspecting it might have already been there in a past release.
>> >
>> > If that's the case, IMO, any conflicts that were there in 7.x, we ignore
>> > for now.  So if this one is status quo, it's fine.
>> >
>> >
>> > -David
>> >
>> >
>>
> --
> Sent from Gmail Mobile
>
--
Sent from Gmail Mobile
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
Awesome, thanks for the detail. I'm working on the PR now. I post updates
here as I have them. Intention is to have take 2 rolled by the end of the
evening.

Have a safe flight!

Jon

On Thu, Sep 12, 2019 at 9:55 PM David Blevins <[hidden email]>
wrote:

> Plane, but planet works too — although a slight exaggeration :)
>
> On Thu, Sep 12, 2019 at 1:53 PM David Blevins <[hidden email]>
> wrote:
>
> > Had a longer response but the planet started boarding and now I have to
> > start again on cell :)
> >
> > Agree with all your removals.  Note on Jakarta activation 1.2, we’ll want
> > to eventually switch to Geronimo Activation 1.2 when we get that ready.
> >
> > We need to update the LICENSE and NOTICE files of each dust to add the
> EPL
> > v2.  When I looked at this a few days ago, I also noticed only some of
> them
> > had the EPL v1, so that should get fixed as well; all our dists have the
> > ecj jar so need the EPL v1.
> >
> >
> >
> > On Thu, Sep 12, 2019 at 1:38 PM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> >> Here's the same analysis on TomEE 7.0.6:
> >>
> >> javax.activation:
> >> - lib/activation-1.1.jar
> >> - lib/javaee-api-7.0-1.jar
> >>
> >> javax.xml.stream:
> >> - lib/stax-api-1.0-2.jar
> >> - lib/javaee-api-7.0-1.jar
> >>
> >> javax/xml/ws/EndpointReference.class,
> javax/xml/ws/WebServiceFeature.class
> >> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> >> - lib/openejb-client-7.0.6.jar
> >> - lib/javaee-api-7.0-1.jar
> >>
> >> So I think removing the following is the way to go:
> >>
> >> geronimo-activation_1.1_spec-1.1.jar (covered by
> >> jakarta.activation-1.2.1.jar)
> >> jakarta.activation-api-1.2.1.jar  (covered by
> >> jakarta.activation-1.2.1.jar)
> >> geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> >> geronimo-javamail_1.4_spec-1.7.1.jar (covered by
> >> geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
> >> geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
> >> jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)
> >>
> >> I'll get started, but please do shout if that looks wrong.
> >>
> >> Jon
> >>
> >> On Thu, Sep 12, 2019 at 9:19 PM David Blevins <[hidden email]>
> >> wrote:
> >>
> >> > > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
> >> > [hidden email]> wrote:
> >> > >
> >> > > Also, I'll take a look at openejb-client, but I'm not too sure what
> do
> >> > with
> >> > > this conflict:
> >> > >
> >> > > javax/xml/ws/EndpointReference.class,
> >> > javax/xml/ws/WebServiceFeature.class
> >> > > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
> >> > >
> >> > > - javaee-api-8.0-2.jar
> >> > > - openejb-client-8.0.0.jar
> >> > >
> >> > > Any thoughts?
> >> >
> >> > Only suspecting it might have already been there in a past release.
> >> >
> >> > If that's the case, IMO, any conflicts that were there in 7.x, we
> ignore
> >> > for now.  So if this one is status quo, it's fine.
> >> >
> >> >
> >> > -David
> >> >
> >> >
> >>
> > --
> > Sent from Gmail Mobile
> >
> --
> Sent from Gmail Mobile
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache TomEE 8.0.0 (take 1)

jgallimore
If anyone knows how to exclude jakarta.activation-api in the new bom
module, I'd sure appreciate the help. I'd expect

          <exclusion> <!-- Is already included in java-ee-api -->
            <artifactId>jakarta.activation</artifactId>
            <groupId>jakarta.activation-api</groupId>
          </exclusion>

to work, but it seems like no matter where I exclude it, it keeps popping
up.

Jon

On Thu, Sep 12, 2019 at 10:03 PM Jonathan Gallimore <
[hidden email]> wrote:

> Awesome, thanks for the detail. I'm working on the PR now. I post updates
> here as I have them. Intention is to have take 2 rolled by the end of the
> evening.
>
> Have a safe flight!
>
> Jon
>
> On Thu, Sep 12, 2019 at 9:55 PM David Blevins <[hidden email]>
> wrote:
>
>> Plane, but planet works too — although a slight exaggeration :)
>>
>> On Thu, Sep 12, 2019 at 1:53 PM David Blevins <[hidden email]>
>> wrote:
>>
>> > Had a longer response but the planet started boarding and now I have to
>> > start again on cell :)
>> >
>> > Agree with all your removals.  Note on Jakarta activation 1.2, we’ll
>> want
>> > to eventually switch to Geronimo Activation 1.2 when we get that ready.
>> >
>> > We need to update the LICENSE and NOTICE files of each dust to add the
>> EPL
>> > v2.  When I looked at this a few days ago, I also noticed only some of
>> them
>> > had the EPL v1, so that should get fixed as well; all our dists have the
>> > ecj jar so need the EPL v1.
>> >
>> >
>> >
>> > On Thu, Sep 12, 2019 at 1:38 PM Jonathan Gallimore <
>> > [hidden email]> wrote:
>> >
>> >> Here's the same analysis on TomEE 7.0.6:
>> >>
>> >> javax.activation:
>> >> - lib/activation-1.1.jar
>> >> - lib/javaee-api-7.0-1.jar
>> >>
>> >> javax.xml.stream:
>> >> - lib/stax-api-1.0-2.jar
>> >> - lib/javaee-api-7.0-1.jar
>> >>
>> >> javax/xml/ws/EndpointReference.class,
>> javax/xml/ws/WebServiceFeature.class
>> >> and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>> >> - lib/openejb-client-7.0.6.jar
>> >> - lib/javaee-api-7.0-1.jar
>> >>
>> >> So I think removing the following is the way to go:
>> >>
>> >> geronimo-activation_1.1_spec-1.1.jar (covered by
>> >> jakarta.activation-1.2.1.jar)
>> >> jakarta.activation-api-1.2.1.jar  (covered by
>> >> jakarta.activation-1.2.1.jar)
>> >> geronimo-interceptor_1.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
>> >> geronimo-javamail_1.4_spec-1.7.1.jar (covered by
>> >> geronimo-javamail_1.4_mail-1.9.0-alpha-2.jar)
>> >> geronimo-jpa_2.2_spec-1.0.jar (covered by javaee-api-8.0-2.jar)
>> >> jakarta.xml.soap-api-1.4.1.jar (covered by javaee-api-8.0-2.jar)
>> >>
>> >> I'll get started, but please do shout if that looks wrong.
>> >>
>> >> Jon
>> >>
>> >> On Thu, Sep 12, 2019 at 9:19 PM David Blevins <[hidden email]
>> >
>> >> wrote:
>> >>
>> >> > > On Sep 12, 2019, at 1:03 PM, Jonathan Gallimore <
>> >> > [hidden email]> wrote:
>> >> > >
>> >> > > Also, I'll take a look at openejb-client, but I'm not too sure
>> what do
>> >> > with
>> >> > > this conflict:
>> >> > >
>> >> > > javax/xml/ws/EndpointReference.class,
>> >> > javax/xml/ws/WebServiceFeature.class
>> >> > > and javax/xml/ws/wsaddressing/W3CEndpointReference.class:
>> >> > >
>> >> > > - javaee-api-8.0-2.jar
>> >> > > - openejb-client-8.0.0.jar
>> >> > >
>> >> > > Any thoughts?
>> >> >
>> >> > Only suspecting it might have already been there in a past release.
>> >> >
>> >> > If that's the case, IMO, any conflicts that were there in 7.x, we
>> ignore
>> >> > for now.  So if this one is status quo, it's fine.
>> >> >
>> >> >
>> >> > -David
>> >> >
>> >> >
>> >>
>> > --
>> > Sent from Gmail Mobile
>> >
>> --
>> Sent from Gmail Mobile
>>
>
12