[VOTE] OpenEJB 3.1.2

classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[VOTE] OpenEJB 3.1.2

dblevins
Administrator
Ok, we have binaries!

Repo:

   https://repository.apache.org/content/repositories/openejb-014

Binaries:

   http://people.apache.org/~dblevins/stage/3.1.2/

Branch (to become a tag):

   http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/


And so you can test out the binaries, here's an updated ant script as  
usual:

   http://people.apache.org/~dblevins/stage/build.xml

   "ant test:all"

Things look good on osx so far, haven't tried windoze yet.


-David


 
 
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Quintin Beukes-2
test:all ran fine here in both JDK1.5.0_17 and JDK1.6.0_11 on Ubuntu
8.04 - Linux quintin-desktop 2.6.24-24-386 #1 Tue Jun 30 19:54:55 UTC
2009 i686 GNU/Linux

I also compiled and ran our unit tests against it for all our projects
that use 3.1.2, and they ran fine as well. About 150 tests which test
remote+local EJBs, multiple persistence units, stateless + singleton
beans, security, and a bunch of other stuff. Not all OpenEJBs
features, but a fare set of them.

So over here it seems good.

I did notice a peculiar behavior from the tomcat download server
though. It doesn't feed me more than 4.8mb for any download. As soon
as it reaches between 4800k and 4900k (not fixed, random) it fails and
the download had to stop/resume. So I had to make a script that uses
wget to predownload them, else the ant builds kept failing. Nothing
bad, just thought I'd share this as it was a pretty fascinating
"oddity".

Quintin Beukes



On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]> wrote:

> Ok, we have binaries!
>
> Repo:
>
>  https://repository.apache.org/content/repositories/openejb-014
>
> Binaries:
>
>  http://people.apache.org/~dblevins/stage/3.1.2/
>
> Branch (to become a tag):
>
>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>
>
> And so you can test out the binaries, here's an updated ant script as usual:
>
>  http://people.apache.org/~dblevins/stage/build.xml
>
>  "ant test:all"
>
> Things look good on osx so far, haven't tried windoze yet.
>
>
> -David
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

jgallimore
I've run the tests against JDK 1.6.0_16 on Ubuntu 9.04 (x64) and JDK
1.6.0_13 on Windows XP. Everything completed successfully for me (I didn't
see the problem Quintin did, but I did have it last time around, where I ran
the script a few times on a couple of machines simultaneously... I guessed
it was some network issue or something at the time).

I've run RAT over the source, and checked the LICENSE/NOTICE files and
haven't spotted any problems, so it looks good to me.

+1

Jon

On Sat, Oct 10, 2009 at 11:19 PM, Quintin Beukes <[hidden email]>wrote:

> test:all ran fine here in both JDK1.5.0_17 and JDK1.6.0_11 on Ubuntu
> 8.04 - Linux quintin-desktop 2.6.24-24-386 #1 Tue Jun 30 19:54:55 UTC
> 2009 i686 GNU/Linux
>
> I also compiled and ran our unit tests against it for all our projects
> that use 3.1.2, and they ran fine as well. About 150 tests which test
> remote+local EJBs, multiple persistence units, stateless + singleton
> beans, security, and a bunch of other stuff. Not all OpenEJBs
> features, but a fare set of them.
>
> So over here it seems good.
>
> I did notice a peculiar behavior from the tomcat download server
> though. It doesn't feed me more than 4.8mb for any download. As soon
> as it reaches between 4800k and 4900k (not fixed, random) it fails and
> the download had to stop/resume. So I had to make a script that uses
> wget to predownload them, else the ant builds kept failing. Nothing
> bad, just thought I'd share this as it was a pretty fascinating
> "oddity".
>
> Quintin Beukes
>
>
>
> On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]>
> wrote:
> > Ok, we have binaries!
> >
> > Repo:
> >
> >  https://repository.apache.org/content/repositories/openejb-014
> >
> > Binaries:
> >
> >  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
> >
> > Branch (to become a tag):
> >
> >  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
> >
> >
> > And so you can test out the binaries, here's an updated ant script as
> usual:
> >
> >  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
> >
> >  "ant test:all"
> >
> > Things look good on osx so far, haven't tried windoze yet.
> >
> >
> > -David
> >
> >
> >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Jacek Laskowski
In reply to this post by dblevins
+1

Jacek

On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]> wrote:

> Ok, we have binaries!
>
> Repo:
>
>  https://repository.apache.org/content/repositories/openejb-014
>
> Binaries:
>
>  http://people.apache.org/~dblevins/stage/3.1.2/
>
> Branch (to become a tag):
>
>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>
>
> And so you can test out the binaries, here's an updated ant script as usual:
>
>  http://people.apache.org/~dblevins/stage/build.xml
>
>  "ant test:all"
>
> Things look good on osx so far, haven't tried windoze yet.
>
>
> -David
>
>
>
>



--
Jacek Laskowski
Notatnik Projektanta Java EE - http://www.JacekLaskowski.pl
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Quintin Beukes-2
In reply to this post by jgallimore
Just as a note, the problem I mentioned wasn't one of OpenEJB, so it's
not a -1 vote. It was definitely network related - probably the
transparent proxies of my ISP.

If it counts, here's my vote: +1

Quintin Beukes



On Sun, Oct 11, 2009 at 11:55 PM, Jonathan Gallimore
<[hidden email]> wrote:

> I've run the tests against JDK 1.6.0_16 on Ubuntu 9.04 (x64) and JDK
> 1.6.0_13 on Windows XP. Everything completed successfully for me (I didn't
> see the problem Quintin did, but I did have it last time around, where I ran
> the script a few times on a couple of machines simultaneously... I guessed
> it was some network issue or something at the time).
>
> I've run RAT over the source, and checked the LICENSE/NOTICE files and
> haven't spotted any problems, so it looks good to me.
>
> +1
>
> Jon
>
> On Sat, Oct 10, 2009 at 11:19 PM, Quintin Beukes <[hidden email]>wrote:
>
>> test:all ran fine here in both JDK1.5.0_17 and JDK1.6.0_11 on Ubuntu
>> 8.04 - Linux quintin-desktop 2.6.24-24-386 #1 Tue Jun 30 19:54:55 UTC
>> 2009 i686 GNU/Linux
>>
>> I also compiled and ran our unit tests against it for all our projects
>> that use 3.1.2, and they ran fine as well. About 150 tests which test
>> remote+local EJBs, multiple persistence units, stateless + singleton
>> beans, security, and a bunch of other stuff. Not all OpenEJBs
>> features, but a fare set of them.
>>
>> So over here it seems good.
>>
>> I did notice a peculiar behavior from the tomcat download server
>> though. It doesn't feed me more than 4.8mb for any download. As soon
>> as it reaches between 4800k and 4900k (not fixed, random) it fails and
>> the download had to stop/resume. So I had to make a script that uses
>> wget to predownload them, else the ant builds kept failing. Nothing
>> bad, just thought I'd share this as it was a pretty fascinating
>> "oddity".
>>
>> Quintin Beukes
>>
>>
>>
>> On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]>
>> wrote:
>> > Ok, we have binaries!
>> >
>> > Repo:
>> >
>> >  https://repository.apache.org/content/repositories/openejb-014
>> >
>> > Binaries:
>> >
>> >  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
>> >
>> > Branch (to become a tag):
>> >
>> >  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>> >
>> >
>> > And so you can test out the binaries, here's an updated ant script as
>> usual:
>> >
>> >  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
>> >
>> >  "ant test:all"
>> >
>> > Things look good on osx so far, haven't tried windoze yet.
>> >
>> >
>> > -David
>> >
>> >
>> >
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Jean-Louis MONTEIRO
As far as I know, all votes are welcome.

Jean-Louis


Quintin Beukes-2 wrote
Just as a note, the problem I mentioned wasn't one of OpenEJB, so it's
not a -1 vote. It was definitely network related - probably the
transparent proxies of my ISP.

If it counts, here's my vote: +1

Quintin Beukes



On Sun, Oct 11, 2009 at 11:55 PM, Jonathan Gallimore
<jonathan.gallimore@gmail.com> wrote:
> I've run the tests against JDK 1.6.0_16 on Ubuntu 9.04 (x64) and JDK
> 1.6.0_13 on Windows XP. Everything completed successfully for me (I didn't
> see the problem Quintin did, but I did have it last time around, where I ran
> the script a few times on a couple of machines simultaneously... I guessed
> it was some network issue or something at the time).
>
> I've run RAT over the source, and checked the LICENSE/NOTICE files and
> haven't spotted any problems, so it looks good to me.
>
> +1
>
> Jon
>
> On Sat, Oct 10, 2009 at 11:19 PM, Quintin Beukes <quintin@skywalk.co.za>wrote:
>
>> test:all ran fine here in both JDK1.5.0_17 and JDK1.6.0_11 on Ubuntu
>> 8.04 - Linux quintin-desktop 2.6.24-24-386 #1 Tue Jun 30 19:54:55 UTC
>> 2009 i686 GNU/Linux
>>
>> I also compiled and ran our unit tests against it for all our projects
>> that use 3.1.2, and they ran fine as well. About 150 tests which test
>> remote+local EJBs, multiple persistence units, stateless + singleton
>> beans, security, and a bunch of other stuff. Not all OpenEJBs
>> features, but a fare set of them.
>>
>> So over here it seems good.
>>
>> I did notice a peculiar behavior from the tomcat download server
>> though. It doesn't feed me more than 4.8mb for any download. As soon
>> as it reaches between 4800k and 4900k (not fixed, random) it fails and
>> the download had to stop/resume. So I had to make a script that uses
>> wget to predownload them, else the ant builds kept failing. Nothing
>> bad, just thought I'd share this as it was a pretty fascinating
>> "oddity".
>>
>> Quintin Beukes
>>
>>
>>
>> On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <david.blevins@visi.com>
>> wrote:
>> > Ok, we have binaries!
>> >
>> > Repo:
>> >
>> >  https://repository.apache.org/content/repositories/openejb-014
>> >
>> > Binaries:
>> >
>> >  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
>> >
>> > Branch (to become a tag):
>> >
>> >  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>> >
>> >
>> > And so you can test out the binaries, here's an updated ant script as
>> usual:
>> >
>> >  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
>> >
>> >  "ant test:all"
>> >
>> > Things look good on osx so far, haven't tried windoze yet.
>> >
>> >
>> > -David
>> >
>> >
>> >
>> >
>>
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dsh-3
In reply to this post by dblevins
+1

Cheers
Daniel

On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]> wrote:

> Ok, we have binaries!
>
> Repo:
>
>  https://repository.apache.org/content/repositories/openejb-014
>
> Binaries:
>
>  http://people.apache.org/~dblevins/stage/3.1.2/
>
> Branch (to become a tag):
>
>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>
>
> And so you can test out the binaries, here's an updated ant script as usual:
>
>  http://people.apache.org/~dblevins/stage/build.xml
>
>  "ant test:all"
>
> Things look good on osx so far, haven't tried windoze yet.
>
>
> -David
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

kmalhi
+1

On Mon, Oct 12, 2009 at 2:41 PM, Daniel S. Haischt <
[hidden email]> wrote:

> +1
>
> Cheers
> Daniel
>
> On Sat, Oct 10, 2009 at 1:34 PM, David Blevins <[hidden email]>
> wrote:
> > Ok, we have binaries!
> >
> > Repo:
> >
> >  https://repository.apache.org/content/repositories/openejb-014
> >
> > Binaries:
> >
> >  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
> >
> > Branch (to become a tag):
> >
> >  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
> >
> >
> > And so you can test out the binaries, here's an updated ant script as
> usual:
> >
> >  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
> >
> >  "ant test:all"
> >
> > Things look good on osx so far, haven't tried windoze yet.
> >
> >
> > -David
> >
> >
> >
> >
>



--
Karan Singh Malhi
Karan Singh Malhi
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Jean-Louis MONTEIRO
In reply to this post by dblevins
Sorry if i'm late.

Everything looks good under ubuntu jaunty and Sun JDK 1.6.0_16-b01
and under Windows XP Pro 1.6.0_15.

So here is my +1.

great job!

Jean-Louis

David Blevins wrote
Ok, we have binaries!

Repo:

   https://repository.apache.org/content/repositories/openejb-014

Binaries:

   http://people.apache.org/~dblevins/stage/3.1.2/

Branch (to become a tag):

   http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/


And so you can test out the binaries, here's an updated ant script as  
usual:

   http://people.apache.org/~dblevins/stage/build.xml

   "ant test:all"

Things look good on osx so far, haven't tried windoze yet.


-David


 
 
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

kevan
In reply to this post by dblevins

On Oct 10, 2009, at 7:34 AM, David Blevins wrote:

> Ok, we have binaries!
>
> Repo:
>
>  https://repository.apache.org/content/repositories/openejb-014
>
> Binaries:
>
>  http://people.apache.org/~dblevins/stage/3.1.2/
>
> Branch (to become a tag):
>
>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>
>
> And so you can test out the binaries, here's an updated ant script  
> as usual:
>
>  http://people.apache.org/~dblevins/stage/build.xml
>
>  "ant test:all"
>
> Things look good on osx so far, haven't tried windoze yet.

The NOTICE file copyright date is 2008. It should be 2009.

I see a number of source files that are missing apache source license  
headers. Did anyone run RAT? Some number of these files look like  
they've been machine generated (e.g. container/openejb-jee/src/main/
java/org/apache/openejb/jee/was/v6/ecore/). So, they wouldn't require  
a license header. A fair number are in the examples. I've appended the  
list below.

May be debatable, but IMO at least some of these should be fixed.  
Here's my non-binding -1.

--kevan

  !????? ./assembly/openejb-standalone/src/main/resources/DATA-
README.txt
  !????? ./assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/
resources/META-INF/org.apache.openejb.tomcat/ServerClassLoader
  !????? ./container/openejb-core/src/main/resources/
default.openejb.conf
  !????? ./container/openejb-core/src/main/resources/groups.properties
  !????? ./container/openejb-core/src/main/resources/logging.properties
  !????? ./container/openejb-core/src/main/resources/login.config
  !????? ./container/openejb-core/src/main/resources/users.properties
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/validate.examples
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.cli/validate.help
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.resource.jdbc.DataSourcePlugin/derby
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.resource.jdbc.DataSourcePlugin/hsqldb
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.resource.jdbc.DataSourcePlugin/idb
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.resource.jdbc.PasswordCipher/PlainText
  !????? ./container/openejb-core/src/main/resources/META-INF/
org.apache.openejb.resource.jdbc.PasswordCipher/Static3DES
  !????? ./container/openejb-core/src/main/resources/META-INF/services/
org/apache/activemq/broker/openejb
  !????? ./container/openejb-core/src/main/resources/schema/ejb-
jar_1_1.xsd
  !????? ./container/openejb-core/src/test/resources/altddPU1/META-INF/
bartest.ejb-jar.xml
  !????? ./container/openejb-core/src/test/resources/altddapp1/META-
INF/test.ejb-jar.xml
  !????? ./container/openejb-core/src/test/resources/altddapp2/META-
INF/ejb-jar.xml
  !????? ./container/openejb-core/src/test/resources/altddapp2/META-
INF/footest.ejb-jar.xml
  !????? ./container/openejb-core/src/test/resources/altddapp2/META-
INF/test.ejb-jar.xml
  !????? ./container/openejb-core/src/test/resources/altddapp2/META-
INF/test.env-entries.properties
  !????? ./container/openejb-core/src/test/resources/mixedcase/mEta-
iNf/ejb-jar.xml
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EAnnotation.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EAttribute.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EClass.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EClassifier.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EDataType.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EEnum.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EEnumLiteral.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EFactory.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EModelElement.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/ENamedElement.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EObject.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EOperation.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EPackage.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EParameter.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EReference.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EStringToStringMapEntry.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/EStructuralFeature.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/ETypedElement.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/ObjectFactory.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/ecore/package-info.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/ArrayType.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Block.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Comment.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Field.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Initializer.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaClass.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaDataType.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaEvent.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaPackage.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaParameter.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaParameterKind.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/JavaVisibilityKind.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Method.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/ObjectFactory.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/Statement.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/TypeKind.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/java/package-info.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Add.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Any.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Delete.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Difference.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Documentation.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Extension.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Import.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/MetaModel.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Model.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/ObjectFactory.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/PackageReference.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/Replace.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/XMI.java
  !????? ./container/openejb-jee/src/main/java/org/apache/openejb/jee/
was/v6/xmi/package-info.java
  !????? ./container/openejb-jee/src/main/resources/META-INF/schema/
xml.xsd
  !????? ./container/openejb-spring/src/test/resources/META-INF/ejb-
jar.xml
  !????? ./examples/alternate-descriptors/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/alternate-descriptors/src/main/resources/META-INF/
test.ejb-jar.xml
  !????? ./examples/alternate-descriptors/src/test/resources/META-INF/
application-client.xml
  !????? ./examples/applicationexception/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/component-interfaces/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/custom-injection/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/ear-testing/business-logic/src/main/resources/META-
INF/ejb-jar.xml
  !????? ./examples/helloworld-weblogic/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/injection-of-connectionfactory/src/main/resources/
META-INF/ejb-jar.xml
  !????? ./examples/injection-of-datasource/src/main/resources/META-
INF/ejb-jar.xml
  !????? ./examples/injection-of-ejbs/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/injection-of-entitymanager/src/main/resources/META-
INF/ejb-jar.xml
  !????? ./examples/jpa-eclipselink/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/jpa-hibernate/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/simple-cmp2/src/main/resources/META-INF/ejb-jar.xml
  !????? ./examples/simple-cmp2/src/main/resources/META-INF/openejb-
jar.xml
  !????? ./examples/simple-mdb/src/main/resources/META-INF/ejb-jar.xml
  !????? ./examples/simple-mdb-with-descriptor/src/main/resources/META-
INF/ejb-jar.xml
  !????? ./examples/simple-singleton/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/simple-stateful/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/simple-stateless/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/simple-stateless-with-descriptor/src/main/
resources/META-INF/ejb-jar.xml
  !????? ./examples/simple-webservice/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/spring-integration/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/telephone-stateful/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testcase-injection/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testcase-injection/src/test/resources/META-INF/
application-client.xml
  !????? ./examples/testing-security/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testing-security/src/test/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testing-security-2/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testing-security-2/src/test/resources/
groups.properties
  !????? ./examples/testing-security-2/src/test/resources/
users.properties
  !????? ./examples/testing-security-2/src/test/resources/META-INF/ejb-
jar.xml
  !????? ./examples/testing-transactions/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/testing-transactions/src/test/resources/META-INF/
ejb-jar.xml
  !????? ./examples/webapps/ejb-webservice/client.pl
  !????? ./examples/webapps/moviefun/delete-movie.pl
  !????? ./examples/webapps/moviefun/get-movies.pl
  !????? ./examples/webapps/moviefun/src/main/resources/META-INF/ejb-
jar.xml
  !????? ./examples/webapps/moviefun/src/main/webapp/default.css
  !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
  !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
  !????? ./examples/webapps/moviefun/src/test/resources/META-INF/
application-client.xml
  !????? ./examples/webapps/struts/src/main/webapp/prelude.jspf
  !????? ./examples/webservice-attachments/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/webservice-security/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/webservice-security/src/main/resources/META-INF/
openejb-jar.xml
  !????? ./examples/webservice-security/src/test/resources/
groups.properties
  !????? ./examples/webservice-security/src/test/resources/
users.properties
  !????? ./examples/webservice-ws-security/src/main/resources/META-INF/
CalculatorImplSign-server.properties
  !????? ./examples/webservice-ws-security/src/main/resources/META-INF/
CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
  !????? ./examples/webservice-ws-security/src/main/resources/META-INF/
ejb-jar.xml
  !????? ./examples/webservice-ws-security/src/test/resources/
groups.properties
  !????? ./examples/webservice-ws-security/src/test/resources/
users.properties
  !????? ./examples/webservice-ws-security/src/test/resources/META-INF/
CalculatorImplSign-client.properties
  !????? ./examples/webservice-ws-security/src/test/resources/META-INF/
CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties
  !????? ./itests/openejb-itests-client/src/main/resources/META-INF/
org.apache.openejb.cli/test.help
  !????? ./server/openejb-activemq/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/activemq
  !????? ./server/openejb-axis/src/main/resources/META-INF/schema/
soap_encoding_1_1.xsd
  !????? ./server/openejb-client/src/main/resources/META-INF/
org.apache.openejb.client.IdentityResolver/jaas
  !????? ./server/openejb-client/src/main/resources/META-INF/
org.apache.openejb.client.IdentityResolver/simple
  !????? ./server/openejb-cxf/src/main/resources/META-INF/cxf.extension
  !????? ./server/openejb-cxf/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/cxf
  !????? ./server/openejb-derbynet/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/derbynet
  !????? ./server/openejb-ejbd/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/ejbd
  !????? ./server/openejb-hsql/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/hsql
  !????? ./server/openejb-http/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/httpejbd
  !????? ./server/openejb-multicast/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/multicast
  !????? ./server/openejb-server/src/main/resources/META-INF/
org.apache.openejb.cli/start.examples
  !????? ./server/openejb-server/src/main/resources/META-INF/
org.apache.openejb.cli/start.help
  !????? ./server/openejb-server/src/main/resources/META-INF/
org.apache.openejb.cli/stop.examples
  !????? ./server/openejb-server/src/main/resources/META-INF/
org.apache.openejb.cli/stop.help
  !????? ./server/openejb-server/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/admin
  !????? ./server/openejb-telnet/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/telnet
  !????? ./server/openejb-webadmin/src/main/resources/META-INF/
org.apache.openejb.server.ServerService/webadmin



Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

jgallimore
I did run RAT (and I'll have another look at the output later) - and saw the
generated files in the list, which I don't think require headers.

The other files I didn't think required headers as I thought they were
trivial (a lot of the ejb-jar.xml files just have <ejb-jar/> in them, for
example).

Apologies if I've missed something, or got it wrong, I still got a lot to
learn about the legal side of things.

Jon

On Tue, Oct 13, 2009 at 5:51 PM, Kevan Miller <[hidden email]>wrote:

>
> On Oct 10, 2009, at 7:34 AM, David Blevins wrote:
>
>  Ok, we have binaries!
>>
>> Repo:
>>
>>  https://repository.apache.org/content/repositories/openejb-014
>>
>> Binaries:
>>
>>  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
>>
>> Branch (to become a tag):
>>
>>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>>
>>
>> And so you can test out the binaries, here's an updated ant script as
>> usual:
>>
>>  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
>>
>>  "ant test:all"
>>
>> Things look good on osx so far, haven't tried windoze yet.
>>
>
> The NOTICE file copyright date is 2008. It should be 2009.
>
> I see a number of source files that are missing apache source license
> headers. Did anyone run RAT? Some number of these files look like they've
> been machine generated (e.g.
> container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/).
> So, they wouldn't require a license header. A fair number are in the
> examples. I've appended the list below.
>
> May be debatable, but IMO at least some of these should be fixed. Here's my
> non-binding -1.
>
> --kevan
>
>  !????? ./assembly/openejb-standalone/src/main/resources/DATA-README.txt
>  !?????
> ./assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/resources/META-INF/org.apache.openejb.tomcat/ServerClassLoader
>  !????? ./container/openejb-core/src/main/resources/default.openejb.conf
>  !????? ./container/openejb-core/src/main/resources/groups.properties
>  !????? ./container/openejb-core/src/main/resources/logging.properties
>  !????? ./container/openejb-core/src/main/resources/login.config
>  !????? ./container/openejb-core/src/main/resources/users.properties
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.examples
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.help
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/derby
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/hsqldb
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/idb
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/PlainText
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/Static3DES
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/services/org/apache/activemq/broker/openejb
>  !????? ./container/openejb-core/src/main/resources/schema/ejb-jar_1_1.xsd
>  !?????
> ./container/openejb-core/src/test/resources/altddPU1/META-INF/bartest.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp1/META-INF/test.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/footest.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.env-entries.properties
>  !?????
> ./container/openejb-core/src/test/resources/mixedcase/mEta-iNf/ejb-jar.xml
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAnnotation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAttribute.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClass.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClassifier.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EDataType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnum.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnumLiteral.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EModelElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ENamedElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EObject.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EOperation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EPackage.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EParameter.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EReference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStringToStringMapEntry.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStructuralFeature.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ETypedElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/package-info.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ArrayType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Block.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Comment.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Field.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Initializer.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaClass.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaDataType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaEvent.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaPackage.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameter.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameterKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaVisibilityKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Method.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Statement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/TypeKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/package-info.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Add.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Any.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Delete.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Difference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Documentation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Extension.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Import.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/MetaModel.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Model.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/PackageReference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Replace.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/XMI.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/package-info.java
>  !????? ./container/openejb-jee/src/main/resources/META-INF/schema/xml.xsd
>  !????? ./container/openejb-spring/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/main/resources/META-INF/test.ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/test/resources/META-INF/application-client.xml
>  !?????
> ./examples/applicationexception/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/component-interfaces/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/custom-injection/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/ear-testing/business-logic/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/helloworld-weblogic/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-connectionfactory/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-datasource/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-ejbs/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-entitymanager/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/jpa-eclipselink/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/jpa-hibernate/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-cmp2/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-cmp2/src/main/resources/META-INF/openejb-jar.xml
>  !????? ./examples/simple-mdb/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-mdb-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-singleton/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-stateful/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-stateless/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-stateless-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-webservice/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/spring-integration/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/telephone-stateful/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testcase-injection/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testcase-injection/src/test/resources/META-INF/application-client.xml
>  !????? ./examples/testing-security/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/testing-security/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-security-2/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/testing-security-2/src/test/resources/groups.properties
>  !????? ./examples/testing-security-2/src/test/resources/users.properties
>  !?????
> ./examples/testing-security-2/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-transactions/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-transactions/src/test/resources/META-INF/ejb-jar.xml
>  !????? ./examples/webapps/ejb-webservice/client.pl
>  !????? ./examples/webapps/moviefun/delete-movie.pl
>  !????? ./examples/webapps/moviefun/get-movies.pl
>  !????? ./examples/webapps/moviefun/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/webapps/moviefun/src/main/webapp/default.css
>  !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
>  !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
>  !?????
> ./examples/webapps/moviefun/src/test/resources/META-INF/application-client.xml
>  !????? ./examples/webapps/struts/src/main/webapp/prelude.jspf
>  !?????
> ./examples/webservice-attachments/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-security/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-security/src/main/resources/META-INF/openejb-jar.xml
>  !????? ./examples/webservice-security/src/test/resources/groups.properties
>  !????? ./examples/webservice-security/src/test/resources/users.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplSign-server.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-ws-security/src/test/resources/groups.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/users.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplSign-client.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties
>  !?????
> ./itests/openejb-itests-client/src/main/resources/META-INF/org.apache.openejb.cli/test.help
>  !?????
> ./server/openejb-activemq/src/main/resources/META-INF/org.apache.openejb.server.ServerService/activemq
>  !?????
> ./server/openejb-axis/src/main/resources/META-INF/schema/soap_encoding_1_1.xsd
>  !?????
> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/jaas
>  !?????
> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/simple
>  !????? ./server/openejb-cxf/src/main/resources/META-INF/cxf.extension
>  !?????
> ./server/openejb-cxf/src/main/resources/META-INF/org.apache.openejb.server.ServerService/cxf
>  !?????
> ./server/openejb-derbynet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/derbynet
>  !?????
> ./server/openejb-ejbd/src/main/resources/META-INF/org.apache.openejb.server.ServerService/ejbd
>  !?????
> ./server/openejb-hsql/src/main/resources/META-INF/org.apache.openejb.server.ServerService/hsql
>  !?????
> ./server/openejb-http/src/main/resources/META-INF/org.apache.openejb.server.ServerService/httpejbd
>  !?????
> ./server/openejb-multicast/src/main/resources/META-INF/org.apache.openejb.server.ServerService/multicast
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.examples
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.help
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.examples
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.help
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.server.ServerService/admin
>  !?????
> ./server/openejb-telnet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/telnet
>  !?????
> ./server/openejb-webadmin/src/main/resources/META-INF/org.apache.openejb.server.ServerService/webadmin
>
>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dblevins
Administrator
In reply to this post by kevan

On Oct 13, 2009, at 9:51 AM, Kevan Miller wrote:

> The NOTICE file copyright date is 2008. It should be 2009.

Thought I got those.  Feel free to update it or post the file path and  
I'll update it.

> !????? ./examples/webapps/moviefun/src/main/webapp/default.css
> !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
> !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp

These three should probably have license headers.  We can also add  
them to the jaxb generated classes though it isn't necessary.  The  
rest have been flagged and excluded several times.

I can push up a new openejb-3.1.2-src and openejb-examples zip, but we  
can leave the actual runnable binaries alone and avoid the reroll/
revote.

-David


Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Jean-Louis MONTEIRO
In reply to this post by jgallimore
I didn't run RAT tool.
Mohammad is in charge of this development so i can probably give us more inputs.
AFAIK, some files are generated but Mohammad changed them after.

This is definitely something i have to tale into account.

Jean-Louis



Jonathan Gallimore-2 wrote
I did run RAT (and I'll have another look at the output later) - and saw the
generated files in the list, which I don't think require headers.

The other files I didn't think required headers as I thought they were
trivial (a lot of the ejb-jar.xml files just have <ejb-jar/> in them, for
example).

Apologies if I've missed something, or got it wrong, I still got a lot to
learn about the legal side of things.

Jon

On Tue, Oct 13, 2009 at 5:51 PM, Kevan Miller <kevan.miller@gmail.com>wrote:

>
> On Oct 10, 2009, at 7:34 AM, David Blevins wrote:
>
>  Ok, we have binaries!
>>
>> Repo:
>>
>>  https://repository.apache.org/content/repositories/openejb-014
>>
>> Binaries:
>>
>>  http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
>>
>> Branch (to become a tag):
>>
>>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>>
>>
>> And so you can test out the binaries, here's an updated ant script as
>> usual:
>>
>>  http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
>>
>>  "ant test:all"
>>
>> Things look good on osx so far, haven't tried windoze yet.
>>
>
> The NOTICE file copyright date is 2008. It should be 2009.
>
> I see a number of source files that are missing apache source license
> headers. Did anyone run RAT? Some number of these files look like they've
> been machine generated (e.g.
> container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/).
> So, they wouldn't require a license header. A fair number are in the
> examples. I've appended the list below.
>
> May be debatable, but IMO at least some of these should be fixed. Here's my
> non-binding -1.
>
> --kevan
>
>  !????? ./assembly/openejb-standalone/src/main/resources/DATA-README.txt
>  !?????
> ./assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/resources/META-INF/org.apache.openejb.tomcat/ServerClassLoader
>  !????? ./container/openejb-core/src/main/resources/default.openejb.conf
>  !????? ./container/openejb-core/src/main/resources/groups.properties
>  !????? ./container/openejb-core/src/main/resources/logging.properties
>  !????? ./container/openejb-core/src/main/resources/login.config
>  !????? ./container/openejb-core/src/main/resources/users.properties
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.examples
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.help
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/derby
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/hsqldb
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/idb
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/PlainText
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/Static3DES
>  !?????
> ./container/openejb-core/src/main/resources/META-INF/services/org/apache/activemq/broker/openejb
>  !????? ./container/openejb-core/src/main/resources/schema/ejb-jar_1_1.xsd
>  !?????
> ./container/openejb-core/src/test/resources/altddPU1/META-INF/bartest.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp1/META-INF/test.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/footest.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.ejb-jar.xml
>  !?????
> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.env-entries.properties
>  !?????
> ./container/openejb-core/src/test/resources/mixedcase/mEta-iNf/ejb-jar.xml
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAnnotation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAttribute.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClass.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClassifier.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EDataType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnum.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnumLiteral.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EModelElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ENamedElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EObject.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EOperation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EPackage.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EParameter.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EReference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStringToStringMapEntry.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStructuralFeature.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ETypedElement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/package-info.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ArrayType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Block.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Comment.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Field.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Initializer.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaClass.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaDataType.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaEvent.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaPackage.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameter.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameterKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaVisibilityKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Method.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Statement.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/TypeKind.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/package-info.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Add.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Any.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Delete.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Difference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Documentation.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Extension.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Import.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/MetaModel.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Model.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/ObjectFactory.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/PackageReference.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Replace.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/XMI.java
>  !?????
> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/package-info.java
>  !????? ./container/openejb-jee/src/main/resources/META-INF/schema/xml.xsd
>  !????? ./container/openejb-spring/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/main/resources/META-INF/test.ejb-jar.xml
>  !?????
> ./examples/alternate-descriptors/src/test/resources/META-INF/application-client.xml
>  !?????
> ./examples/applicationexception/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/component-interfaces/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/custom-injection/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/ear-testing/business-logic/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/helloworld-weblogic/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-connectionfactory/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-datasource/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-ejbs/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/injection-of-entitymanager/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/jpa-eclipselink/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/jpa-hibernate/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-cmp2/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-cmp2/src/main/resources/META-INF/openejb-jar.xml
>  !????? ./examples/simple-mdb/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-mdb-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-singleton/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-stateful/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/simple-stateless/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-stateless-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/simple-webservice/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/spring-integration/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/telephone-stateful/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testcase-injection/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testcase-injection/src/test/resources/META-INF/application-client.xml
>  !????? ./examples/testing-security/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/testing-security/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-security-2/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/testing-security-2/src/test/resources/groups.properties
>  !????? ./examples/testing-security-2/src/test/resources/users.properties
>  !?????
> ./examples/testing-security-2/src/test/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-transactions/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/testing-transactions/src/test/resources/META-INF/ejb-jar.xml
>  !????? ./examples/webapps/ejb-webservice/client.pl
>  !????? ./examples/webapps/moviefun/delete-movie.pl
>  !????? ./examples/webapps/moviefun/get-movies.pl
>  !????? ./examples/webapps/moviefun/src/main/resources/META-INF/ejb-jar.xml
>  !????? ./examples/webapps/moviefun/src/main/webapp/default.css
>  !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
>  !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
>  !?????
> ./examples/webapps/moviefun/src/test/resources/META-INF/application-client.xml
>  !????? ./examples/webapps/struts/src/main/webapp/prelude.jspf
>  !?????
> ./examples/webservice-attachments/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-security/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-security/src/main/resources/META-INF/openejb-jar.xml
>  !????? ./examples/webservice-security/src/test/resources/groups.properties
>  !????? ./examples/webservice-security/src/test/resources/users.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplSign-server.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
>  !?????
> ./examples/webservice-ws-security/src/main/resources/META-INF/ejb-jar.xml
>  !?????
> ./examples/webservice-ws-security/src/test/resources/groups.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/users.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplSign-client.properties
>  !?????
> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties
>  !?????
> ./itests/openejb-itests-client/src/main/resources/META-INF/org.apache.openejb.cli/test.help
>  !?????
> ./server/openejb-activemq/src/main/resources/META-INF/org.apache.openejb.server.ServerService/activemq
>  !?????
> ./server/openejb-axis/src/main/resources/META-INF/schema/soap_encoding_1_1.xsd
>  !?????
> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/jaas
>  !?????
> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/simple
>  !????? ./server/openejb-cxf/src/main/resources/META-INF/cxf.extension
>  !?????
> ./server/openejb-cxf/src/main/resources/META-INF/org.apache.openejb.server.ServerService/cxf
>  !?????
> ./server/openejb-derbynet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/derbynet
>  !?????
> ./server/openejb-ejbd/src/main/resources/META-INF/org.apache.openejb.server.ServerService/ejbd
>  !?????
> ./server/openejb-hsql/src/main/resources/META-INF/org.apache.openejb.server.ServerService/hsql
>  !?????
> ./server/openejb-http/src/main/resources/META-INF/org.apache.openejb.server.ServerService/httpejbd
>  !?????
> ./server/openejb-multicast/src/main/resources/META-INF/org.apache.openejb.server.ServerService/multicast
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.examples
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.help
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.examples
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.help
>  !?????
> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.server.ServerService/admin
>  !?????
> ./server/openejb-telnet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/telnet
>  !?????
> ./server/openejb-webadmin/src/main/resources/META-INF/org.apache.openejb.server.ServerService/webadmin
>
>
>
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

kevan
In reply to this post by jgallimore

On Oct 13, 2009, at 1:25 PM, Jonathan Gallimore wrote:

> I did run RAT (and I'll have another look at the output later) - and  
> saw the
> generated files in the list, which I don't think require headers.
>
> The other files I didn't think required headers as I thought they were
> trivial (a lot of the ejb-jar.xml files just have <ejb-jar/> in  
> them, for
> example).
>
> Apologies if I've missed something, or got it wrong, I still got a  
> lot to
> learn about the legal side of things.


Hi Jonathan,
Understood and no problem at all... This is a debatable issue. You are  
correct that generated files don't require headers. Nor do trivial  
files. Nor do files which syntactically cannot contain a license  
header. Becomes a question of what falls under those exceptions. One  
benefit of adding license headers, is that in the future there's less  
to check...

IMO, I think these should have headers:

  ==./container/openejb-core/src/main/resources/default.openejb.conf
  ==./container/openejb-core/src/main/resources/logging.properties
  ==./container/openejb-core/src/main/resources/login.config
  ==./examples/simple-cmp2/src/main/resources/META-INF/ejb-jar.xml
  ==./examples/simple-mdb-with-descriptor/src/main/resources/META-INF/
ejb-jar.xml
  ==./examples/simple-stateless-with-descriptor/src/main/resources/
META-INF/ejb-jar.xml
  ==./examples/webapps/ejb-webservice/client.pl
  ==./examples/webapps/moviefun/delete-movie.pl
  ==./examples/webapps/moviefun/get-movies.pl
  ==./examples/webapps/moviefun/src/main/webapp/default.css
  ==./examples/webapps/moviefun/src/main/webapp/index.jsp
  ==./examples/webapps/moviefun/src/main/webapp/setup.jsp
  ==./examples/webservice-security/src/main/resources/META-INF/openejb-
jar.xml
  ==./examples/webservice-ws-security/src/main/resources/META-INF/
CalculatorImplSign-server.properties
  ==./examples/webservice-ws-security/src/main/resources/META-INF/
CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
  ==./examples/webservice-ws-security/src/main/resources/META-INF/ejb-
jar.xml
  ==./examples/webservice-ws-security/src/test/resources/META-INF/
CalculatorImplSign-client.properties
  ==./examples/webservice-ws-security/src/test/resources/META-INF/
CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties

--kevan
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

kevan
In reply to this post by dblevins

On Oct 13, 2009, at 2:46 PM, David Blevins wrote:

>
> On Oct 13, 2009, at 9:51 AM, Kevan Miller wrote:
>
>> The NOTICE file copyright date is 2008. It should be 2009.
>
> Thought I got those.  Feel free to update it or post the file path  
> and I'll update it.

http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/NOTICE 
and examples/NOTICE.txt (I didn't check to see if this is actually  
used in generated examples).

>
>> !????? ./examples/webapps/moviefun/src/main/webapp/default.css
>> !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
>> !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
>
> These three should probably have license headers.  We can also add  
> them to the jaxb generated classes though it isn't necessary.  The  
> rest have been flagged and excluded several times.

K. I'd agree with those 3. See the others that I posted in response to  
Jonathan. Agreed that jaxb classes don't need them. Not sure how the  
files others are being excluded... I tried to look back for past  
votes, but prolly looked in the wrong place.

--kevan
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

Mohammad Nour El-Din
Hi I hope I am not too late but I will not be able to do anything
until tomorrow night 14-October-2009 and I will put your comments into
consideration.

On Tue, Oct 13, 2009 at 9:57 PM, Kevan Miller <[hidden email]> wrote:

>
> On Oct 13, 2009, at 2:46 PM, David Blevins wrote:
>
>>
>> On Oct 13, 2009, at 9:51 AM, Kevan Miller wrote:
>>
>>> The NOTICE file copyright date is 2008. It should be 2009.
>>
>> Thought I got those.  Feel free to update it or post the file path and
>> I'll update it.
>
> http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/NOTICE and
> examples/NOTICE.txt (I didn't check to see if this is actually used in
> generated examples).
>
>>
>>> !????? ./examples/webapps/moviefun/src/main/webapp/default.css
>>> !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
>>> !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
>>
>> These three should probably have license headers.  We can also add them to
>> the jaxb generated classes though it isn't necessary.  The rest have been
>> flagged and excluded several times.
>
> K. I'd agree with those 3. See the others that I posted in response to
> Jonathan. Agreed that jaxb classes don't need them. Not sure how the files
> others are being excluded... I tried to look back for past votes, but prolly
> looked in the wrong place.
>
> --kevan
>



--
Thanks
- Mohammad Nour
- LinkedIn: http://www.linkedin.com/in/mnour
----
"Life is like riding a bicycle. To keep your balance you must keep moving"
- Albert Einstein

"Writing clean code is what you must do in order to call yourself a
professional.
There is no reasonable excuse for doing anything less than your best."
-   Clean Code: A Handbook of Agile Software Craftsmanship
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dblevins
Administrator
In reply to this post by kevan

On Oct 13, 2009, at 12:25 PM, Kevan Miller wrote:

> IMO, I think these should have headers:
>
> ==./container/openejb-core/src/main/resources/default.openejb.conf
> ==./container/openejb-core/src/main/resources/logging.properties
> ==./container/openejb-core/src/main/resources/login.config

I took a page from httpd on how to treat what essentially become user  
owned config files.  They don't have an ASL header on their default  
httpd.conf or any of the files they put in conf/ that are expected to  
be maintained by the user.

> ==./examples/webapps/ejb-webservice/client.pl
> ==./examples/webapps/moviefun/delete-movie.pl
> ==./examples/webapps/moviefun/get-movies.pl
> ==./examples/webservice-ws-security/src/main/resources/META-INF/
> CalculatorImplSign-server.properties
> ==./examples/webservice-ws-security/src/main/resources/META-INF/
> CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
> ==./examples/webservice-ws-security/src/test/resources/META-INF/
> CalculatorImplSign-client.properties
> ==./examples/webservice-ws-security/src/test/resources/META-INF/
> CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties

These are boilerplate.  It's not possible to use the libraries in  
question without code nearly identical to what is there, which is why  
they all look almost exactly the same.  There's no creative work there  
for anyone to own or protect.

Added headers to the rest and updated the dates on those two notice  
files.


-David

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dblevins
Administrator
In reply to this post by kevan

On Oct 13, 2009, at 12:57 PM, Kevan Miller wrote:

> Agreed that jaxb classes don't need them.

I'll add headers anyway as we tend to "move in" to the generated  
classes eventually and start adding original work.

> Not sure how the files others are being excluded... I tried to look  
> back for past votes, but prolly looked in the wrong place.

Didn't mean to imply an automated process.  Was just referring to  
release-time conversation.

An automated process would be rather nice.  Not build time, but commit  
time.  An svn trigger would be sweet.

-David

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dblevins
Administrator
New source zip and examples source zip uploaded.  Will close the vote  
and publish tomorrow.

-David

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] OpenEJB 3.1.2

dblevins
Administrator
In reply to this post by dblevins
My +1

-David

On Oct 10, 2009, at 4:34 AM, David Blevins wrote:

> Ok, we have binaries!
>
> Repo:
>
>  https://repository.apache.org/content/repositories/openejb-014
>
> Binaries:
>
>  http://people.apache.org/~dblevins/stage/3.1.2/
>
> Branch (to become a tag):
>
>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>
>
> And so you can test out the binaries, here's an updated ant script  
> as usual:
>
>  http://people.apache.org/~dblevins/stage/build.xml
>
>  "ant test:all"
>
> Things look good on osx so far, haven't tried windoze yet.
>
>
> -David
>
>
>

12