Upgrade BVal to official (not patched) one

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Upgrade BVal to official (not patched) one

Thomas Andraschko
Hi,

there were some "possible issues" with bval in the last months, especially:

https://issues.apache.org/jira/browse/BVAL-174
(also see https://www.mail-archive.com/dev@.../msg01042.html)

and

https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175

both are no issues from our perspective @bval side (please feel free to
join the discussions there).

I would really like to see the bval upgrade for the next milestone or even
the final release.
If you are ok with the upgrade, we would prepare a bval release.

It's a big boost in the startup performance and with those changes, we
almost have the same startup time as with 7.x.

Best regards,
Thomas
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Jean-Louis MONTEIRO
Following up on this thread.
What version would you recommend?

On Maven central we have https://search.maven.org/search?q=g:org.apache.bval
I believe it's 2.0.2 but wanted to double check


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
[hidden email]> wrote:

> Hi,
>
> there were some "possible issues" with bval in the last months, especially:
>
> https://issues.apache.org/jira/browse/BVAL-174
> (also see https://www.mail-archive.com/dev@.../msg01042.html)
>
> and
>
> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>
> both are no issues from our perspective @bval side (please feel free to
> join the discussions there).
>
> I would really like to see the bval upgrade for the next milestone or even
> the final release.
> If you are ok with the upgrade, we would prepare a bval release.
>
> It's a big boost in the startup performance and with those changes, we
> almost have the same startup time as with 7.x.
>
> Best regards,
> Thomas
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Thomas Andraschko
I would like to release 2.0.3, as it contains some fixes and performance
boosts, if you are ok with using the official bval

Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
2019, 18:24:

> Following up on this thread.
> What version would you recommend?
>
> On Maven central we have
> https://search.maven.org/search?q=g:org.apache.bval
> I believe it's 2.0.2 but wanted to double check
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
> [hidden email]> wrote:
>
> > Hi,
> >
> > there were some "possible issues" with bval in the last months,
> especially:
> >
> > https://issues.apache.org/jira/browse/BVAL-174
> > (also see https://www.mail-archive.com/dev@.../msg01042.html
> )
> >
> > and
> >
> > https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
> >
> > both are no issues from our perspective @bval side (please feel free to
> > join the discussions there).
> >
> > I would really like to see the bval upgrade for the next milestone or
> even
> > the final release.
> > If you are ok with the upgrade, we would prepare a bval release.
> >
> > It's a big boost in the startup performance and with those changes, we
> > almost have the same startup time as with 7.x.
> >
> > Best regards,
> > Thomas
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

David Blevins-2
Hi Thomas,

I pushed 2.0.1 as that's the last version that doesn't have the regression BVAL-174.

Once the build passes, would you like the honor to submit a patch to upgrade to 2.0.3?  The primary thing is we need someone to either delete or fix the failing example.  Ideally there would also be an update to its README that talks about the change in behavior.

Is that something you'd be willing to contribute?


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Aug 5, 2019, at 11:16 AM, Thomas Andraschko <[hidden email]> wrote:
>
> I would like to release 2.0.3, as it contains some fixes and performance
> boosts, if you are ok with using the official bval
>
> Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
> 2019, 18:24:
>
>> Following up on this thread.
>> What version would you recommend?
>>
>> On Maven central we have
>> https://search.maven.org/search?q=g:org.apache.bval
>> I believe it's 2.0.2 but wanted to double check
>>
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
>> [hidden email]> wrote:
>>
>>> Hi,
>>>
>>> there were some "possible issues" with bval in the last months,
>> especially:
>>>
>>> https://issues.apache.org/jira/browse/BVAL-174
>>> (also see https://www.mail-archive.com/dev@.../msg01042.html
>> )
>>>
>>> and
>>>
>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>>>
>>> both are no issues from our perspective @bval side (please feel free to
>>> join the discussions there).
>>>
>>> I would really like to see the bval upgrade for the next milestone or
>> even
>>> the final release.
>>> If you are ok with the upgrade, we would prepare a bval release.
>>>
>>> It's a big boost in the startup performance and with those changes, we
>>> almost have the same startup time as with 7.x.
>>>
>>> Best regards,
>>> Thomas
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Mark Struberg-2
In reply to this post by Thomas Andraschko
I can probably help with that a bit. Just ping me if you need something.

LieGrue,
strub


> Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <[hidden email]>:
>
> I would like to release 2.0.3, as it contains some fixes and performance
> boosts, if you are ok with using the official bval
>
> Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
> 2019, 18:24:
>
>> Following up on this thread.
>> What version would you recommend?
>>
>> On Maven central we have
>> https://search.maven.org/search?q=g:org.apache.bval
>> I believe it's 2.0.2 but wanted to double check
>>
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
>> [hidden email]> wrote:
>>
>>> Hi,
>>>
>>> there were some "possible issues" with bval in the last months,
>> especially:
>>>
>>> https://issues.apache.org/jira/browse/BVAL-174
>>> (also see https://www.mail-archive.com/dev@.../msg01042.html
>> )
>>>
>>> and
>>>
>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>>>
>>> both are no issues from our perspective @bval side (please feel free to
>>> join the discussions there).
>>>
>>> I would really like to see the bval upgrade for the next milestone or
>> even
>>> the final release.
>>> If you are ok with the upgrade, we would prepare a bval release.
>>>
>>> It's a big boost in the startup performance and with those changes, we
>>> almost have the same startup time as with 7.x.
>>>
>>> Best regards,
>>> Thomas
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Thomas Andraschko
Im in Holiday this week, so If you can work on it Mark, it would be great :)

Mark Struberg <[hidden email]> schrieb am Di., 6. Aug. 2019,
08:41:

> I can probably help with that a bit. Just ping me if you need something.
>
> LieGrue,
> strub
>
>
> > Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <
> [hidden email]>:
> >
> > I would like to release 2.0.3, as it contains some fixes and performance
> > boosts, if you are ok with using the official bval
> >
> > Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
> > 2019, 18:24:
> >
> >> Following up on this thread.
> >> What version would you recommend?
> >>
> >> On Maven central we have
> >> https://search.maven.org/search?q=g:org.apache.bval
> >> I believe it's 2.0.2 but wanted to double check
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
> >> [hidden email]> wrote:
> >>
> >>> Hi,
> >>>
> >>> there were some "possible issues" with bval in the last months,
> >> especially:
> >>>
> >>> https://issues.apache.org/jira/browse/BVAL-174
> >>> (also see
> https://www.mail-archive.com/dev@.../msg01042.html
> >> )
> >>>
> >>> and
> >>>
> >>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
> >>>
> >>> both are no issues from our perspective @bval side (please feel free to
> >>> join the discussions there).
> >>>
> >>> I would really like to see the bval upgrade for the next milestone or
> >> even
> >>> the final release.
> >>> If you are ok with the upgrade, we would prepare a bval release.
> >>>
> >>> It's a big boost in the startup performance and with those changes, we
> >>> almost have the same startup time as with 7.x.
> >>>
> >>> Best regards,
> >>> Thomas
> >>>
> >>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Thomas Andraschko
Started the release vote today, will come back when it's released :)

Am Di., 6. Aug. 2019 um 10:27 Uhr schrieb Thomas Andraschko <
[hidden email]>:

> Im in Holiday this week, so If you can work on it Mark, it would be great
> :)
>
> Mark Struberg <[hidden email]> schrieb am Di., 6. Aug. 2019,
> 08:41:
>
>> I can probably help with that a bit. Just ping me if you need something.
>>
>> LieGrue,
>> strub
>>
>>
>> > Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <
>> [hidden email]>:
>> >
>> > I would like to release 2.0.3, as it contains some fixes and performance
>> > boosts, if you are ok with using the official bval
>> >
>> > Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
>> > 2019, 18:24:
>> >
>> >> Following up on this thread.
>> >> What version would you recommend?
>> >>
>> >> On Maven central we have
>> >> https://search.maven.org/search?q=g:org.apache.bval
>> >> I believe it's 2.0.2 but wanted to double check
>> >>
>> >>
>> >> --
>> >> Jean-Louis Monteiro
>> >> http://twitter.com/jlouismonteiro
>> >> http://www.tomitribe.com
>> >>
>> >>
>> >> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
>> >> [hidden email]> wrote:
>> >>
>> >>> Hi,
>> >>>
>> >>> there were some "possible issues" with bval in the last months,
>> >> especially:
>> >>>
>> >>> https://issues.apache.org/jira/browse/BVAL-174
>> >>> (also see
>> https://www.mail-archive.com/dev@.../msg01042.html
>> >> )
>> >>>
>> >>> and
>> >>>
>> >>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>> >>>
>> >>> both are no issues from our perspective @bval side (please feel free
>> to
>> >>> join the discussions there).
>> >>>
>> >>> I would really like to see the bval upgrade for the next milestone or
>> >> even
>> >>> the final release.
>> >>> If you are ok with the upgrade, we would prepare a bval release.
>> >>>
>> >>> It's a big boost in the startup performance and with those changes, we
>> >>> almost have the same startup time as with 7.x.
>> >>>
>> >>> Best regards,
>> >>> Thomas
>> >>>
>> >>
>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

David Blevins-2
> On Aug 12, 2019, at 5:39 AM, Thomas Andraschko <[hidden email]> wrote:
>
> Started the release vote today, will come back when it's released :)

Awesome.  Note that the 2.0.2 release has the regression, so you could do the harder part of the change now if you wanted.  The primary thing needed is someone who understands what changed in BVal to explain it to the world and guide people towards any workarounds.

Here is the example in question which is about 8 years old.  Anyone who will be hit by the issue probably followed this example at one point or another, so this would be a good place to document a workaround.

 - https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract

This is the example that will fail on bval 2.0.2 or the coming 2.0.3.


-David


>
> Am Di., 6. Aug. 2019 um 10:27 Uhr schrieb Thomas Andraschko <
> [hidden email]>:
>
>> Im in Holiday this week, so If you can work on it Mark, it would be great
>> :)
>>
>> Mark Struberg <[hidden email]> schrieb am Di., 6. Aug. 2019,
>> 08:41:
>>
>>> I can probably help with that a bit. Just ping me if you need something.
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>>> Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <
>>> [hidden email]>:
>>>>
>>>> I would like to release 2.0.3, as it contains some fixes and performance
>>>> boosts, if you are ok with using the official bval
>>>>
>>>> Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5. Aug.
>>>> 2019, 18:24:
>>>>
>>>>> Following up on this thread.
>>>>> What version would you recommend?
>>>>>
>>>>> On Maven central we have
>>>>> https://search.maven.org/search?q=g:org.apache.bval
>>>>> I believe it's 2.0.2 but wanted to double check
>>>>>
>>>>>
>>>>> --
>>>>> Jean-Louis Monteiro
>>>>> http://twitter.com/jlouismonteiro
>>>>> http://www.tomitribe.com
>>>>>
>>>>>
>>>>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
>>>>> [hidden email]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> there were some "possible issues" with bval in the last months,
>>>>> especially:
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/BVAL-174
>>>>>> (also see
>>> https://www.mail-archive.com/dev@.../msg01042.html
>>>>> )
>>>>>>
>>>>>> and
>>>>>>
>>>>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>>>>>>
>>>>>> both are no issues from our perspective @bval side (please feel free
>>> to
>>>>>> join the discussions there).
>>>>>>
>>>>>> I would really like to see the bval upgrade for the next milestone or
>>>>> even
>>>>>> the final release.
>>>>>> If you are ok with the upgrade, we would prepare a bval release.
>>>>>>
>>>>>> It's a big boost in the startup performance and with those changes, we
>>>>>> almost have the same startup time as with 7.x.
>>>>>>
>>>>>> Best regards,
>>>>>> Thomas
>>>>>>
>>>>>
>>>
>>>

Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Thomas Andraschko
PR here: https://github.com/apache/tomee/pull/538

Am Di., 13. Aug. 2019 um 04:29 Uhr schrieb David Blevins <
[hidden email]>:

> > On Aug 12, 2019, at 5:39 AM, Thomas Andraschko <
> [hidden email]> wrote:
> >
> > Started the release vote today, will come back when it's released :)
>
> Awesome.  Note that the 2.0.2 release has the regression, so you could do
> the harder part of the change now if you wanted.  The primary thing needed
> is someone who understands what changed in BVal to explain it to the world
> and guide people towards any workarounds.
>
> Here is the example in question which is about 8 years old.  Anyone who
> will be hit by the issue probably followed this example at one point or
> another, so this would be a good place to document a workaround.
>
>  -
> https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract
>
> This is the example that will fail on bval 2.0.2 or the coming 2.0.3.
>
>
> -David
>
>
> >
> > Am Di., 6. Aug. 2019 um 10:27 Uhr schrieb Thomas Andraschko <
> > [hidden email]>:
> >
> >> Im in Holiday this week, so If you can work on it Mark, it would be
> great
> >> :)
> >>
> >> Mark Struberg <[hidden email]> schrieb am Di., 6. Aug. 2019,
> >> 08:41:
> >>
> >>> I can probably help with that a bit. Just ping me if you need
> something.
> >>>
> >>> LieGrue,
> >>> strub
> >>>
> >>>
> >>>> Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <
> >>> [hidden email]>:
> >>>>
> >>>> I would like to release 2.0.3, as it contains some fixes and
> performance
> >>>> boosts, if you are ok with using the official bval
> >>>>
> >>>> Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5.
> Aug.
> >>>> 2019, 18:24:
> >>>>
> >>>>> Following up on this thread.
> >>>>> What version would you recommend?
> >>>>>
> >>>>> On Maven central we have
> >>>>> https://search.maven.org/search?q=g:org.apache.bval
> >>>>> I believe it's 2.0.2 but wanted to double check
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Jean-Louis Monteiro
> >>>>> http://twitter.com/jlouismonteiro
> >>>>> http://www.tomitribe.com
> >>>>>
> >>>>>
> >>>>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
> >>>>> [hidden email]> wrote:
> >>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> there were some "possible issues" with bval in the last months,
> >>>>> especially:
> >>>>>>
> >>>>>> https://issues.apache.org/jira/browse/BVAL-174
> >>>>>> (also see
> >>> https://www.mail-archive.com/dev@.../msg01042.html
> >>>>> )
> >>>>>>
> >>>>>> and
> >>>>>>
> >>>>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
> >>>>>>
> >>>>>> both are no issues from our perspective @bval side (please feel free
> >>> to
> >>>>>> join the discussions there).
> >>>>>>
> >>>>>> I would really like to see the bval upgrade for the next milestone
> or
> >>>>> even
> >>>>>> the final release.
> >>>>>> If you are ok with the upgrade, we would prepare a bval release.
> >>>>>>
> >>>>>> It's a big boost in the startup performance and with those changes,
> we
> >>>>>> almost have the same startup time as with 7.x.
> >>>>>>
> >>>>>> Best regards,
> >>>>>> Thomas
> >>>>>>
> >>>>>
> >>>
> >>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Upgrade BVal to official (not patched) one

Jean-Louis MONTEIRO
Merged and ticket closed.
Thanks
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 19, 2019 at 3:56 PM Thomas Andraschko <
[hidden email]> wrote:

> PR here: https://github.com/apache/tomee/pull/538
>
> Am Di., 13. Aug. 2019 um 04:29 Uhr schrieb David Blevins <
> [hidden email]>:
>
> > > On Aug 12, 2019, at 5:39 AM, Thomas Andraschko <
> > [hidden email]> wrote:
> > >
> > > Started the release vote today, will come back when it's released :)
> >
> > Awesome.  Note that the 2.0.2 release has the regression, so you could do
> > the harder part of the change now if you wanted.  The primary thing
> needed
> > is someone who understands what changed in BVal to explain it to the
> world
> > and guide people towards any workarounds.
> >
> > Here is the example in question which is about 8 years old.  Anyone who
> > will be hit by the issue probably followed this example at one point or
> > another, so this would be a good place to document a workaround.
> >
> >  -
> >
> https://github.com/apache/tomee/tree/master/examples/bean-validation-design-by-contract
> >
> > This is the example that will fail on bval 2.0.2 or the coming 2.0.3.
> >
> >
> > -David
> >
> >
> > >
> > > Am Di., 6. Aug. 2019 um 10:27 Uhr schrieb Thomas Andraschko <
> > > [hidden email]>:
> > >
> > >> Im in Holiday this week, so If you can work on it Mark, it would be
> > great
> > >> :)
> > >>
> > >> Mark Struberg <[hidden email]> schrieb am Di., 6. Aug.
> 2019,
> > >> 08:41:
> > >>
> > >>> I can probably help with that a bit. Just ping me if you need
> > something.
> > >>>
> > >>> LieGrue,
> > >>> strub
> > >>>
> > >>>
> > >>>> Am 05.08.2019 um 20:16 schrieb Thomas Andraschko <
> > >>> [hidden email]>:
> > >>>>
> > >>>> I would like to release 2.0.3, as it contains some fixes and
> > performance
> > >>>> boosts, if you are ok with using the official bval
> > >>>>
> > >>>> Jean-Louis Monteiro <[hidden email]> schrieb am Mo., 5.
> > Aug.
> > >>>> 2019, 18:24:
> > >>>>
> > >>>>> Following up on this thread.
> > >>>>> What version would you recommend?
> > >>>>>
> > >>>>> On Maven central we have
> > >>>>> https://search.maven.org/search?q=g:org.apache.bval
> > >>>>> I believe it's 2.0.2 but wanted to double check
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Jean-Louis Monteiro
> > >>>>> http://twitter.com/jlouismonteiro
> > >>>>> http://www.tomitribe.com
> > >>>>>
> > >>>>>
> > >>>>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
> > >>>>> [hidden email]> wrote:
> > >>>>>
> > >>>>>> Hi,
> > >>>>>>
> > >>>>>> there were some "possible issues" with bval in the last months,
> > >>>>> especially:
> > >>>>>>
> > >>>>>> https://issues.apache.org/jira/browse/BVAL-174
> > >>>>>> (also see
> > >>> https://www.mail-archive.com/dev@.../msg01042.html
> > >>>>> )
> > >>>>>>
> > >>>>>> and
> > >>>>>>
> > >>>>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
> > >>>>>>
> > >>>>>> both are no issues from our perspective @bval side (please feel
> free
> > >>> to
> > >>>>>> join the discussions there).
> > >>>>>>
> > >>>>>> I would really like to see the bval upgrade for the next milestone
> > or
> > >>>>> even
> > >>>>>> the final release.
> > >>>>>> If you are ok with the upgrade, we would prepare a bval release.
> > >>>>>>
> > >>>>>> It's a big boost in the startup performance and with those
> changes,
> > we
> > >>>>>> almost have the same startup time as with 7.x.
> > >>>>>>
> > >>>>>> Best regards,
> > >>>>>> Thomas
> > >>>>>>
> > >>>>>
> > >>>
> > >>>
> >
> >
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com