Testfailures with trunk/Eclipse build

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Testfailures with trunk/Eclipse build

Hendrik Dev
Hi,

current trunk does have testfailures when running 'mvn clean verify'  in

tomee-embedded -> ClasspathAsWebappTest - not a tck, so should pass i think?
cdi-embedded (26 of 751 methods failed) -  thats maybe ok because not
passing TCK in this stage maybe ok?
cdi-tomee (123 of 843 failed) - thats maybe ok because not passing TCK
in this stage maybe ok?

on OS X 10.9 with oracle java 1.7.0_45

Another thing is that current trunk does not build within Eclipse. JDT
compiler generics stuff i guess.
However: these commits fixed the problem for me:

https://github.com/salyh/tomee/commit/768c5c1200b61004c915397b85007275227a7a6f
https://github.com/salyh/tomee/commit/325da3f0ffb5e33ababa1e977ff34c7c6ea973c4

Thanks
Hendrik

--
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC
Reply | Threaded
Open this post in threaded view
|

Re: Testfailures with trunk/Eclipse build

Romain Manni-Bucau
2014-09-26 11:12 GMT+02:00 Hendrik Dev <[hidden email]>:
> Hi,
>
> current trunk does have testfailures when running 'mvn clean verify'  in
>
> tomee-embedded -> ClasspathAsWebappTest - not a tck, so should pass i think?

It should pass yes, it was at least when pushed. Does it fail alone?

> cdi-embedded (26 of 751 methods failed) -  thats maybe ok because not
> passing TCK in this stage maybe ok?
> cdi-tomee (123 of 843 failed) - thats maybe ok because not passing TCK
> in this stage maybe ok?
>

yes

> on OS X 10.9 with oracle java 1.7.0_45
>
> Another thing is that current trunk does not build within Eclipse. JDT
> compiler generics stuff i guess.
> However: these commits fixed the problem for me:
>
> https://github.com/salyh/tomee/commit/768c5c1200b61004c915397b85007275227a7a6f

-0 if eclipse is buggy that's the one to think IMHO

> https://github.com/salyh/tomee/commit/325da3f0ffb5e33ababa1e977ff34c7c6ea973c4

I don't fully get this one

>
> Thanks
> Hendrik
>
> --
> Hendrik Saly (salyh, hendrikdev22)
> @hendrikdev22
> PGP: 0x22D7F6EC
Reply | Threaded
Open this post in threaded view
|

Re: Testfailures with trunk/Eclipse build

Hendrik Dev
On Fri, Sep 26, 2014 at 11:36 AM, Romain Manni-Bucau
<[hidden email]> wrote:
> 2014-09-26 11:12 GMT+02:00 Hendrik Dev <[hidden email]>:
>> Hi,
>>
>> current trunk does have testfailures when running 'mvn clean verify'  in
>>
>> tomee-embedded -> ClasspathAsWebappTest - not a tck, so should pass i think?
>
> It should pass yes, it was at least when pushed. Does it fail alone?

yes, also fails alone

assertNotNull(MyInitializer.found) is the first assertion which fails



>
>> cdi-embedded (26 of 751 methods failed) -  thats maybe ok because not
>> passing TCK in this stage maybe ok?
>> cdi-tomee (123 of 843 failed) - thats maybe ok because not passing TCK
>> in this stage maybe ok?
>>
>
> yes
>
>> on OS X 10.9 with oracle java 1.7.0_45
>>
>> Another thing is that current trunk does not build within Eclipse. JDT
>> compiler generics stuff i guess.
>> However: these commits fixed the problem for me:
>>
>> https://github.com/salyh/tomee/commit/768c5c1200b61004c915397b85007275227a7a6f
>
> -0 if eclipse is buggy that's the one to think IMHO

sure, but then you force everybody to use idea or netbeans :-(

>
>> https://github.com/salyh/tomee/commit/325da3f0ffb5e33ababa1e977ff34c7c6ea973c4
>
> I don't fully get this one

package names are not matching the source file location ('ext' folder
missing for example)


>
>>
>> Thanks
>> Hendrik
>>
>> --
>> Hendrik Saly (salyh, hendrikdev22)
>> @hendrikdev22
>> PGP: 0x22D7F6EC



--
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC
Reply | Threaded
Open this post in threaded view
|

Re: Testfailures with trunk/Eclipse build

Romain Manni-Bucau
2014-09-26 13:12 GMT+02:00 Hendrik Dev <[hidden email]>:

> On Fri, Sep 26, 2014 at 11:36 AM, Romain Manni-Bucau
> <[hidden email]> wrote:
>> 2014-09-26 11:12 GMT+02:00 Hendrik Dev <[hidden email]>:
>>> Hi,
>>>
>>> current trunk does have testfailures when running 'mvn clean verify'  in
>>>
>>> tomee-embedded -> ClasspathAsWebappTest - not a tck, so should pass i think?
>>
>> It should pass yes, it was at least when pushed. Does it fail alone?
>
> yes, also fails alone
>
> assertNotNull(MyInitializer.found) is the first assertion which fails
>
>

weird it passed for me

>
>>
>>> cdi-embedded (26 of 751 methods failed) -  thats maybe ok because not
>>> passing TCK in this stage maybe ok?
>>> cdi-tomee (123 of 843 failed) - thats maybe ok because not passing TCK
>>> in this stage maybe ok?
>>>
>>
>> yes
>>
>>> on OS X 10.9 with oracle java 1.7.0_45
>>>
>>> Another thing is that current trunk does not build within Eclipse. JDT
>>> compiler generics stuff i guess.
>>> However: these commits fixed the problem for me:
>>>
>>> https://github.com/salyh/tomee/commit/768c5c1200b61004c915397b85007275227a7a6f
>>
>> -0 if eclipse is buggy that's the one to think IMHO
>
> sure, but then you force everybody to use idea or netbeans :-(
>

or eclipse to fix its old bugs?

>>
>>> https://github.com/salyh/tomee/commit/325da3f0ffb5e33ababa1e977ff34c7c6ea973c4
>>
>> I don't fully get this one
>
> package names are not matching the source file location ('ext' folder
> missing for example)
>

yep but this doesn't prevent to build right? +1 for this one at least

>
>>
>>>
>>> Thanks
>>> Hendrik
>>>
>>> --
>>> Hendrik Saly (salyh, hendrikdev22)
>>> @hendrikdev22
>>> PGP: 0x22D7F6EC
>
>
>
> --
> Hendrik Saly (salyh, hendrikdev22)
> @hendrikdev22
> PGP: 0x22D7F6EC
Reply | Threaded
Open this post in threaded view
|

Re: Testfailures with trunk/Eclipse build

Romain Manni-Bucau
just tested and all is fine with idea and maven. Could it be linked to
the buggy maven eclipse embeds?


Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau


2014-09-28 18:32 GMT+02:00 Romain Manni-Bucau <[hidden email]>:

> 2014-09-26 13:12 GMT+02:00 Hendrik Dev <[hidden email]>:
>> On Fri, Sep 26, 2014 at 11:36 AM, Romain Manni-Bucau
>> <[hidden email]> wrote:
>>> 2014-09-26 11:12 GMT+02:00 Hendrik Dev <[hidden email]>:
>>>> Hi,
>>>>
>>>> current trunk does have testfailures when running 'mvn clean verify'  in
>>>>
>>>> tomee-embedded -> ClasspathAsWebappTest - not a tck, so should pass i think?
>>>
>>> It should pass yes, it was at least when pushed. Does it fail alone?
>>
>> yes, also fails alone
>>
>> assertNotNull(MyInitializer.found) is the first assertion which fails
>>
>>
>
> weird it passed for me
>
>>
>>>
>>>> cdi-embedded (26 of 751 methods failed) -  thats maybe ok because not
>>>> passing TCK in this stage maybe ok?
>>>> cdi-tomee (123 of 843 failed) - thats maybe ok because not passing TCK
>>>> in this stage maybe ok?
>>>>
>>>
>>> yes
>>>
>>>> on OS X 10.9 with oracle java 1.7.0_45
>>>>
>>>> Another thing is that current trunk does not build within Eclipse. JDT
>>>> compiler generics stuff i guess.
>>>> However: these commits fixed the problem for me:
>>>>
>>>> https://github.com/salyh/tomee/commit/768c5c1200b61004c915397b85007275227a7a6f
>>>
>>> -0 if eclipse is buggy that's the one to think IMHO
>>
>> sure, but then you force everybody to use idea or netbeans :-(
>>
>
> or eclipse to fix its old bugs?
>
>>>
>>>> https://github.com/salyh/tomee/commit/325da3f0ffb5e33ababa1e977ff34c7c6ea973c4
>>>
>>> I don't fully get this one
>>
>> package names are not matching the source file location ('ext' folder
>> missing for example)
>>
>
> yep but this doesn't prevent to build right? +1 for this one at least
>
>>
>>>
>>>>
>>>> Thanks
>>>> Hendrik
>>>>
>>>> --
>>>> Hendrik Saly (salyh, hendrikdev22)
>>>> @hendrikdev22
>>>> PGP: 0x22D7F6EC
>>
>>
>>
>> --
>> Hendrik Saly (salyh, hendrikdev22)
>> @hendrikdev22
>> PGP: 0x22D7F6EC