TOMEE-2332 MP-JWT JWKs example PR

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

TOMEE-2332 MP-JWT JWKs example PR

Mitja Jeseničnik Kotnik
Hello,

I've sent a PR <https://github.com/apache/tomee/pull/342> on GitHub
for MicroProfile
JWT Example for JWK <https://issues.apache.org/jira/browse/TOMEE-2332>.

If there is something to improve please let me know.

Best Regards,

*Mitja J. Kotnik** | *Software engineer

Mobile:  +386 40 432 182

*[hidden email] <[hidden email]>* | *https://www.cotnic.com
<http://blog.cotnic.com>*
Reply | Threaded
Open this post in threaded view
|

Re: TOMEE-2332 MP-JWT JWKs example PR

Jean-Louis MONTEIRO
Thank you.
I'll have a look after lunch.


Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 11:20 AM Mitja Jeseničnik Kotnik <[hidden email]>
wrote:

> Hello,
>
> I've sent a PR <https://github.com/apache/tomee/pull/342> on GitHub
> for MicroProfile
> JWT Example for JWK <https://issues.apache.org/jira/browse/TOMEE-2332>.
>
> If there is something to improve please let me know.
>
> Best Regards,
>
> *Mitja J. Kotnik** | *Software engineer
>
> Mobile:  +386 40 432 182
>
> *[hidden email] <[hidden email]>* | *https://www.cotnic.com
> <http://blog.cotnic.com>*
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: TOMEE-2332 MP-JWT JWKs example PR

Jean-Louis MONTEIRO
Left 2 or 3 comments but sample looks good so I'll proceed and merge within
the next hour.

Thanks a lot. Great job
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Jan 2, 2019 at 11:32 AM Jean-Louis Monteiro <
[hidden email]> wrote:

> Thank you.
> I'll have a look after lunch.
>
>
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Jan 2, 2019 at 11:20 AM Mitja Jeseničnik Kotnik <[hidden email]>
> wrote:
>
>> Hello,
>>
>> I've sent a PR <https://github.com/apache/tomee/pull/342> on GitHub
>> for MicroProfile
>> JWT Example for JWK <https://issues.apache.org/jira/browse/TOMEE-2332>.
>>
>> If there is something to improve please let me know.
>>
>> Best Regards,
>>
>> *Mitja J. Kotnik** | *Software engineer
>>
>> Mobile:  +386 40 432 182
>>
>> *[hidden email] <[hidden email]>* | *https://www.cotnic.com
>> <http://blog.cotnic.com>*
>>
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: TOMEE-2332 MP-JWT JWKs example PR

Mitja Jeseničnik Kotnik
Hello Jean-Louis,

thanks for the review. I'll take into account the comments and improve the
README.adoc file.

Are there any other issues I could start working on?

Best regards,

*Mitja J. Kotnik** | *Software engineer

Mobile:  +386 40 432 182

*[hidden email] <[hidden email]>* | *https://www.cotnic.com
<http://blog.cotnic.com>*



On Wed, Jan 2, 2019 at 3:43 PM Jean-Louis Monteiro <[hidden email]>
wrote:

> Left 2 or 3 comments but sample looks good so I'll proceed and merge within
> the next hour.
>
> Thanks a lot. Great job
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Jan 2, 2019 at 11:32 AM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
> > Thank you.
> > I'll have a look after lunch.
> >
> >
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Jan 2, 2019 at 11:20 AM Mitja Jeseničnik Kotnik <
> [hidden email]>
> > wrote:
> >
> >> Hello,
> >>
> >> I've sent a PR <https://github.com/apache/tomee/pull/342> on GitHub
> >> for MicroProfile
> >> JWT Example for JWK <https://issues.apache.org/jira/browse/TOMEE-2332>.
> >>
> >> If there is something to improve please let me know.
> >>
> >> Best Regards,
> >>
> >> *Mitja J. Kotnik** | *Software engineer
> >>
> >> Mobile:  +386 40 432 182
> >>
> >> *[hidden email] <[hidden email]>* | *https://www.cotnic.com
> >> <http://blog.cotnic.com>*
> >>
> >
>