Stabilize TomEE Build

classic Classic list List threaded Threaded
50 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Stabilize TomEE Build

Roberto Cortez
Hi folks,

It is great to see so many contributions and we hope to continue and even increase the traffic.

Now, this also comes with a few challenges. Our build has been red for a while and I would like to get it green again:
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>

The latest build has some checkstyle violations and test failures:
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio <https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio>
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio <https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio>

It would be great if someone could pick these issues and fix them and we should prioritize any build fixing PR above everything else.

Also, when someone sends a PR, your work doesn’t end when it gets merged. Running a full build takes almost 5 hours, so the committer most of the times is not able to run the entire build to check your PR. I kindly ask you to monitor the tomee build bot here: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR gets merged and if you uncover something wrong, please send a corrective PR.

I’ll be out the next couple of days, so I hope someone can pick this up :)

Cheers,
Roberto
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Frankie
What can I do to already detect such problems when I work on the code?
What is the difference on the build system? (additional checkstyle rules
...?

Frankie



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Hi,

Great question. The commands are:

Checkstyle: mvn -Pstyle checkstyle:check
PMD: mvn -Pstyle pmd:check

These are relatively quick to run - about a minute or so.

Looks like we have 2 checkstyle violations in the build at the moment:
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio

[INFO] There are 2 errors reported by Checkstyle 6.1.1 with
/home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
ruleset.
[ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
(imports) UnusedImports: Unused import -
org.apache.openejb.loader.SystemClassPath.
[ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
(imports) UnusedImports: Unused import -
org.apache.openejb.loader.JarLocation.jarLocation.

Frankie, would you like to have a go at resolving these?

Cheers

Jon

On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]> wrote:

> What can I do to already detect such problems when I work on the code?
> What is the difference on the build system? (additional checkstyle rules
> ...?
>
> Frankie
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
I can help fixing some of those

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
[hidden email]> wrote:

> Hi,
>
> Great question. The commands are:
>
> Checkstyle: mvn -Pstyle checkstyle:check
> PMD: mvn -Pstyle pmd:check
>
> These are relatively quick to run - about a minute or so.
>
> Looks like we have 2 checkstyle violations in the build at the moment:
>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>
> [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> ruleset.
> [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> (imports) UnusedImports: Unused import -
> org.apache.openejb.loader.SystemClassPath.
> [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> (imports) UnusedImports: Unused import -
> org.apache.openejb.loader.JarLocation.jarLocation.
>
> Frankie, would you like to have a go at resolving these?
>
> Cheers
>
> Jon
>
> On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]> wrote:
>
> > What can I do to already detect such problems when I work on the code?
> > What is the difference on the build system? (additional checkstyle rules
> > ...?
> >
> > Frankie
> >
> >
> >
> > --
> > Sent from:
> > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
I appreciate that. Can I ask you be mindful that Frankie posted, and I
asked him if he wanted to have a go in my reply? We should give him some
time to respond, before someone else picks it up. If Frankie worked on
fixing those, and then found someone else had done the same work without a
JIRA, I suspect that would be pretty frustrating.

Jon

On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
[hidden email]> wrote:

> I can help fixing some of those
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > Hi,
> >
> > Great question. The commands are:
> >
> > Checkstyle: mvn -Pstyle checkstyle:check
> > PMD: mvn -Pstyle pmd:check
> >
> > These are relatively quick to run - about a minute or so.
> >
> > Looks like we have 2 checkstyle violations in the build at the moment:
> >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> >
> > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> >
> >
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> > ruleset.
> > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> > (imports) UnusedImports: Unused import -
> > org.apache.openejb.loader.SystemClassPath.
> > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> > (imports) UnusedImports: Unused import -
> > org.apache.openejb.loader.JarLocation.jarLocation.
> >
> > Frankie, would you like to have a go at resolving these?
> >
> > Cheers
> >
> > Jon
> >
> > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]> wrote:
> >
> > > What can I do to already detect such problems when I work on the code?
> > > What is the difference on the build system? (additional checkstyle
> rules
> > > ...?
> > >
> > > Frankie
> > >
> > >
> > >
> > > --
> > > Sent from:
> > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
Oups, then I believe I need to apologize guys.

I wanted to at least fix the 2 imports so we can get a build with some
results.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
[hidden email]> wrote:

> I appreciate that. Can I ask you be mindful that Frankie posted, and I
> asked him if he wanted to have a go in my reply? We should give him some
> time to respond, before someone else picks it up. If Frankie worked on
> fixing those, and then found someone else had done the same work without a
> JIRA, I suspect that would be pretty frustrating.
>
> Jon
>
> On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
> > I can help fixing some of those
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> > > Hi,
> > >
> > > Great question. The commands are:
> > >
> > > Checkstyle: mvn -Pstyle checkstyle:check
> > > PMD: mvn -Pstyle pmd:check
> > >
> > > These are relatively quick to run - about a minute or so.
> > >
> > > Looks like we have 2 checkstyle violations in the build at the moment:
> > >
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > >
> > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> > >
> > >
> >
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> > > ruleset.
> > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> > > (imports) UnusedImports: Unused import -
> > > org.apache.openejb.loader.SystemClassPath.
> > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> > > (imports) UnusedImports: Unused import -
> > > org.apache.openejb.loader.JarLocation.jarLocation.
> > >
> > > Frankie, would you like to have a go at resolving these?
> > >
> > > Cheers
> > >
> > > Jon
> > >
> > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]>
> wrote:
> > >
> > > > What can I do to already detect such problems when I work on the
> code?
> > > > What is the difference on the build system? (additional checkstyle
> > rules
> > > > ...?
> > > >
> > > > Frankie
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from:
> > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > >
> > >
> >
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Looks like we have some new failures in the itest module:

[ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
'/CalculatorBeanR...

[ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot lookup
'/Calculator...

[ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
'/CalculatorBeanRem...

[ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
'/CalculatorBeanRemote'.

[ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot lookup
'/CalculatorB...

[ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming Cannot
lookup '/Cal...


I'll take a look. JIRA is: https://issues.apache.org/jira/browse/TOMEE-2322.


Cheers


Jon

On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
[hidden email]> wrote:

> Oups, then I believe I need to apologize guys.
>
> I wanted to at least fix the 2 imports so we can get a build with some
> results.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > I appreciate that. Can I ask you be mindful that Frankie posted, and I
> > asked him if he wanted to have a go in my reply? We should give him some
> > time to respond, before someone else picks it up. If Frankie worked on
> > fixing those, and then found someone else had done the same work without
> a
> > JIRA, I suspect that would be pretty frustrating.
> >
> > Jon
> >
> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
> > [hidden email]> wrote:
> >
> > > I can help fixing some of those
> > >
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> > > [hidden email]> wrote:
> > >
> > > > Hi,
> > > >
> > > > Great question. The commands are:
> > > >
> > > > Checkstyle: mvn -Pstyle checkstyle:check
> > > > PMD: mvn -Pstyle pmd:check
> > > >
> > > > These are relatively quick to run - about a minute or so.
> > > >
> > > > Looks like we have 2 checkstyle violations in the build at the
> moment:
> > > >
> > > >
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > > >
> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> > > >
> > > >
> > >
> >
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> > > > ruleset.
> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> > > > (imports) UnusedImports: Unused import -
> > > > org.apache.openejb.loader.SystemClassPath.
> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> > > > (imports) UnusedImports: Unused import -
> > > > org.apache.openejb.loader.JarLocation.jarLocation.
> > > >
> > > > Frankie, would you like to have a go at resolving these?
> > > >
> > > > Cheers
> > > >
> > > > Jon
> > > >
> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]>
> > wrote:
> > > >
> > > > > What can I do to already detect such problems when I work on the
> > code?
> > > > > What is the difference on the build system? (additional checkstyle
> > > rules
> > > > > ...?
> > > > >
> > > > > Frankie
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Sent from:
> > > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > > > >
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
I believe this is the root cause of these test failures:

WARNING: Failed to invoke bootstrap:
javax/persistence/spi/PersistenceUnitInfo

Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/commons/cli/ParseException

at java.lang.Class.getDeclaredConstructors0(Native Method)

at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)

at java.lang.Class.getConstructor0(Class.java:3075)

at java.lang.Class.getConstructor(Class.java:1825)

at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)

Caused by: java.lang.ClassNotFoundException:
org.apache.commons.cli.ParseException

at java.net.URLClassLoader.findClass(URLClassLoader.java:381)

at java.lang.ClassLoader.loadClass(ClassLoader.java:424)

at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)

at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

... 5 more


and its been introduced in this PR: https://github.com/apache/tomee/pull/176
(I pulled the 8.0.0-M1 tag, where this was working, and applied this PR to
it in my working copy, and it now fails).


Digging in to see if I can fix it. Dani, any thoughts you have are
appreciated.


Jon

On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
[hidden email]> wrote:

> Looks like we have some new failures in the itest module:
>
> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
> '/CalculatorBeanR...
>
> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
> lookup '/Calculator...
>
> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
> '/CalculatorBeanRem...
>
> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
> '/CalculatorBeanRemote'.
>
> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
> lookup '/CalculatorB...
>
> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
> Cannot lookup '/Cal...
>
>
> I'll take a look. JIRA is:
> https://issues.apache.org/jira/browse/TOMEE-2322.
>
>
> Cheers
>
>
> Jon
>
> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
>> Oups, then I believe I need to apologize guys.
>>
>> I wanted to at least fix the 2 imports so we can get a build with some
>> results.
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > I appreciate that. Can I ask you be mindful that Frankie posted, and I
>> > asked him if he wanted to have a go in my reply? We should give him some
>> > time to respond, before someone else picks it up. If Frankie worked on
>> > fixing those, and then found someone else had done the same work
>> without a
>> > JIRA, I suspect that would be pretty frustrating.
>> >
>> > Jon
>> >
>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
>> > [hidden email]> wrote:
>> >
>> > > I can help fixing some of those
>> > >
>> > > --
>> > > Jean-Louis Monteiro
>> > > http://twitter.com/jlouismonteiro
>> > > http://www.tomitribe.com
>> > >
>> > >
>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
>> > > [hidden email]> wrote:
>> > >
>> > > > Hi,
>> > > >
>> > > > Great question. The commands are:
>> > > >
>> > > > Checkstyle: mvn -Pstyle checkstyle:check
>> > > > PMD: mvn -Pstyle pmd:check
>> > > >
>> > > > These are relatively quick to run - about a minute or so.
>> > > >
>> > > > Looks like we have 2 checkstyle violations in the build at the
>> moment:
>> > > >
>> > > >
>> > >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > > >
>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>> > > >
>> > > >
>> > >
>> >
>> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
>> > > > ruleset.
>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
>> > > > (imports) UnusedImports: Unused import -
>> > > > org.apache.openejb.loader.SystemClassPath.
>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
>> > > > (imports) UnusedImports: Unused import -
>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
>> > > >
>> > > > Frankie, would you like to have a go at resolving these?
>> > > >
>> > > > Cheers
>> > > >
>> > > > Jon
>> > > >
>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]>
>> > wrote:
>> > > >
>> > > > > What can I do to already detect such problems when I work on the
>> > code?
>> > > > > What is the difference on the build system? (additional checkstyle
>> > > rules
>> > > > > ...?
>> > > > >
>> > > > > Frankie
>> > > > >
>> > > > >
>> > > > >
>> > > > > --
>> > > > > Sent from:
>> > > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>> > > > >
>> > > >
>> > >
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Hopefully this will do the trick: https://github.com/apache/tomee/pull/258.
Full build currently running here.

Jon

On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
[hidden email]> wrote:

> I believe this is the root cause of these test failures:
>
> WARNING: Failed to invoke bootstrap:
> javax/persistence/spi/PersistenceUnitInfo
>
> Exception in thread "main" java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException
>
> at java.lang.Class.getDeclaredConstructors0(Native Method)
>
> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
>
> at java.lang.Class.getConstructor0(Class.java:3075)
>
> at java.lang.Class.getConstructor(Class.java:1825)
>
> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)
>
> Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.cli.ParseException
>
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
>
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>
> ... 5 more
>
>
> and its been introduced in this PR:
> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag,
> where this was working, and applied this PR to it in my working copy, and
> it now fails).
>
>
> Digging in to see if I can fix it. Dani, any thoughts you have are
> appreciated.
>
>
> Jon
>
> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
>> Looks like we have some new failures in the itest module:
>>
>> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
>> '/CalculatorBeanR...
>>
>> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
>> lookup '/Calculator...
>>
>> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
>> '/CalculatorBeanRem...
>>
>> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
>> '/CalculatorBeanRemote'.
>>
>> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
>> lookup '/CalculatorB...
>>
>> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
>> Cannot lookup '/Cal...
>>
>>
>> I'll take a look. JIRA is:
>> https://issues.apache.org/jira/browse/TOMEE-2322.
>>
>>
>> Cheers
>>
>>
>> Jon
>>
>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
>> [hidden email]> wrote:
>>
>>> Oups, then I believe I need to apologize guys.
>>>
>>> I wanted to at least fix the 2 imports so we can get a build with some
>>> results.
>>>
>>> --
>>> Jean-Louis Monteiro
>>> http://twitter.com/jlouismonteiro
>>> http://www.tomitribe.com
>>>
>>>
>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
>>> [hidden email]> wrote:
>>>
>>> > I appreciate that. Can I ask you be mindful that Frankie posted, and I
>>> > asked him if he wanted to have a go in my reply? We should give him
>>> some
>>> > time to respond, before someone else picks it up. If Frankie worked on
>>> > fixing those, and then found someone else had done the same work
>>> without a
>>> > JIRA, I suspect that would be pretty frustrating.
>>> >
>>> > Jon
>>> >
>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
>>> > [hidden email]> wrote:
>>> >
>>> > > I can help fixing some of those
>>> > >
>>> > > --
>>> > > Jean-Louis Monteiro
>>> > > http://twitter.com/jlouismonteiro
>>> > > http://www.tomitribe.com
>>> > >
>>> > >
>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
>>> > > [hidden email]> wrote:
>>> > >
>>> > > > Hi,
>>> > > >
>>> > > > Great question. The commands are:
>>> > > >
>>> > > > Checkstyle: mvn -Pstyle checkstyle:check
>>> > > > PMD: mvn -Pstyle pmd:check
>>> > > >
>>> > > > These are relatively quick to run - about a minute or so.
>>> > > >
>>> > > > Looks like we have 2 checkstyle violations in the build at the
>>> moment:
>>> > > >
>>> > > >
>>> > >
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>> > > >
>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>>> > > >
>>> > > >
>>> > >
>>> >
>>> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
>>> > > > ruleset.
>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
>>> > > > (imports) UnusedImports: Unused import -
>>> > > > org.apache.openejb.loader.SystemClassPath.
>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
>>> > > > (imports) UnusedImports: Unused import -
>>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
>>> > > >
>>> > > > Frankie, would you like to have a go at resolving these?
>>> > > >
>>> > > > Cheers
>>> > > >
>>> > > > Jon
>>> > > >
>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]>
>>> > wrote:
>>> > > >
>>> > > > > What can I do to already detect such problems when I work on the
>>> > code?
>>> > > > > What is the difference on the build system? (additional
>>> checkstyle
>>> > > rules
>>> > > > > ...?
>>> > > > >
>>> > > > > Frankie
>>> > > > >
>>> > > > >
>>> > > > >
>>> > > > > --
>>> > > > > Sent from:
>>> > > > > http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Filed a ticket for bval failures and will work on that next.
https://issues.apache.org/jira/browse/TOMEE-2327

Jon

On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hopefully this will do the trick: https://github.com/apache/tomee/pull/258.
> Full build currently running here.
>
> Jon
>
> On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
> [hidden email]> wrote:
>
>> I believe this is the root cause of these test failures:
>>
>> WARNING: Failed to invoke bootstrap:
>> javax/persistence/spi/PersistenceUnitInfo
>>
>> Exception in thread "main" java.lang.NoClassDefFoundError:
>> org/apache/commons/cli/ParseException
>>
>> at java.lang.Class.getDeclaredConstructors0(Native Method)
>>
>> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
>>
>> at java.lang.Class.getConstructor0(Class.java:3075)
>>
>> at java.lang.Class.getConstructor(Class.java:1825)
>>
>> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)
>>
>> Caused by: java.lang.ClassNotFoundException:
>> org.apache.commons.cli.ParseException
>>
>> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>>
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>>
>> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
>>
>> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>>
>> ... 5 more
>>
>>
>> and its been introduced in this PR:
>> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag,
>> where this was working, and applied this PR to it in my working copy, and
>> it now fails).
>>
>>
>> Digging in to see if I can fix it. Dani, any thoughts you have are
>> appreciated.
>>
>>
>> Jon
>>
>> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>>> Looks like we have some new failures in the itest module:
>>>
>>> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
>>> '/CalculatorBeanR...
>>>
>>> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
>>> lookup '/Calculator...
>>>
>>> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
>>> '/CalculatorBeanRem...
>>>
>>> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
>>> '/CalculatorBeanRemote'.
>>>
>>> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
>>> lookup '/CalculatorB...
>>>
>>> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
>>> Cannot lookup '/Cal...
>>>
>>>
>>> I'll take a look. JIRA is:
>>> https://issues.apache.org/jira/browse/TOMEE-2322.
>>>
>>>
>>> Cheers
>>>
>>>
>>> Jon
>>>
>>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
>>> [hidden email]> wrote:
>>>
>>>> Oups, then I believe I need to apologize guys.
>>>>
>>>> I wanted to at least fix the 2 imports so we can get a build with some
>>>> results.
>>>>
>>>> --
>>>> Jean-Louis Monteiro
>>>> http://twitter.com/jlouismonteiro
>>>> http://www.tomitribe.com
>>>>
>>>>
>>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
>>>> [hidden email]> wrote:
>>>>
>>>> > I appreciate that. Can I ask you be mindful that Frankie posted, and I
>>>> > asked him if he wanted to have a go in my reply? We should give him
>>>> some
>>>> > time to respond, before someone else picks it up. If Frankie worked on
>>>> > fixing those, and then found someone else had done the same work
>>>> without a
>>>> > JIRA, I suspect that would be pretty frustrating.
>>>> >
>>>> > Jon
>>>> >
>>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
>>>> > [hidden email]> wrote:
>>>> >
>>>> > > I can help fixing some of those
>>>> > >
>>>> > > --
>>>> > > Jean-Louis Monteiro
>>>> > > http://twitter.com/jlouismonteiro
>>>> > > http://www.tomitribe.com
>>>> > >
>>>> > >
>>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
>>>> > > [hidden email]> wrote:
>>>> > >
>>>> > > > Hi,
>>>> > > >
>>>> > > > Great question. The commands are:
>>>> > > >
>>>> > > > Checkstyle: mvn -Pstyle checkstyle:check
>>>> > > > PMD: mvn -Pstyle pmd:check
>>>> > > >
>>>> > > > These are relatively quick to run - about a minute or so.
>>>> > > >
>>>> > > > Looks like we have 2 checkstyle violations in the build at the
>>>> moment:
>>>> > > >
>>>> > > >
>>>> > >
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>>> > > >
>>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>>>> > > >
>>>> > > >
>>>> > >
>>>> >
>>>> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
>>>> > > > ruleset.
>>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
>>>> > > > (imports) UnusedImports: Unused import -
>>>> > > > org.apache.openejb.loader.SystemClassPath.
>>>> > > > [ERROR] src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
>>>> > > > (imports) UnusedImports: Unused import -
>>>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
>>>> > > >
>>>> > > > Frankie, would you like to have a go at resolving these?
>>>> > > >
>>>> > > > Cheers
>>>> > > >
>>>> > > > Jon
>>>> > > >
>>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]>
>>>> > wrote:
>>>> > > >
>>>> > > > > What can I do to already detect such problems when I work on the
>>>> > code?
>>>> > > > > What is the difference on the build system? (additional
>>>> checkstyle
>>>> > > rules
>>>> > > > > ...?
>>>> > > > >
>>>> > > > > Frankie
>>>> > > > >
>>>> > > > >
>>>> > > > >
>>>> > > > > --
>>>> > > > > Sent from:
>>>> > > > >
>>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>>>> > > > >
>>>> > > >
>>>> > >
>>>> >
>>>>
>>>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Daniel Cunha
Hi Jon,

Thank you for your fix, it also need to be applied on branch 7.0.1 and on
7.1.x I need update my PR with your changes [
https://github.com/apache/tomee/pull/236]

Em qui, 6 de dez de 2018 às 13:58, Jonathan Gallimore <
[hidden email]> escreveu:

> Filed a ticket for bval failures and will work on that next.
> https://issues.apache.org/jira/browse/TOMEE-2327
>
> Jon
>
> On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > Hopefully this will do the trick:
> https://github.com/apache/tomee/pull/258.
> > Full build currently running here.
> >
> > Jon
> >
> > On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> >> I believe this is the root cause of these test failures:
> >>
> >> WARNING: Failed to invoke bootstrap:
> >> javax/persistence/spi/PersistenceUnitInfo
> >>
> >> Exception in thread "main" java.lang.NoClassDefFoundError:
> >> org/apache/commons/cli/ParseException
> >>
> >> at java.lang.Class.getDeclaredConstructors0(Native Method)
> >>
> >> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
> >>
> >> at java.lang.Class.getConstructor0(Class.java:3075)
> >>
> >> at java.lang.Class.getConstructor(Class.java:1825)
> >>
> >> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)
> >>
> >> Caused by: java.lang.ClassNotFoundException:
> >> org.apache.commons.cli.ParseException
> >>
> >> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> >>
> >> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> >>
> >> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
> >>
> >> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> >>
> >> ... 5 more
> >>
> >>
> >> and its been introduced in this PR:
> >> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag,
> >> where this was working, and applied this PR to it in my working copy,
> and
> >> it now fails).
> >>
> >>
> >> Digging in to see if I can fix it. Dani, any thoughts you have are
> >> appreciated.
> >>
> >>
> >> Jon
> >>
> >> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
> >> [hidden email]> wrote:
> >>
> >>> Looks like we have some new failures in the itest module:
> >>>
> >>> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot lookup
> >>> '/CalculatorBeanR...
> >>>
> >>> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
> >>> lookup '/Calculator...
> >>>
> >>> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
> >>> '/CalculatorBeanRem...
> >>>
> >>> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
> >>> '/CalculatorBeanRemote'.
> >>>
> >>> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
> >>> lookup '/CalculatorB...
> >>>
> >>> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
> >>> Cannot lookup '/Cal...
> >>>
> >>>
> >>> I'll take a look. JIRA is:
> >>> https://issues.apache.org/jira/browse/TOMEE-2322.
> >>>
> >>>
> >>> Cheers
> >>>
> >>>
> >>> Jon
> >>>
> >>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
> >>> [hidden email]> wrote:
> >>>
> >>>> Oups, then I believe I need to apologize guys.
> >>>>
> >>>> I wanted to at least fix the 2 imports so we can get a build with some
> >>>> results.
> >>>>
> >>>> --
> >>>> Jean-Louis Monteiro
> >>>> http://twitter.com/jlouismonteiro
> >>>> http://www.tomitribe.com
> >>>>
> >>>>
> >>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
> >>>> [hidden email]> wrote:
> >>>>
> >>>> > I appreciate that. Can I ask you be mindful that Frankie posted,
> and I
> >>>> > asked him if he wanted to have a go in my reply? We should give him
> >>>> some
> >>>> > time to respond, before someone else picks it up. If Frankie worked
> on
> >>>> > fixing those, and then found someone else had done the same work
> >>>> without a
> >>>> > JIRA, I suspect that would be pretty frustrating.
> >>>> >
> >>>> > Jon
> >>>> >
> >>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
> >>>> > [hidden email]> wrote:
> >>>> >
> >>>> > > I can help fixing some of those
> >>>> > >
> >>>> > > --
> >>>> > > Jean-Louis Monteiro
> >>>> > > http://twitter.com/jlouismonteiro
> >>>> > > http://www.tomitribe.com
> >>>> > >
> >>>> > >
> >>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> >>>> > > [hidden email]> wrote:
> >>>> > >
> >>>> > > > Hi,
> >>>> > > >
> >>>> > > > Great question. The commands are:
> >>>> > > >
> >>>> > > > Checkstyle: mvn -Pstyle checkstyle:check
> >>>> > > > PMD: mvn -Pstyle pmd:check
> >>>> > > >
> >>>> > > > These are relatively quick to run - about a minute or so.
> >>>> > > >
> >>>> > > > Looks like we have 2 checkstyle violations in the build at the
> >>>> moment:
> >>>> > > >
> >>>> > > >
> >>>> > >
> >>>> >
> >>>>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> >>>> > > >
> >>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> >>>> > > >
> >>>> > > >
> >>>> > >
> >>>> >
> >>>>
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> >>>> > > > ruleset.
> >>>> > > > [ERROR]
> src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> >>>> > > > (imports) UnusedImports: Unused import -
> >>>> > > > org.apache.openejb.loader.SystemClassPath.
> >>>> > > > [ERROR]
> src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> >>>> > > > (imports) UnusedImports: Unused import -
> >>>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
> >>>> > > >
> >>>> > > > Frankie, would you like to have a go at resolving these?
> >>>> > > >
> >>>> > > > Cheers
> >>>> > > >
> >>>> > > > Jon
> >>>> > > >
> >>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <[hidden email]
> >
> >>>> > wrote:
> >>>> > > >
> >>>> > > > > What can I do to already detect such problems when I work on
> the
> >>>> > code?
> >>>> > > > > What is the difference on the build system? (additional
> >>>> checkstyle
> >>>> > > rules
> >>>> > > > > ...?
> >>>> > > > >
> >>>> > > > > Frankie
> >>>> > > > >
> >>>> > > > >
> >>>> > > > >
> >>>> > > > > --
> >>>> > > > > Sent from:
> >>>> > > > >
> >>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> >>>> > > > >
> >>>> > > >
> >>>> > >
> >>>> >
> >>>>
> >>>
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Hi Dani

Do you want to have a go at backporting my changes to your PR? The SHAs you
need are these ones: https://github.com/apache/tomee/pull/258/commits

Jon



On Thu, Dec 6, 2018 at 8:03 PM Daniel Cunha <[hidden email]> wrote:

> Hi Jon,
>
> Thank you for your fix, it also need to be applied on branch 7.0.1 and on
> 7.1.x I need update my PR with your changes [
> https://github.com/apache/tomee/pull/236]
>
> Em qui, 6 de dez de 2018 às 13:58, Jonathan Gallimore <
> [hidden email]> escreveu:
>
> > Filed a ticket for bval failures and will work on that next.
> > https://issues.apache.org/jira/browse/TOMEE-2327
> >
> > Jon
> >
> > On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore <
> > [hidden email]> wrote:
> >
> > > Hopefully this will do the trick:
> > https://github.com/apache/tomee/pull/258.
> > > Full build currently running here.
> > >
> > > Jon
> > >
> > > On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
> > > [hidden email]> wrote:
> > >
> > >> I believe this is the root cause of these test failures:
> > >>
> > >> WARNING: Failed to invoke bootstrap:
> > >> javax/persistence/spi/PersistenceUnitInfo
> > >>
> > >> Exception in thread "main" java.lang.NoClassDefFoundError:
> > >> org/apache/commons/cli/ParseException
> > >>
> > >> at java.lang.Class.getDeclaredConstructors0(Native Method)
> > >>
> > >> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
> > >>
> > >> at java.lang.Class.getConstructor0(Class.java:3075)
> > >>
> > >> at java.lang.Class.getConstructor(Class.java:1825)
> > >>
> > >> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)
> > >>
> > >> Caused by: java.lang.ClassNotFoundException:
> > >> org.apache.commons.cli.ParseException
> > >>
> > >> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> > >>
> > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> > >>
> > >> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
> > >>
> > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> > >>
> > >> ... 5 more
> > >>
> > >>
> > >> and its been introduced in this PR:
> > >> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag,
> > >> where this was working, and applied this PR to it in my working copy,
> > and
> > >> it now fails).
> > >>
> > >>
> > >> Digging in to see if I can fix it. Dani, any thoughts you have are
> > >> appreciated.
> > >>
> > >>
> > >> Jon
> > >>
> > >> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
> > >> [hidden email]> wrote:
> > >>
> > >>> Looks like we have some new failures in the itest module:
> > >>>
> > >>> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot
> lookup
> > >>> '/CalculatorBeanR...
> > >>>
> > >>> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
> > >>> lookup '/Calculator...
> > >>>
> > >>> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
> > >>> '/CalculatorBeanRem...
> > >>>
> > >>> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
> > >>> '/CalculatorBeanRemote'.
> > >>>
> > >>> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
> > >>> lookup '/CalculatorB...
> > >>>
> > >>> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
> > >>> Cannot lookup '/Cal...
> > >>>
> > >>>
> > >>> I'll take a look. JIRA is:
> > >>> https://issues.apache.org/jira/browse/TOMEE-2322.
> > >>>
> > >>>
> > >>> Cheers
> > >>>
> > >>>
> > >>> Jon
> > >>>
> > >>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
> > >>> [hidden email]> wrote:
> > >>>
> > >>>> Oups, then I believe I need to apologize guys.
> > >>>>
> > >>>> I wanted to at least fix the 2 imports so we can get a build with
> some
> > >>>> results.
> > >>>>
> > >>>> --
> > >>>> Jean-Louis Monteiro
> > >>>> http://twitter.com/jlouismonteiro
> > >>>> http://www.tomitribe.com
> > >>>>
> > >>>>
> > >>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
> > >>>> [hidden email]> wrote:
> > >>>>
> > >>>> > I appreciate that. Can I ask you be mindful that Frankie posted,
> > and I
> > >>>> > asked him if he wanted to have a go in my reply? We should give
> him
> > >>>> some
> > >>>> > time to respond, before someone else picks it up. If Frankie
> worked
> > on
> > >>>> > fixing those, and then found someone else had done the same work
> > >>>> without a
> > >>>> > JIRA, I suspect that would be pretty frustrating.
> > >>>> >
> > >>>> > Jon
> > >>>> >
> > >>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
> > >>>> > [hidden email]> wrote:
> > >>>> >
> > >>>> > > I can help fixing some of those
> > >>>> > >
> > >>>> > > --
> > >>>> > > Jean-Louis Monteiro
> > >>>> > > http://twitter.com/jlouismonteiro
> > >>>> > > http://www.tomitribe.com
> > >>>> > >
> > >>>> > >
> > >>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
> > >>>> > > [hidden email]> wrote:
> > >>>> > >
> > >>>> > > > Hi,
> > >>>> > > >
> > >>>> > > > Great question. The commands are:
> > >>>> > > >
> > >>>> > > > Checkstyle: mvn -Pstyle checkstyle:check
> > >>>> > > > PMD: mvn -Pstyle pmd:check
> > >>>> > > >
> > >>>> > > > These are relatively quick to run - about a minute or so.
> > >>>> > > >
> > >>>> > > > Looks like we have 2 checkstyle violations in the build at the
> > >>>> moment:
> > >>>> > > >
> > >>>> > > >
> > >>>> > >
> > >>>> >
> > >>>>
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > >>>> > > >
> > >>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
> > >>>> > > >
> > >>>> > > >
> > >>>> > >
> > >>>> >
> > >>>>
> >
> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
> > >>>> > > > ruleset.
> > >>>> > > > [ERROR]
> > src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
> > >>>> > > > (imports) UnusedImports: Unused import -
> > >>>> > > > org.apache.openejb.loader.SystemClassPath.
> > >>>> > > > [ERROR]
> > src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
> > >>>> > > > (imports) UnusedImports: Unused import -
> > >>>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
> > >>>> > > >
> > >>>> > > > Frankie, would you like to have a go at resolving these?
> > >>>> > > >
> > >>>> > > > Cheers
> > >>>> > > >
> > >>>> > > > Jon
> > >>>> > > >
> > >>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <
> [hidden email]
> > >
> > >>>> > wrote:
> > >>>> > > >
> > >>>> > > > > What can I do to already detect such problems when I work on
> > the
> > >>>> > code?
> > >>>> > > > > What is the difference on the build system? (additional
> > >>>> checkstyle
> > >>>> > > rules
> > >>>> > > > > ...?
> > >>>> > > > >
> > >>>> > > > > Frankie
> > >>>> > > > >
> > >>>> > > > >
> > >>>> > > > >
> > >>>> > > > > --
> > >>>> > > > > Sent from:
> > >>>> > > > >
> > >>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
> > >>>> > > > >
> > >>>> > > >
> > >>>> > >
> > >>>> >
> > >>>>
> > >>>
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Actually I just cherry-picked this for both branches - seems to have merged
cleanly, so building and pushing.

Jon

On Thu, Dec 6, 2018 at 8:41 PM Jonathan Gallimore <
[hidden email]> wrote:

> Hi Dani
>
> Do you want to have a go at backporting my changes to your PR? The SHAs
> you need are these ones: https://github.com/apache/tomee/pull/258/commits
>
> Jon
>
>
>
> On Thu, Dec 6, 2018 at 8:03 PM Daniel Cunha <[hidden email]> wrote:
>
>> Hi Jon,
>>
>> Thank you for your fix, it also need to be applied on branch 7.0.1 and on
>> 7.1.x I need update my PR with your changes [
>> https://github.com/apache/tomee/pull/236]
>>
>> Em qui, 6 de dez de 2018 às 13:58, Jonathan Gallimore <
>> [hidden email]> escreveu:
>>
>> > Filed a ticket for bval failures and will work on that next.
>> > https://issues.apache.org/jira/browse/TOMEE-2327
>> >
>> > Jon
>> >
>> > On Thu, Dec 6, 2018 at 3:31 PM Jonathan Gallimore <
>> > [hidden email]> wrote:
>> >
>> > > Hopefully this will do the trick:
>> > https://github.com/apache/tomee/pull/258.
>> > > Full build currently running here.
>> > >
>> > > Jon
>> > >
>> > > On Thu, Dec 6, 2018 at 10:46 AM Jonathan Gallimore <
>> > > [hidden email]> wrote:
>> > >
>> > >> I believe this is the root cause of these test failures:
>> > >>
>> > >> WARNING: Failed to invoke bootstrap:
>> > >> javax/persistence/spi/PersistenceUnitInfo
>> > >>
>> > >> Exception in thread "main" java.lang.NoClassDefFoundError:
>> > >> org/apache/commons/cli/ParseException
>> > >>
>> > >> at java.lang.Class.getDeclaredConstructors0(Native Method)
>> > >>
>> > >> at java.lang.Class.privateGetDeclaredConstructors(Class.java:2671)
>> > >>
>> > >> at java.lang.Class.getConstructor0(Class.java:3075)
>> > >>
>> > >> at java.lang.Class.getConstructor(Class.java:1825)
>> > >>
>> > >> at org.apache.openejb.cli.Bootstrap.main(Bootstrap.java:155)
>> > >>
>> > >> Caused by: java.lang.ClassNotFoundException:
>> > >> org.apache.commons.cli.ParseException
>> > >>
>> > >> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>> > >>
>> > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>> > >>
>> > >> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
>> > >>
>> > >> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>> > >>
>> > >> ... 5 more
>> > >>
>> > >>
>> > >> and its been introduced in this PR:
>> > >> https://github.com/apache/tomee/pull/176 (I pulled the 8.0.0-M1 tag,
>> > >> where this was working, and applied this PR to it in my working copy,
>> > and
>> > >> it now fails).
>> > >>
>> > >>
>> > >> Digging in to see if I can fix it. Dani, any thoughts you have are
>> > >> appreciated.
>> > >>
>> > >>
>> > >> Jon
>> > >>
>> > >> On Wed, Dec 5, 2018 at 9:44 PM Jonathan Gallimore <
>> > >> [hidden email]> wrote:
>> > >>
>> > >>> Looks like we have some new failures in the itest module:
>> > >>>
>> > >>> [ERROR]   RandomConnectionStrategyTest.test:162 » Naming Cannot
>> lookup
>> > >>> '/CalculatorBeanR...
>> > >>>
>> > >>> [ERROR]   ReconnectDelayCaseInsensitiveTest.test:150 » Naming Cannot
>> > >>> lookup '/Calculator...
>> > >>>
>> > >>> [ERROR]   ReconnectDelayListSelfTest.test:150 » Naming Cannot lookup
>> > >>> '/CalculatorBeanRem...
>> > >>>
>> > >>> [ERROR]   ReconnectDelayTest.test:131 » Naming Cannot lookup
>> > >>> '/CalculatorBeanRemote'.
>> > >>>
>> > >>> [ERROR]   RoundRobinConnectionStrategyTest.test:164 » Naming Cannot
>> > >>> lookup '/CalculatorB...
>> > >>>
>> > >>> [ERROR]   StickyConnectionStrategyTest.test:146->invoke:225 » Naming
>> > >>> Cannot lookup '/Cal...
>> > >>>
>> > >>>
>> > >>> I'll take a look. JIRA is:
>> > >>> https://issues.apache.org/jira/browse/TOMEE-2322.
>> > >>>
>> > >>>
>> > >>> Cheers
>> > >>>
>> > >>>
>> > >>> Jon
>> > >>>
>> > >>> On Wed, Dec 5, 2018 at 12:39 PM Jean-Louis Monteiro <
>> > >>> [hidden email]> wrote:
>> > >>>
>> > >>>> Oups, then I believe I need to apologize guys.
>> > >>>>
>> > >>>> I wanted to at least fix the 2 imports so we can get a build with
>> some
>> > >>>> results.
>> > >>>>
>> > >>>> --
>> > >>>> Jean-Louis Monteiro
>> > >>>> http://twitter.com/jlouismonteiro
>> > >>>> http://www.tomitribe.com
>> > >>>>
>> > >>>>
>> > >>>> On Wed, Dec 5, 2018 at 1:24 PM Jonathan Gallimore <
>> > >>>> [hidden email]> wrote:
>> > >>>>
>> > >>>> > I appreciate that. Can I ask you be mindful that Frankie posted,
>> > and I
>> > >>>> > asked him if he wanted to have a go in my reply? We should give
>> him
>> > >>>> some
>> > >>>> > time to respond, before someone else picks it up. If Frankie
>> worked
>> > on
>> > >>>> > fixing those, and then found someone else had done the same work
>> > >>>> without a
>> > >>>> > JIRA, I suspect that would be pretty frustrating.
>> > >>>> >
>> > >>>> > Jon
>> > >>>> >
>> > >>>> > On Wed, Dec 5, 2018 at 12:03 PM Jean-Louis Monteiro <
>> > >>>> > [hidden email]> wrote:
>> > >>>> >
>> > >>>> > > I can help fixing some of those
>> > >>>> > >
>> > >>>> > > --
>> > >>>> > > Jean-Louis Monteiro
>> > >>>> > > http://twitter.com/jlouismonteiro
>> > >>>> > > http://www.tomitribe.com
>> > >>>> > >
>> > >>>> > >
>> > >>>> > > On Wed, Dec 5, 2018 at 11:40 AM Jonathan Gallimore <
>> > >>>> > > [hidden email]> wrote:
>> > >>>> > >
>> > >>>> > > > Hi,
>> > >>>> > > >
>> > >>>> > > > Great question. The commands are:
>> > >>>> > > >
>> > >>>> > > > Checkstyle: mvn -Pstyle checkstyle:check
>> > >>>> > > > PMD: mvn -Pstyle pmd:check
>> > >>>> > > >
>> > >>>> > > > These are relatively quick to run - about a minute or so.
>> > >>>> > > >
>> > >>>> > > > Looks like we have 2 checkstyle violations in the build at
>> the
>> > >>>> moment:
>> > >>>> > > >
>> > >>>> > > >
>> > >>>> > >
>> > >>>> >
>> > >>>>
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > >>>> > > >
>> > >>>> > > > [INFO] There are 2 errors reported by Checkstyle 6.1.1 with
>> > >>>> > > >
>> > >>>> > > >
>> > >>>> > >
>> > >>>> >
>> > >>>>
>> >
>> /home/buildslave/slave/tomee-trunk-ubuntu-jvm8/build/src/main/style/checkstyle.xml
>> > >>>> > > > ruleset.
>> > >>>> > > > [ERROR]
>> > src/main/java/org/apache/openejb/cli/Bootstrap.java[22:8]
>> > >>>> > > > (imports) UnusedImports: Unused import -
>> > >>>> > > > org.apache.openejb.loader.SystemClassPath.
>> > >>>> > > > [ERROR]
>> > src/main/java/org/apache/openejb/cli/Bootstrap.java[34:15]
>> > >>>> > > > (imports) UnusedImports: Unused import -
>> > >>>> > > > org.apache.openejb.loader.JarLocation.jarLocation.
>> > >>>> > > >
>> > >>>> > > > Frankie, would you like to have a go at resolving these?
>> > >>>> > > >
>> > >>>> > > > Cheers
>> > >>>> > > >
>> > >>>> > > > Jon
>> > >>>> > > >
>> > >>>> > > > On Wed, Dec 5, 2018 at 6:50 AM Frankie <
>> [hidden email]
>> > >
>> > >>>> > wrote:
>> > >>>> > > >
>> > >>>> > > > > What can I do to already detect such problems when I work
>> on
>> > the
>> > >>>> > code?
>> > >>>> > > > > What is the difference on the build system? (additional
>> > >>>> checkstyle
>> > >>>> > > rules
>> > >>>> > > > > ...?
>> > >>>> > > > >
>> > >>>> > > > > Frankie
>> > >>>> > > > >
>> > >>>> > > > >
>> > >>>> > > > >
>> > >>>> > > > > --
>> > >>>> > > > > Sent from:
>> > >>>> > > > >
>> > >>>> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>> > >>>> > > > >
>> > >>>> > > >
>> > >>>> > >
>> > >>>> >
>> > >>>>
>> > >>>
>> >
>>
>>
>> --
>> Daniel "soro" Cunha
>> https://twitter.com/dvlc_
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
In reply to this post by Roberto Cortez
I've merged a few PRs in which appear to have kept the build in the same
state. I also fixed up the itest failures. I'll work on bval tomorrow. I
get failures with the MicroProfile REST client locally, so if someone can
take a look at that, that would be great.

Thanks

Jon

On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez <[hidden email]>
wrote:

> Hi folks,
>
> It is great to see so many contributions and we hope to continue and even
> increase the traffic.
>
> Now, this also comes with a few challenges. Our build has been red for a
> while and I would like to get it green again:
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>
> The latest build has some checkstyle violations and test failures:
>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> <
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> >
>
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> <
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> >
>
> It would be great if someone could pick these issues and fix them and we
> should prioritize any build fixing PR above everything else.
>
> Also, when someone sends a PR, your work doesn’t end when it gets merged.
> Running a full build takes almost 5 hours, so the committer most of the
> times is not able to run the entire build to check your PR. I kindly ask
> you to monitor the tomee build bot here:
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
> gets merged and if you uncover something wrong, please send a corrective PR.
>
> I’ll be out the next couple of days, so I hope someone can pick this up :)
>
> Cheers,
> Roberto
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
I have been digging and running tests locally.
Here is the list of tests failures I have extracted.

- JMSInjectionTest
- CDIInvokeSimpleGetOperationTest
- CDIInvokeWithRegisteredProviderTest
- FeatureRegistrationTest
- InvokeWithJsonProviderTest
- DuplicateConfigurationTest
- XMLConfigurationTest
- XMLConfiguredConstraintValidatorTest
- MoviesArquillianHtmlUnitTest
- DeployInWebAppsDirectoryTest
- LegacyServerTest
- LegacyClientTest
- (StickyConnection|RoundRobin|Random)StrategyTest
- ReconnectDelayCaseInsensitiveTest
- ReconnectDelayListSelfTest
- ReconnectTest

Anything else I missed?

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
[hidden email]> wrote:

> I've merged a few PRs in which appear to have kept the build in the same
> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
> get failures with the MicroProfile REST client locally, so if someone can
> take a look at that, that would be great.
>
> Thanks
>
> Jon
>
> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez <[hidden email]
> >
> wrote:
>
> > Hi folks,
> >
> > It is great to see so many contributions and we hope to continue and even
> > increase the traffic.
> >
> > Now, this also comes with a few challenges. Our build has been red for a
> > while and I would like to get it green again:
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
> >
> > The latest build has some checkstyle violations and test failures:
> >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > <
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > >
> >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > <
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > >
> >
> > It would be great if someone could pick these issues and fix them and we
> > should prioritize any build fixing PR above everything else.
> >
> > Also, when someone sends a PR, your work doesn’t end when it gets merged.
> > Running a full build takes almost 5 hours, so the committer most of the
> > times is not able to run the entire build to check your PR. I kindly ask
> > you to monitor the tomee build bot here:
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
> > gets merged and if you uncover something wrong, please send a corrective
> PR.
> >
> > I’ll be out the next couple of days, so I hope someone can pick this up
> :)
> >
> > Cheers,
> > Roberto
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
Hey Jean-Louis

Thanks for the list!

These ones _should_ be fixed (as of late yesterday)

- LegacyServerTest
- LegacyClientTest
- (StickyConnection|RoundRobin|Random)StrategyTest
- ReconnectDelayCaseInsensitiveTest
- ReconnectDelayListSelfTest
- ReconnectTest

Its possible you didn't have my changes.

I'm currently looking at these two:

- XMLConfigurationTest
- XMLConfiguredConstraintValidatorTest

I also get a failure
in  org.apache.openejb.arquillian.tests.cmp.CmpMappingTest, which I wrote,
so I'll take a quick look at that.

Cheers

Jon

On Fri, Dec 7, 2018 at 10:59 AM Jean-Louis Monteiro <
[hidden email]> wrote:

> I have been digging and running tests locally.
> Here is the list of tests failures I have extracted.
>
> - JMSInjectionTest
> - CDIInvokeSimpleGetOperationTest
> - CDIInvokeWithRegisteredProviderTest
> - FeatureRegistrationTest
> - InvokeWithJsonProviderTest
> - DuplicateConfigurationTest
> - XMLConfigurationTest
> - XMLConfiguredConstraintValidatorTest
> - MoviesArquillianHtmlUnitTest
> - DeployInWebAppsDirectoryTest
> - LegacyServerTest
> - LegacyClientTest
> - (StickyConnection|RoundRobin|Random)StrategyTest
> - ReconnectDelayCaseInsensitiveTest
> - ReconnectDelayListSelfTest
> - ReconnectTest
>
> Anything else I missed?
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > I've merged a few PRs in which appear to have kept the build in the same
> > state. I also fixed up the itest failures. I'll work on bval tomorrow. I
> > get failures with the MicroProfile REST client locally, so if someone can
> > take a look at that, that would be great.
> >
> > Thanks
> >
> > Jon
> >
> > On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
> <[hidden email]
> > >
> > wrote:
> >
> > > Hi folks,
> > >
> > > It is great to see so many contributions and we hope to continue and
> even
> > > increase the traffic.
> > >
> > > Now, this also comes with a few challenges. Our build has been red for
> a
> > > while and I would like to get it green again:
> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
> > >
> > > The latest build has some checkstyle violations and test failures:
> > >
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > > <
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
> > > >
> > >
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > > <
> > >
> >
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
> > > >
> > >
> > > It would be great if someone could pick these issues and fix them and
> we
> > > should prioritize any build fixing PR above everything else.
> > >
> > > Also, when someone sends a PR, your work doesn’t end when it gets
> merged.
> > > Running a full build takes almost 5 hours, so the committer most of the
> > > times is not able to run the entire build to check your PR. I kindly
> ask
> > > you to monitor the tomee build bot here:
> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
> > > gets merged and if you uncover something wrong, please send a
> corrective
> > PR.
> > >
> > > I’ll be out the next couple of days, so I hope someone can pick this up
> > :)
> > >
> > > Cheers,
> > > Roberto
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

jgallimore
I see this also fails on
buildbot: org.apache.openejb.arquillian.tests.cmp.sample.CustomOrmXmlTest -
its a simple fix which I'll commit now.

Jon

On Fri, Dec 7, 2018 at 11:05 AM Jonathan Gallimore <
[hidden email]> wrote:

> Hey Jean-Louis
>
> Thanks for the list!
>
> These ones _should_ be fixed (as of late yesterday)
>
> - LegacyServerTest
> - LegacyClientTest
> - (StickyConnection|RoundRobin|Random)StrategyTest
> - ReconnectDelayCaseInsensitiveTest
> - ReconnectDelayListSelfTest
> - ReconnectTest
>
> Its possible you didn't have my changes.
>
> I'm currently looking at these two:
>
> - XMLConfigurationTest
> - XMLConfiguredConstraintValidatorTest
>
> I also get a failure
> in  org.apache.openejb.arquillian.tests.cmp.CmpMappingTest, which I wrote,
> so I'll take a quick look at that.
>
> Cheers
>
> Jon
>
> On Fri, Dec 7, 2018 at 10:59 AM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
>> I have been digging and running tests locally.
>> Here is the list of tests failures I have extracted.
>>
>> - JMSInjectionTest
>> - CDIInvokeSimpleGetOperationTest
>> - CDIInvokeWithRegisteredProviderTest
>> - FeatureRegistrationTest
>> - InvokeWithJsonProviderTest
>> - DuplicateConfigurationTest
>> - XMLConfigurationTest
>> - XMLConfiguredConstraintValidatorTest
>> - MoviesArquillianHtmlUnitTest
>> - DeployInWebAppsDirectoryTest
>> - LegacyServerTest
>> - LegacyClientTest
>> - (StickyConnection|RoundRobin|Random)StrategyTest
>> - ReconnectDelayCaseInsensitiveTest
>> - ReconnectDelayListSelfTest
>> - ReconnectTest
>>
>> Anything else I missed?
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > I've merged a few PRs in which appear to have kept the build in the same
>> > state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>> > get failures with the MicroProfile REST client locally, so if someone
>> can
>> > take a look at that, that would be great.
>> >
>> > Thanks
>> >
>> > Jon
>> >
>> > On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>> <[hidden email]
>> > >
>> > wrote:
>> >
>> > > Hi folks,
>> > >
>> > > It is great to see so many contributions and we hope to continue and
>> even
>> > > increase the traffic.
>> > >
>> > > Now, this also comes with a few challenges. Our build has been red
>> for a
>> > > while and I would like to get it green again:
>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>> > >
>> > > The latest build has some checkstyle violations and test failures:
>> > >
>> > >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > > <
>> > >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > > >
>> > >
>> > >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > > <
>> > >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > > >
>> > >
>> > > It would be great if someone could pick these issues and fix them and
>> we
>> > > should prioritize any build fixing PR above everything else.
>> > >
>> > > Also, when someone sends a PR, your work doesn’t end when it gets
>> merged.
>> > > Running a full build takes almost 5 hours, so the committer most of
>> the
>> > > times is not able to run the entire build to check your PR. I kindly
>> ask
>> > > you to monitor the tomee build bot here:
>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>> > > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>> > > gets merged and if you uncover something wrong, please send a
>> corrective
>> > PR.
>> > >
>> > > I’ll be out the next couple of days, so I hope someone can pick this
>> up
>> > :)
>> > >
>> > > Cheers,
>> > > Roberto
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
In reply to this post by Jean-Louis MONTEIRO
JmsInjectionTests works locally
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
[hidden email]> wrote:

> I have been digging and running tests locally.
> Here is the list of tests failures I have extracted.
>
> - JMSInjectionTest
> - CDIInvokeSimpleGetOperationTest
> - CDIInvokeWithRegisteredProviderTest
> - FeatureRegistrationTest
> - InvokeWithJsonProviderTest
> - DuplicateConfigurationTest
> - XMLConfigurationTest
> - XMLConfiguredConstraintValidatorTest
> - MoviesArquillianHtmlUnitTest
> - DeployInWebAppsDirectoryTest
> - LegacyServerTest
> - LegacyClientTest
> - (StickyConnection|RoundRobin|Random)StrategyTest
> - ReconnectDelayCaseInsensitiveTest
> - ReconnectDelayListSelfTest
> - ReconnectTest
>
> Anything else I missed?
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
> [hidden email]> wrote:
>
>> I've merged a few PRs in which appear to have kept the build in the same
>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>> get failures with the MicroProfile REST client locally, so if someone can
>> take a look at that, that would be great.
>>
>> Thanks
>>
>> Jon
>>
>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>> <[hidden email]>
>> wrote:
>>
>> > Hi folks,
>> >
>> > It is great to see so many contributions and we hope to continue and
>> even
>> > increase the traffic.
>> >
>> > Now, this also comes with a few challenges. Our build has been red for a
>> > while and I would like to get it green again:
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>> >
>> > The latest build has some checkstyle violations and test failures:
>> >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > <
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>> > >
>> >
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > <
>> >
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>> > >
>> >
>> > It would be great if someone could pick these issues and fix them and we
>> > should prioritize any build fixing PR above everything else.
>> >
>> > Also, when someone sends a PR, your work doesn’t end when it gets
>> merged.
>> > Running a full build takes almost 5 hours, so the committer most of the
>> > times is not able to run the entire build to check your PR. I kindly ask
>> > you to monitor the tomee build bot here:
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>> > gets merged and if you uncover something wrong, please send a
>> corrective PR.
>> >
>> > I’ll be out the next couple of days, so I hope someone can pick this up
>> :)
>> >
>> > Cheers,
>> > Roberto
>>
>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
The Duplicate one is also BVal Jon.
I'l looking at the rest-client part.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro <[hidden email]>
wrote:

> JmsInjectionTests works locally
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
>> I have been digging and running tests locally.
>> Here is the list of tests failures I have extracted.
>>
>> - JMSInjectionTest
>> - CDIInvokeSimpleGetOperationTest
>> - CDIInvokeWithRegisteredProviderTest
>> - FeatureRegistrationTest
>> - InvokeWithJsonProviderTest
>> - DuplicateConfigurationTest
>> - XMLConfigurationTest
>> - XMLConfiguredConstraintValidatorTest
>> - MoviesArquillianHtmlUnitTest
>> - DeployInWebAppsDirectoryTest
>> - LegacyServerTest
>> - LegacyClientTest
>> - (StickyConnection|RoundRobin|Random)StrategyTest
>> - ReconnectDelayCaseInsensitiveTest
>> - ReconnectDelayListSelfTest
>> - ReconnectTest
>>
>> Anything else I missed?
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>>> I've merged a few PRs in which appear to have kept the build in the same
>>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>>> get failures with the MicroProfile REST client locally, so if someone can
>>> take a look at that, that would be great.
>>>
>>> Thanks
>>>
>>> Jon
>>>
>>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>>> <[hidden email]>
>>> wrote:
>>>
>>> > Hi folks,
>>> >
>>> > It is great to see so many contributions and we hope to continue and
>>> even
>>> > increase the traffic.
>>> >
>>> > Now, this also comes with a few challenges. Our build has been red for
>>> a
>>> > while and I would like to get it green again:
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>>> >
>>> > The latest build has some checkstyle violations and test failures:
>>> >
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>> > <
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>> > >
>>> >
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>> > <
>>> >
>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>> > >
>>> >
>>> > It would be great if someone could pick these issues and fix them and
>>> we
>>> > should prioritize any build fixing PR above everything else.
>>> >
>>> > Also, when someone sends a PR, your work doesn’t end when it gets
>>> merged.
>>> > Running a full build takes almost 5 hours, so the committer most of the
>>> > times is not able to run the entire build to check your PR. I kindly
>>> ask
>>> > you to monitor the tomee build bot here:
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>>> > gets merged and if you uncover something wrong, please send a
>>> corrective PR.
>>> >
>>> > I’ll be out the next couple of days, so I hope someone can pick this
>>> up :)
>>> >
>>> > Cheers,
>>> > Roberto
>>>
>>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
Reply | Threaded
Open this post in threaded view
|

Re: Stabilize TomEE Build

Jean-Louis MONTEIRO
The rest-client seems to be a version issue

[ERROR]
testInvokesPostOperation(org.eclipse.microprofile.rest.client.tck.cditests.CDIInvokeWithRegisteredProvidersTest)
Time elapsed: 0.521 s  <<< FAILURE!
java.lang.NoSuchMethodError:
org.eclipse.microprofile.rest.client.RestClientBuilder.baseUri(Ljava/net/URI;)Lorg/eclipse/microprofile/rest/client/RestClientBuilder;


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Dec 7, 2018 at 3:56 PM Jean-Louis Monteiro <[hidden email]>
wrote:

> The Duplicate one is also BVal Jon.
> I'l looking at the rest-client part.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Dec 7, 2018 at 2:55 PM Jean-Louis Monteiro <
> [hidden email]> wrote:
>
>> JmsInjectionTests works locally
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Fri, Dec 7, 2018 at 11:52 AM Jean-Louis Monteiro <
>> [hidden email]> wrote:
>>
>>> I have been digging and running tests locally.
>>> Here is the list of tests failures I have extracted.
>>>
>>> - JMSInjectionTest
>>> - CDIInvokeSimpleGetOperationTest
>>> - CDIInvokeWithRegisteredProviderTest
>>> - FeatureRegistrationTest
>>> - InvokeWithJsonProviderTest
>>> - DuplicateConfigurationTest
>>> - XMLConfigurationTest
>>> - XMLConfiguredConstraintValidatorTest
>>> - MoviesArquillianHtmlUnitTest
>>> - DeployInWebAppsDirectoryTest
>>> - LegacyServerTest
>>> - LegacyClientTest
>>> - (StickyConnection|RoundRobin|Random)StrategyTest
>>> - ReconnectDelayCaseInsensitiveTest
>>> - ReconnectDelayListSelfTest
>>> - ReconnectTest
>>>
>>> Anything else I missed?
>>>
>>> --
>>> Jean-Louis Monteiro
>>> http://twitter.com/jlouismonteiro
>>> http://www.tomitribe.com
>>>
>>>
>>> On Thu, Dec 6, 2018 at 11:43 PM Jonathan Gallimore <
>>> [hidden email]> wrote:
>>>
>>>> I've merged a few PRs in which appear to have kept the build in the same
>>>> state. I also fixed up the itest failures. I'll work on bval tomorrow. I
>>>> get failures with the MicroProfile REST client locally, so if someone
>>>> can
>>>> take a look at that, that would be great.
>>>>
>>>> Thanks
>>>>
>>>> Jon
>>>>
>>>> On Tue, Dec 4, 2018 at 10:25 PM Roberto Cortez
>>>> <[hidden email]>
>>>> wrote:
>>>>
>>>> > Hi folks,
>>>> >
>>>> > It is great to see so many contributions and we hope to continue and
>>>> even
>>>> > increase the traffic.
>>>> >
>>>> > Now, this also comes with a few challenges. Our build has been red
>>>> for a
>>>> > while and I would like to get it green again:
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35 <
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8?numbuilds=35>
>>>> >
>>>> > The latest build has some checkstyle violations and test failures:
>>>> >
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>>> > <
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/check-formatting/logs/stdio
>>>> > >
>>>> >
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>>> > <
>>>> >
>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/904/steps/test/logs/stdio
>>>> > >
>>>> >
>>>> > It would be great if someone could pick these issues and fix them and
>>>> we
>>>> > should prioritize any build fixing PR above everything else.
>>>> >
>>>> > Also, when someone sends a PR, your work doesn’t end when it gets
>>>> merged.
>>>> > Running a full build takes almost 5 hours, so the committer most of
>>>> the
>>>> > times is not able to run the entire build to check your PR. I kindly
>>>> ask
>>>> > you to monitor the tomee build bot here:
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 <
>>>> > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8> after your PR
>>>> > gets merged and if you uncover something wrong, please send a
>>>> corrective PR.
>>>> >
>>>> > I’ll be out the next couple of days, so I hope someone can pick this
>>>> up :)
>>>> >
>>>> > Cheers,
>>>> > Roberto
>>>>
>>>
   --
    Jean-Louis Monteiro
    http://twitter.com/jlouismonteiro
    http://www.tomitribe.com
123