Re: tomee git commit: Revert "Upgrade HSQLDB to 2.3.5"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: tomee git commit: Revert "Upgrade HSQLDB to 2.3.5"

Jonathan Gallimore-2
Reverting this temporarily. I created a local buildbot setup that should
fairly closely match the ASF one, and was able to reproduce the build
issue. Reverting this to see if it actually fixes the issue on the CI. If
it doesn't I'll revert the revert, if it does, we'll need to figure out how
to fix things so we can update this dependency and keep the tests working.

Jon

On Thu, Feb 15, 2018 at 9:39 PM, <[hidden email]> wrote:

> Repository: tomee
> Updated Branches:
>   refs/heads/master eb8199f1d -> 613c847e4
>
>
> Revert "Upgrade HSQLDB to 2.3.5"
>
> This reverts commit 7b1ad5f0aedcc2cad68b67604f0ec33acd3b511d.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/613c847e
> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/613c847e
> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/613c847e
>
> Branch: refs/heads/master
> Commit: 613c847e436d8658db45e4013a0c699560a81579
> Parents: eb8199f
> Author: Jonathan Gallimore <[hidden email]>
> Authored: Thu Feb 15 18:25:54 2018 +0000
> Committer: Jonathan Gallimore <[hidden email]>
> Committed: Thu Feb 15 18:25:54 2018 +0000
>
> ----------------------------------------------------------------------
>  pom.xml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/tomee/blob/613c847e/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 6fc6360..58581b8 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -183,7 +183,7 @@
>      <log4j.version>1.2.17</log4j.version>
>      <log4j2.version>2.0.1</log4j2.version>
>      <osgi.framework.version>4.2.0</osgi.framework.version>
> -    <version.hsqldb>2.3.5</version.hsqldb>
> +    <version.hsqldb>2.3.2</version.hsqldb>
>      <version.axiom>1.2.20</version.axiom>
>      <version.xalan>2.7.2</version.xalan>
>      <version.hibernate>4.2.18.Final</version.hibernate>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: tomee git commit: Revert "Upgrade HSQLDB to 2.3.5"

agumbrecht
What broke? I'd be extremely rare that even a major version change on
HSQLDB broke anything.


On 15/02/18 22:41, Jonathan Gallimore wrote:

> Reverting this temporarily. I created a local buildbot setup that should
> fairly closely match the ASF one, and was able to reproduce the build
> issue. Reverting this to see if it actually fixes the issue on the CI. If
> it doesn't I'll revert the revert, if it does, we'll need to figure out how
> to fix things so we can update this dependency and keep the tests working.
>
> Jon
>
> On Thu, Feb 15, 2018 at 9:39 PM, <[hidden email]> wrote:
>
>> Repository: tomee
>> Updated Branches:
>>    refs/heads/master eb8199f1d -> 613c847e4
>>
>>
>> Revert "Upgrade HSQLDB to 2.3.5"
>>
>> This reverts commit 7b1ad5f0aedcc2cad68b67604f0ec33acd3b511d.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/613c847e
>> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/613c847e
>> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/613c847e
>>
>> Branch: refs/heads/master
>> Commit: 613c847e436d8658db45e4013a0c699560a81579
>> Parents: eb8199f
>> Author: Jonathan Gallimore <[hidden email]>
>> Authored: Thu Feb 15 18:25:54 2018 +0000
>> Committer: Jonathan Gallimore <[hidden email]>
>> Committed: Thu Feb 15 18:25:54 2018 +0000
>>
>> ----------------------------------------------------------------------
>>   pom.xml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/tomee/blob/613c847e/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index 6fc6360..58581b8 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -183,7 +183,7 @@
>>       <log4j.version>1.2.17</log4j.version>
>>       <log4j2.version>2.0.1</log4j2.version>
>>       <osgi.framework.version>4.2.0</osgi.framework.version>
>> -    <version.hsqldb>2.3.5</version.hsqldb>
>> +    <version.hsqldb>2.3.2</version.hsqldb>
>>       <version.axiom>1.2.20</version.axiom>
>>       <version.xalan>2.7.2</version.xalan>
>>       <version.hibernate>4.2.18.Final</version.hibernate>
>>
>>

--
Andy Gumbrecht
https://twitter.com/AndyGeeDe
http://www.tomitribe.com
https://www.tomitribe.io


Ubique

    --
    Andy Gumbrecht

    http://www.tomitribe.com
    agumbrecht@tomitribe.com
    https://twitter.com/AndyGeeDe

    TomEE treibt Tomitribe ! | http://tomee.apache.org