Re: [Patch] - Fix the compilation error because of rev2821 changes

[Jacek Laskowski]

On 7/27/06, Mohammed Nour <[hidden email]> wrote:
>
> Hi all...
>
> The changes made by rev2821 caused a compilation error, attached the log of
> the build and the fix for this error. If it is approved I will open a JIRA
> and attach the patch with it.

Thanks Mohammad! I think that before we settle on ASF it's fine to
send patches to the dev mailing list. After we're in ASF, it won't be
acceptable, though.

The patch's fixed the compilation issues, but I had to disable the
tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.

Sending        container/openejb-core/src/main/java/org/openejb/assembler/classic/ContainerBuilder.java
Sending        container/openejb-core/src/main/java/org/openejb/assembler/classic/EjbJarBuilder.java
Sending        container/openejb-core/src/main/java/org/openejb/assembler/spring/DeploymentsFactory.java
Sending        container/openejb-core/src/test/java/org/openejb/core/stateless/StatelessContainerTest.java
Transmitting file data ....
Committed revision 2824.

Jacek

--
Jacek Laskowski
http://www.laskowski.net.pl

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

[Mohammad Nour El-Din]

Hi Jacek...

On 7/27/06, Jacek Laskowski <[hidden email]> wrote:

On 7/27/06, Mohammed Nour <[hidden email]> wrote:
>
> Hi all...
>
> The changes made by rev2821 caused a compilation error, attached the log of
> the build and the fix for this error. If it is approved I will open a JIRA
> and attach the patch with it.

Thanks Mohammad! I think that before we settle on ASF it's fine to
send patches to the dev mailing list. After we're in ASF, it won't be
acceptable, though.

 

Sorry for this but I preferred not to open a JIRA until after the team approve what I claim, as I explained in my mail. And until now I did know whether to open a JIRA and attach the patch with it or not :).

The patch's fixed the compilation issues, but I had to disable the
tests (maven.test.skip) to build OpenEJB 3. Something's broken yet.

Sending        container/openejb-core/src/main/java/org/openejb/assembler/classic/ContainerBuilder.java
Sending        container/openejb-core/src/main/java/org/openejb/assembler/classic/EjbJarBuilder.java
Sending        container/openejb-core/src/main/java/org/openejb/assembler/spring/DeploymentsFactory.java
Sending        container/openejb-core/src/test/java/org/openejb/core/stateless/StatelessContainerTest.java
Transmitting file data ....
Committed revision 2824.

Jacek

--
Jacek Laskowski
http://www.laskowski.net.pl

---------------------------------------------------------------------
To unsubscribe from this list please visit:

   http://xircles.codehaus.org/manage_email

 

Thanks and best regards...

Mohammad Nour El-Din