RE: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?

fabian-a.richter
Should I file a bug report?

-----Original Message-----
From: Romain Manni-Bucau <[hidden email]>
Sent: Wednesday, June 20, 2018 3:52 PM
To: [hidden email]
Subject: *EXT* [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?

you are right, this is a bug. We clearly can't import guava in lib/ (breaks too much apps) so we need to find a solution for that (potentially not importing saml).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 20 juin 2018 à 15:16, <[hidden email]> a écrit :

> I dont understand, java-support-7.1.1.jar (which contains all the
> shibboleth classes) _IS_ part of the TomEE 7.0.4 Plus package
>
> -----Original Message-----
> From: Romain Manni-Bucau <[hidden email]>
> Sent: Wednesday, June 20, 2018 3:12 PM
> To: [hidden email]
> Subject: *EXT* [Newsletter] Re: [Newsletter] Re: [Newsletter] Re:
> Missing Guava in TomEE 7.0.4 Plus?
>
> It is not in tomee lib so should be coming from your app or
> environment :s
>
> by leak i meant we don't intend to deliver this lib out of the box
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> https://rmannibucau.metawerx.net/> | Old Blog <
> http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau>
> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> https://www.packtpub.com/application-development/java-ee-8-high-perfor
> mance
> >
>
>
> Le mer. 20 juin 2018 à 15:06, <[hidden email]> a
> écrit :
>
> > What do you mean with "leak"? We do not have it in our webapp, we
> > only have guava but it is not picked up by the parent classloader :(
> >
> > -----Original Message-----
> > From: Romain Manni-Bucau <[hidden email]>
> > Sent: Wednesday, June 20, 2018 3:00 PM
> > To: [hidden email]
> > Subject: *EXT* [Newsletter] Re: [Newsletter] Re: Missing Guava in
> > TomEE
> > 7.0.4 Plus?
> >
> > Hmm if we provide it OOTB that's a "leak" on our side, if you have
> > it in the webapp just drop it.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> > https://rmannibucau.metawerx.net/> | Old Blog <
> > http://rmannibucau.wordpress.com> | Github
> > <https://github.com/rmannibucau>
> > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> > https://www.packtpub.com/application-development/java-ee-8-high-perf
> > or
> > mance
> > >
> >
> >
> > Le mer. 20 juin 2018 à 14:58, <[hidden email]> a
> > écrit :
> >
> > > Is there a way to not "import shibboleth"? I am pretty sure we
> > > don’t need it...
> > >
> > > -----Original Message-----
> > > From: Romain Manni-Bucau <[hidden email]>
> > > Sent: Wednesday, June 20, 2018 2:49 PM
> > > To: [hidden email]
> > > Subject: *EXT* [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?
> > >
> > > Hi,
> > >
> > > yes and no. We intentionnally drop guava and it works with
> > > opensaml until you import shibboleth which requires it. At that
> > > moment you have to either drop opensaml libs from tomee libs or
> > > add the missing
> ones.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> > > https://rmannibucau.metawerx.net/> | Old Blog <
> > > http://rmannibucau.wordpress.com> | Github
> > > <https://github.com/rmannibucau>
> > > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> > > https://www.packtpub.com/application-development/java-ee-8-high-pe
> > > rf
> > > or
> > > mance
> > > >
> > >
> > >
> > > Le mer. 20 juin 2018 à 14:46, <[hidden email]>
> > > a écrit :
> > >
> > > > Hey,
> > > >
> > > >
> > > >
> > > > when I try to initialize OpenSAML in TomEE 7.0.4 with
> > > > InitializationService.initialize(); I get
> > > >
> > > >
> > > >
> > > > java.lang.ClassNotFoundException:
> > > > com.google.common.base.Function
> > > >
> > > >
> > > > java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> > > >
> > > >            
> > > > java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> > > >
> > > >            
> > > > java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> > > >
> > > >
> > > > net.shibboleth.utilities.java.support.xml.AttributeSupport.getAt
> > > > tr
> > > > ib
> > > > ut
> > > > eValueAsQName(AttributeSupport.java:334)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.XMLConfigurator.initializeObjectPro
> > > > vi
> > > > de
> > > > rs
> > > > (XMLConfigurator.java:231)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > ja
> > > > va
> > > > :203)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > ja
> > > > va
> > > > :188)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > ja
> > > > va
> > > > :162)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.AbstractXMLObjectProviderInitializer.
> > > > in
> > > > it
> > > > (AbstractXMLObjectProviderInitializer.java:52)
> > > >
> > > >
> > > > org.opensaml.core.xml.config.XMLObjectProviderInitializer.init(X
> > > > ML
> > > > Ob
> > > > je
> > > > ctProviderInitializer.java:45)
> > > >
> > > >
> > > > org.opensaml.core.config.InitializationService.initialize(Initia
> > > > li
> > > > za
> > > > ti
> > > > onService.java:56)
> > > >
> > > >
> > > >
> > > > As soon as I add guava-18.0.jar to TomEE/lib it works.
> > > >
> > > >
> > > >
> > > > Did you guys miss to package this transitive dependency of
> > > > opensaml (via java-support)?
> > > >
> > > >
> > > >
> > > > Thanks and best
> > > >
> > > > Fabian
> > > >
> > >
> >
>

smime.p7s (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?

Romain Manni-Bucau
Feel free to do it and if you want submit a pull request or patch if you
have it.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le ven. 22 juin 2018 à 08:28, <[hidden email]> a écrit :

> Should I file a bug report?
>
> -----Original Message-----
> From: Romain Manni-Bucau <[hidden email]>
> Sent: Wednesday, June 20, 2018 3:52 PM
> To: [hidden email]
> Subject: *EXT* [Newsletter] Re: [Newsletter] Re: [Newsletter] Re:
> [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?
>
> you are right, this is a bug. We clearly can't import guava in lib/
> (breaks too much apps) so we need to find a solution for that (potentially
> not importing saml).
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> https://rmannibucau.metawerx.net/> | Old Blog <
> http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau>
> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mer. 20 juin 2018 à 15:16, <[hidden email]> a
> écrit :
>
> > I dont understand, java-support-7.1.1.jar (which contains all the
> > shibboleth classes) _IS_ part of the TomEE 7.0.4 Plus package
> >
> > -----Original Message-----
> > From: Romain Manni-Bucau <[hidden email]>
> > Sent: Wednesday, June 20, 2018 3:12 PM
> > To: [hidden email]
> > Subject: *EXT* [Newsletter] Re: [Newsletter] Re: [Newsletter] Re:
> > Missing Guava in TomEE 7.0.4 Plus?
> >
> > It is not in tomee lib so should be coming from your app or
> > environment :s
> >
> > by leak i meant we don't intend to deliver this lib out of the box
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> > https://rmannibucau.metawerx.net/> | Old Blog <
> > http://rmannibucau.wordpress.com> | Github
> > <https://github.com/rmannibucau>
> > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> > https://www.packtpub.com/application-development/java-ee-8-high-perfor
> > mance
> > >
> >
> >
> > Le mer. 20 juin 2018 à 15:06, <[hidden email]> a
> > écrit :
> >
> > > What do you mean with "leak"? We do not have it in our webapp, we
> > > only have guava but it is not picked up by the parent classloader :(
> > >
> > > -----Original Message-----
> > > From: Romain Manni-Bucau <[hidden email]>
> > > Sent: Wednesday, June 20, 2018 3:00 PM
> > > To: [hidden email]
> > > Subject: *EXT* [Newsletter] Re: [Newsletter] Re: Missing Guava in
> > > TomEE
> > > 7.0.4 Plus?
> > >
> > > Hmm if we provide it OOTB that's a "leak" on our side, if you have
> > > it in the webapp just drop it.
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> > > https://rmannibucau.metawerx.net/> | Old Blog <
> > > http://rmannibucau.wordpress.com> | Github
> > > <https://github.com/rmannibucau>
> > > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> > > https://www.packtpub.com/application-development/java-ee-8-high-perf
> > > or
> > > mance
> > > >
> > >
> > >
> > > Le mer. 20 juin 2018 à 14:58, <[hidden email]> a
> > > écrit :
> > >
> > > > Is there a way to not "import shibboleth"? I am pretty sure we
> > > > don’t need it...
> > > >
> > > > -----Original Message-----
> > > > From: Romain Manni-Bucau <[hidden email]>
> > > > Sent: Wednesday, June 20, 2018 2:49 PM
> > > > To: [hidden email]
> > > > Subject: *EXT* [Newsletter] Re: Missing Guava in TomEE 7.0.4 Plus?
> > > >
> > > > Hi,
> > > >
> > > > yes and no. We intentionnally drop guava and it works with
> > > > opensaml until you import shibboleth which requires it. At that
> > > > moment you have to either drop opensaml libs from tomee libs or
> > > > add the missing
> > ones.
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog <
> > > > https://rmannibucau.metawerx.net/> | Old Blog <
> > > > http://rmannibucau.wordpress.com> | Github
> > > > <https://github.com/rmannibucau>
> > > > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <
> > > > https://www.packtpub.com/application-development/java-ee-8-high-pe
> > > > rf
> > > > or
> > > > mance
> > > > >
> > > >
> > > >
> > > > Le mer. 20 juin 2018 à 14:46, <[hidden email]>
> > > > a écrit :
> > > >
> > > > > Hey,
> > > > >
> > > > >
> > > > >
> > > > > when I try to initialize OpenSAML in TomEE 7.0.4 with
> > > > > InitializationService.initialize(); I get
> > > > >
> > > > >
> > > > >
> > > > > java.lang.ClassNotFoundException:
> > > > > com.google.common.base.Function
> > > > >
> > > > >
> > > > > java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> > > > >
> > > > >
> > > > > java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> > > > >
> > > > >
> > > > > java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> > > > >
> > > > >
> > > > > net.shibboleth.utilities.java.support.xml.AttributeSupport.getAt
> > > > > tr
> > > > > ib
> > > > > ut
> > > > > eValueAsQName(AttributeSupport.java:334)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.XMLConfigurator.initializeObjectPro
> > > > > vi
> > > > > de
> > > > > rs
> > > > > (XMLConfigurator.java:231)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > > ja
> > > > > va
> > > > > :203)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > > ja
> > > > > va
> > > > > :188)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.XMLConfigurator.load(XMLConfigurator.
> > > > > ja
> > > > > va
> > > > > :162)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.AbstractXMLObjectProviderInitializer.
> > > > > in
> > > > > it
> > > > > (AbstractXMLObjectProviderInitializer.java:52)
> > > > >
> > > > >
> > > > > org.opensaml.core.xml.config.XMLObjectProviderInitializer.init(X
> > > > > ML
> > > > > Ob
> > > > > je
> > > > > ctProviderInitializer.java:45)
> > > > >
> > > > >
> > > > > org.opensaml.core.config.InitializationService.initialize(Initia
> > > > > li
> > > > > za
> > > > > ti
> > > > > onService.java:56)
> > > > >
> > > > >
> > > > >
> > > > > As soon as I add guava-18.0.jar to TomEE/lib it works.
> > > > >
> > > > >
> > > > >
> > > > > Did you guys miss to package this transitive dependency of
> > > > > opensaml (via java-support)?
> > > > >
> > > > >
> > > > >
> > > > > Thanks and best
> > > > >
> > > > > Fabian
> > > > >
> > > >
> > >
> >
>