OpenTracing Zipkin

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

OpenTracing Zipkin

ivanjunckes
Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2 +
Zipkin.

When I send the payload to the zipkin API http://localhost:9411/api/v2/spans,
I keep getting back:
400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"

My payload is:
[
  {
    "annotations": [
      {
        "timestamp": 1555097175276000,
        "value": "sr"
      },
      {
        "timestamp": 1555097175402000,
        "value": "ss"
      }
    ],
    "binaryAnnotations": [
      {
        "key": "http.status_code",
        "type": 3,
        "value": 200
      },
      {
        "key": "component",
        "type": 6,
        "value": "jaxrs"
      },
      {
        "key": "span.kind",
        "type": 6,
        "value": "server"
      },
      {
        "key": "http.url",
        "type": 6,
        "value": "http://localhost:8081/number-api/numbers/generate"
      },
      {
        "key": "http.method",
        "type": 6,
        "value": "GET"
      }
    ],
    "duration": 126000,
    "id": 2,
    "kind": "SERVER",
    "localEndpoint": {
      "ipv4": "127.0.0.1",
      "port": 8081,
      "serviceName": "number-api"
    },
    "name":
"GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
    "parentId": 1,
    "tags": {
      "http.status_code": "200",
      "component": "jaxrs",
      "http.url": "http://localhost:8081/number-api/numbers/generate",
      "http.method": "GET"
    },
    "timestamp": 1555097175276000,
    "traceId": 24
  }
]

Any ideas how to fix this?  Anyone was able to configure zipkin as a
collector using TomEE?
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

Romain Manni-Bucau
Hi Ivan

Did you debug ZipkinHttp?

Depending your server/app config you can need some config like providers
etc. This class is a good start to check what is happening.

A good config start is
https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
- you can need to inline the yaml depending you docker compose
version/setup, multiline is not always well supported.



Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <[hidden email]> a
écrit :

> Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2 +
> Zipkin.
>
> When I send the payload to the zipkin API
> http://localhost:9411/api/v2/spans, I keep getting back:
> 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
>
> My payload is:
> [
>   {
>     "annotations": [
>       {
>         "timestamp": 1555097175276000,
>         "value": "sr"
>       },
>       {
>         "timestamp": 1555097175402000,
>         "value": "ss"
>       }
>     ],
>     "binaryAnnotations": [
>       {
>         "key": "http.status_code",
>         "type": 3,
>         "value": 200
>       },
>       {
>         "key": "component",
>         "type": 6,
>         "value": "jaxrs"
>       },
>       {
>         "key": "span.kind",
>         "type": 6,
>         "value": "server"
>       },
>       {
>         "key": "http.url",
>         "type": 6,
>         "value": "http://localhost:8081/number-api/numbers/generate"
>       },
>       {
>         "key": "http.method",
>         "type": 6,
>         "value": "GET"
>       }
>     ],
>     "duration": 126000,
>     "id": 2,
>     "kind": "SERVER",
>     "localEndpoint": {
>       "ipv4": "127.0.0.1",
>       "port": 8081,
>       "serviceName": "number-api"
>     },
>     "name":
> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
>     "parentId": 1,
>     "tags": {
>       "http.status_code": "200",
>       "component": "jaxrs",
>       "http.url": "http://localhost:8081/number-api/numbers/generate",
>       "http.method": "GET"
>     },
>     "timestamp": 1555097175276000,
>     "traceId": 24
>   }
> ]
>
> Any ideas how to fix this?  Anyone was able to configure zipkin as a
> collector using TomEE?
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

ivanjunckes
Romain I was actually using this docker-compose from JL as reference, but
wasn't able to make it work.

I will have a look at it again this week, if I have improvement I will let
you know.

If you have any other tips let me know.

Thanks for the reply!

On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <[hidden email]>
wrote:

> Hi Ivan
>
> Did you debug ZipkinHttp?
>
> Depending your server/app config you can need some config like providers
> etc. This class is a good start to check what is happening.
>
> A good config start is
>
> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
> - you can need to inline the yaml depending you docker compose
> version/setup, multiline is not always well supported.
>
>
>
> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <[hidden email]> a
> écrit :
>
> > Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2 +
> > Zipkin.
> >
> > When I send the payload to the zipkin API
> > http://localhost:9411/api/v2/spans, I keep getting back:
> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
> >
> > My payload is:
> > [
> >   {
> >     "annotations": [
> >       {
> >         "timestamp": 1555097175276000,
> >         "value": "sr"
> >       },
> >       {
> >         "timestamp": 1555097175402000,
> >         "value": "ss"
> >       }
> >     ],
> >     "binaryAnnotations": [
> >       {
> >         "key": "http.status_code",
> >         "type": 3,
> >         "value": 200
> >       },
> >       {
> >         "key": "component",
> >         "type": 6,
> >         "value": "jaxrs"
> >       },
> >       {
> >         "key": "span.kind",
> >         "type": 6,
> >         "value": "server"
> >       },
> >       {
> >         "key": "http.url",
> >         "type": 6,
> >         "value": "http://localhost:8081/number-api/numbers/generate"
> >       },
> >       {
> >         "key": "http.method",
> >         "type": 6,
> >         "value": "GET"
> >       }
> >     ],
> >     "duration": 126000,
> >     "id": 2,
> >     "kind": "SERVER",
> >     "localEndpoint": {
> >       "ipv4": "127.0.0.1",
> >       "port": 8081,
> >       "serviceName": "number-api"
> >     },
> >     "name":
> >
> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
> >     "parentId": 1,
> >     "tags": {
> >       "http.status_code": "200",
> >       "component": "jaxrs",
> >       "http.url": "http://localhost:8081/number-api/numbers/generate",
> >       "http.method": "GET"
> >     },
> >     "timestamp": 1555097175276000,
> >     "traceId": 24
> >   }
> > ]
> >
> > Any ideas how to fix this?  Anyone was able to configure zipkin as a
> > collector using TomEE?
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

Romain Manni-Bucau
Hmm, missed that but did you try using v1 instead of v2 endpoint?

Side note: if it helps you to test move the delay to -1 to not wait the
interval.

Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <[hidden email]> a
écrit :

> Romain I was actually using this docker-compose from JL as reference, but
> wasn't able to make it work.
>
> I will have a look at it again this week, if I have improvement I will let
> you know.
>
> If you have any other tips let me know.
>
> Thanks for the reply!
>
> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <[hidden email]>
> wrote:
>
>> Hi Ivan
>>
>> Did you debug ZipkinHttp?
>>
>> Depending your server/app config you can need some config like providers
>> etc. This class is a good start to check what is happening.
>>
>> A good config start is
>>
>> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
>> - you can need to inline the yaml depending you docker compose
>> version/setup, multiline is not always well supported.
>>
>>
>>
>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <[hidden email]>
>> a
>> écrit :
>>
>> > Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2 +
>> > Zipkin.
>> >
>> > When I send the payload to the zipkin API
>> > http://localhost:9411/api/v2/spans, I keep getting back:
>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
>> >
>> > My payload is:
>> > [
>> >   {
>> >     "annotations": [
>> >       {
>> >         "timestamp": 1555097175276000,
>> >         "value": "sr"
>> >       },
>> >       {
>> >         "timestamp": 1555097175402000,
>> >         "value": "ss"
>> >       }
>> >     ],
>> >     "binaryAnnotations": [
>> >       {
>> >         "key": "http.status_code",
>> >         "type": 3,
>> >         "value": 200
>> >       },
>> >       {
>> >         "key": "component",
>> >         "type": 6,
>> >         "value": "jaxrs"
>> >       },
>> >       {
>> >         "key": "span.kind",
>> >         "type": 6,
>> >         "value": "server"
>> >       },
>> >       {
>> >         "key": "http.url",
>> >         "type": 6,
>> >         "value": "http://localhost:8081/number-api/numbers/generate"
>> >       },
>> >       {
>> >         "key": "http.method",
>> >         "type": 6,
>> >         "value": "GET"
>> >       }
>> >     ],
>> >     "duration": 126000,
>> >     "id": 2,
>> >     "kind": "SERVER",
>> >     "localEndpoint": {
>> >       "ipv4": "127.0.0.1",
>> >       "port": 8081,
>> >       "serviceName": "number-api"
>> >     },
>> >     "name":
>> >
>> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
>> >     "parentId": 1,
>> >     "tags": {
>> >       "http.status_code": "200",
>> >       "component": "jaxrs",
>> >       "http.url": "http://localhost:8081/number-api/numbers/generate",
>> >       "http.method": "GET"
>> >     },
>> >     "timestamp": 1555097175276000,
>> >     "traceId": 24
>> >   }
>> > ]
>> >
>> > Any ideas how to fix this?  Anyone was able to configure zipkin as a
>> > collector using TomEE?
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

ivanjunckes
Cool, these are good tips I will try both. I didn't try v1 yet.

On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <[hidden email]>
wrote:

> Hmm, missed that but did you try using v1 instead of v2 endpoint?
>
> Side note: if it helps you to test move the delay to -1 to not wait the
> interval.
>
> Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <[hidden email]>
> a écrit :
>
>> Romain I was actually using this docker-compose from JL as reference, but
>> wasn't able to make it work.
>>
>> I will have a look at it again this week, if I have improvement I will
>> let you know.
>>
>> If you have any other tips let me know.
>>
>> Thanks for the reply!
>>
>> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <[hidden email]>
>> wrote:
>>
>>> Hi Ivan
>>>
>>> Did you debug ZipkinHttp?
>>>
>>> Depending your server/app config you can need some config like providers
>>> etc. This class is a good start to check what is happening.
>>>
>>> A good config start is
>>>
>>> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
>>> - you can need to inline the yaml depending you docker compose
>>> version/setup, multiline is not always well supported.
>>>
>>>
>>>
>>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <[hidden email]>
>>> a
>>> écrit :
>>>
>>> > Hey guys I am having a hard time to setup TomEE with OpenTracing 1.0.2
>>> +
>>> > Zipkin.
>>> >
>>> > When I send the payload to the zipkin API
>>> > http://localhost:9411/api/v2/spans, I keep getting back:
>>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
>>> >
>>> > My payload is:
>>> > [
>>> >   {
>>> >     "annotations": [
>>> >       {
>>> >         "timestamp": 1555097175276000,
>>> >         "value": "sr"
>>> >       },
>>> >       {
>>> >         "timestamp": 1555097175402000,
>>> >         "value": "ss"
>>> >       }
>>> >     ],
>>> >     "binaryAnnotations": [
>>> >       {
>>> >         "key": "http.status_code",
>>> >         "type": 3,
>>> >         "value": 200
>>> >       },
>>> >       {
>>> >         "key": "component",
>>> >         "type": 6,
>>> >         "value": "jaxrs"
>>> >       },
>>> >       {
>>> >         "key": "span.kind",
>>> >         "type": 6,
>>> >         "value": "server"
>>> >       },
>>> >       {
>>> >         "key": "http.url",
>>> >         "type": 6,
>>> >         "value": "http://localhost:8081/number-api/numbers/generate"
>>> >       },
>>> >       {
>>> >         "key": "http.method",
>>> >         "type": 6,
>>> >         "value": "GET"
>>> >       }
>>> >     ],
>>> >     "duration": 126000,
>>> >     "id": 2,
>>> >     "kind": "SERVER",
>>> >     "localEndpoint": {
>>> >       "ipv4": "127.0.0.1",
>>> >       "port": 8081,
>>> >       "serviceName": "number-api"
>>> >     },
>>> >     "name":
>>> >
>>> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
>>> >     "parentId": 1,
>>> >     "tags": {
>>> >       "http.status_code": "200",
>>> >       "component": "jaxrs",
>>> >       "http.url": "http://localhost:8081/number-api/numbers/generate",
>>> >       "http.method": "GET"
>>> >     },
>>> >     "timestamp": 1555097175276000,
>>> >     "traceId": 24
>>> >   }
>>> > ]
>>> >
>>> > Any ideas how to fix this?  Anyone was able to configure zipkin as a
>>> > collector using TomEE?
>>> >
>>>
>>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

jgallimore
Hey Ivan,

What config are you using? I have this setup here with the following
properties, and absolutely nothing goes over the wire to ZipKin. I put a
debugger on the server and the CDI event for FinishedSpan never gets fired,
so nothing gets collected to be sent to ZipKin. I can probably help with
your issue, but I'll need to get to a point where something gets sent, even
if its rejected at the ZipKin end.

        -Dgeronimo.opentracing.zipkin.serviceName=demo
        -Dgeronimo.opentracing.span.converter.zipkin.sender=http
        -Dgeronimo.opentracing.span.converter.zipkin.http.collector=
http://zipkin:9411/api/v2/spans

-Dgeronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=5000

Jon

On Mon, Apr 15, 2019 at 11:19 PM Ivan Junckes Filho <[hidden email]>
wrote:

> Cool, these are good tips I will try both. I didn't try v1 yet.
>
> On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <[hidden email]>
> wrote:
>
> > Hmm, missed that but did you try using v1 instead of v2 endpoint?
> >
> > Side note: if it helps you to test move the delay to -1 to not wait the
> > interval.
> >
> > Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <[hidden email]>
> > a écrit :
> >
> >> Romain I was actually using this docker-compose from JL as reference,
> but
> >> wasn't able to make it work.
> >>
> >> I will have a look at it again this week, if I have improvement I will
> >> let you know.
> >>
> >> If you have any other tips let me know.
> >>
> >> Thanks for the reply!
> >>
> >> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <
> [hidden email]>
> >> wrote:
> >>
> >>> Hi Ivan
> >>>
> >>> Did you debug ZipkinHttp?
> >>>
> >>> Depending your server/app config you can need some config like
> providers
> >>> etc. This class is a good start to check what is happening.
> >>>
> >>> A good config start is
> >>>
> >>>
> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
> >>> - you can need to inline the yaml depending you docker compose
> >>> version/setup, multiline is not always well supported.
> >>>
> >>>
> >>>
> >>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <
> [hidden email]>
> >>> a
> >>> écrit :
> >>>
> >>> > Hey guys I am having a hard time to setup TomEE with OpenTracing
> 1.0.2
> >>> +
> >>> > Zipkin.
> >>> >
> >>> > When I send the payload to the zipkin API
> >>> > http://localhost:9411/api/v2/spans, I keep getting back:
> >>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
> >>> >
> >>> > My payload is:
> >>> > [
> >>> >   {
> >>> >     "annotations": [
> >>> >       {
> >>> >         "timestamp": 1555097175276000,
> >>> >         "value": "sr"
> >>> >       },
> >>> >       {
> >>> >         "timestamp": 1555097175402000,
> >>> >         "value": "ss"
> >>> >       }
> >>> >     ],
> >>> >     "binaryAnnotations": [
> >>> >       {
> >>> >         "key": "http.status_code",
> >>> >         "type": 3,
> >>> >         "value": 200
> >>> >       },
> >>> >       {
> >>> >         "key": "component",
> >>> >         "type": 6,
> >>> >         "value": "jaxrs"
> >>> >       },
> >>> >       {
> >>> >         "key": "span.kind",
> >>> >         "type": 6,
> >>> >         "value": "server"
> >>> >       },
> >>> >       {
> >>> >         "key": "http.url",
> >>> >         "type": 6,
> >>> >         "value": "http://localhost:8081/number-api/numbers/generate"
> >>> >       },
> >>> >       {
> >>> >         "key": "http.method",
> >>> >         "type": 6,
> >>> >         "value": "GET"
> >>> >       }
> >>> >     ],
> >>> >     "duration": 126000,
> >>> >     "id": 2,
> >>> >     "kind": "SERVER",
> >>> >     "localEndpoint": {
> >>> >       "ipv4": "127.0.0.1",
> >>> >       "port": 8081,
> >>> >       "serviceName": "number-api"
> >>> >     },
> >>> >     "name":
> >>> >
> >>>
> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
> >>> >     "parentId": 1,
> >>> >     "tags": {
> >>> >       "http.status_code": "200",
> >>> >       "component": "jaxrs",
> >>> >       "http.url": "http://localhost:8081/number-api/numbers/generate
> ",
> >>> >       "http.method": "GET"
> >>> >     },
> >>> >     "timestamp": 1555097175276000,
> >>> >     "traceId": 24
> >>> >   }
> >>> > ]
> >>> >
> >>> > Any ideas how to fix this?  Anyone was able to configure zipkin as a
> >>> > collector using TomEE?
> >>> >
> >>>
> >>
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

ivanjunckes
Hi Jon, config was the one below. But couldn't make it work. Also changing
collector for http://localhost:9411/api/v1/spans does not work as well.

geronimo.opentracing.span.converter.zipkin.sender=http
geronimo.opentracing.span.converter.zipkin.http.collector=
http://localhost:9411/api/v2/spans
geronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=6000
geronimo.opentracing.span.converter.zipkin.http.maxSpansPerBulk=1
geronimo.opentracing.span.converter.zipkin.http.maxSpansIteration=1
geronimo.opentracing.span.converter.zipkin.http.bufferSize=1

Thanks!

On Wed, Apr 24, 2019 at 9:00 AM Jonathan Gallimore <
[hidden email]> wrote:

> Hey Ivan,
>
> What config are you using? I have this setup here with the following
> properties, and absolutely nothing goes over the wire to ZipKin. I put a
> debugger on the server and the CDI event for FinishedSpan never gets fired,
> so nothing gets collected to be sent to ZipKin. I can probably help with
> your issue, but I'll need to get to a point where something gets sent, even
> if its rejected at the ZipKin end.
>
>         -Dgeronimo.opentracing.zipkin.serviceName=demo
>         -Dgeronimo.opentracing.span.converter.zipkin.sender=http
>         -Dgeronimo.opentracing.span.converter.zipkin.http.collector=
> http://zipkin:9411/api/v2/spans
>
> -Dgeronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=5000
>
> Jon
>
> On Mon, Apr 15, 2019 at 11:19 PM Ivan Junckes Filho <[hidden email]
> >
> wrote:
>
> > Cool, these are good tips I will try both. I didn't try v1 yet.
> >
> > On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <
> [hidden email]>
> > wrote:
> >
> > > Hmm, missed that but did you try using v1 instead of v2 endpoint?
> > >
> > > Side note: if it helps you to test move the delay to -1 to not wait the
> > > interval.
> > >
> > > Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <
> [hidden email]>
> > > a écrit :
> > >
> > >> Romain I was actually using this docker-compose from JL as reference,
> > but
> > >> wasn't able to make it work.
> > >>
> > >> I will have a look at it again this week, if I have improvement I will
> > >> let you know.
> > >>
> > >> If you have any other tips let me know.
> > >>
> > >> Thanks for the reply!
> > >>
> > >> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <
> > [hidden email]>
> > >> wrote:
> > >>
> > >>> Hi Ivan
> > >>>
> > >>> Did you debug ZipkinHttp?
> > >>>
> > >>> Depending your server/app config you can need some config like
> > providers
> > >>> etc. This class is a good start to check what is happening.
> > >>>
> > >>> A good config start is
> > >>>
> > >>>
> >
> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
> > >>> - you can need to inline the yaml depending you docker compose
> > >>> version/setup, multiline is not always well supported.
> > >>>
> > >>>
> > >>>
> > >>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <
> > [hidden email]>
> > >>> a
> > >>> écrit :
> > >>>
> > >>> > Hey guys I am having a hard time to setup TomEE with OpenTracing
> > 1.0.2
> > >>> +
> > >>> > Zipkin.
> > >>> >
> > >>> > When I send the payload to the zipkin API
> > >>> > http://localhost:9411/api/v2/spans, I keep getting back:
> > >>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
> > >>> >
> > >>> > My payload is:
> > >>> > [
> > >>> >   {
> > >>> >     "annotations": [
> > >>> >       {
> > >>> >         "timestamp": 1555097175276000,
> > >>> >         "value": "sr"
> > >>> >       },
> > >>> >       {
> > >>> >         "timestamp": 1555097175402000,
> > >>> >         "value": "ss"
> > >>> >       }
> > >>> >     ],
> > >>> >     "binaryAnnotations": [
> > >>> >       {
> > >>> >         "key": "http.status_code",
> > >>> >         "type": 3,
> > >>> >         "value": 200
> > >>> >       },
> > >>> >       {
> > >>> >         "key": "component",
> > >>> >         "type": 6,
> > >>> >         "value": "jaxrs"
> > >>> >       },
> > >>> >       {
> > >>> >         "key": "span.kind",
> > >>> >         "type": 6,
> > >>> >         "value": "server"
> > >>> >       },
> > >>> >       {
> > >>> >         "key": "http.url",
> > >>> >         "type": 6,
> > >>> >         "value": "
> http://localhost:8081/number-api/numbers/generate"
> > >>> >       },
> > >>> >       {
> > >>> >         "key": "http.method",
> > >>> >         "type": 6,
> > >>> >         "value": "GET"
> > >>> >       }
> > >>> >     ],
> > >>> >     "duration": 126000,
> > >>> >     "id": 2,
> > >>> >     "kind": "SERVER",
> > >>> >     "localEndpoint": {
> > >>> >       "ipv4": "127.0.0.1",
> > >>> >       "port": 8081,
> > >>> >       "serviceName": "number-api"
> > >>> >     },
> > >>> >     "name":
> > >>> >
> > >>>
> >
> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
> > >>> >     "parentId": 1,
> > >>> >     "tags": {
> > >>> >       "http.status_code": "200",
> > >>> >       "component": "jaxrs",
> > >>> >       "http.url": "
> http://localhost:8081/number-api/numbers/generate
> > ",
> > >>> >       "http.method": "GET"
> > >>> >     },
> > >>> >     "timestamp": 1555097175276000,
> > >>> >     "traceId": 24
> > >>> >   }
> > >>> > ]
> > >>> >
> > >>> > Any ideas how to fix this?  Anyone was able to configure zipkin as
> a
> > >>> > collector using TomEE?
> > >>> >
> > >>>
> > >>
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

jgallimore
Thanks Ivan! Applying that now.

Jon

On Wed, Apr 24, 2019 at 2:45 PM Ivan Junckes Filho <[hidden email]>
wrote:

> Hi Jon, config was the one below. But couldn't make it work. Also changing
> collector for http://localhost:9411/api/v1/spans does not work as well.
>
> geronimo.opentracing.span.converter.zipkin.sender=http
> geronimo.opentracing.span.converter.zipkin.http.collector=
> http://localhost:9411/api/v2/spans
> geronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=6000
> geronimo.opentracing.span.converter.zipkin.http.maxSpansPerBulk=1
> geronimo.opentracing.span.converter.zipkin.http.maxSpansIteration=1
> geronimo.opentracing.span.converter.zipkin.http.bufferSize=1
>
> Thanks!
>
> On Wed, Apr 24, 2019 at 9:00 AM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > Hey Ivan,
> >
> > What config are you using? I have this setup here with the following
> > properties, and absolutely nothing goes over the wire to ZipKin. I put a
> > debugger on the server and the CDI event for FinishedSpan never gets
> fired,
> > so nothing gets collected to be sent to ZipKin. I can probably help with
> > your issue, but I'll need to get to a point where something gets sent,
> even
> > if its rejected at the ZipKin end.
> >
> >         -Dgeronimo.opentracing.zipkin.serviceName=demo
> >         -Dgeronimo.opentracing.span.converter.zipkin.sender=http
> >         -Dgeronimo.opentracing.span.converter.zipkin.http.collector=
> > http://zipkin:9411/api/v2/spans
> >
> > -Dgeronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=5000
> >
> > Jon
> >
> > On Mon, Apr 15, 2019 at 11:19 PM Ivan Junckes Filho <
> [hidden email]
> > >
> > wrote:
> >
> > > Cool, these are good tips I will try both. I didn't try v1 yet.
> > >
> > > On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <
> > [hidden email]>
> > > wrote:
> > >
> > > > Hmm, missed that but did you try using v1 instead of v2 endpoint?
> > > >
> > > > Side note: if it helps you to test move the delay to -1 to not wait
> the
> > > > interval.
> > > >
> > > > Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <
> > [hidden email]>
> > > > a écrit :
> > > >
> > > >> Romain I was actually using this docker-compose from JL as
> reference,
> > > but
> > > >> wasn't able to make it work.
> > > >>
> > > >> I will have a look at it again this week, if I have improvement I
> will
> > > >> let you know.
> > > >>
> > > >> If you have any other tips let me know.
> > > >>
> > > >> Thanks for the reply!
> > > >>
> > > >> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <
> > > [hidden email]>
> > > >> wrote:
> > > >>
> > > >>> Hi Ivan
> > > >>>
> > > >>> Did you debug ZipkinHttp?
> > > >>>
> > > >>> Depending your server/app config you can need some config like
> > > providers
> > > >>> etc. This class is a good start to check what is happening.
> > > >>>
> > > >>> A good config start is
> > > >>>
> > > >>>
> > >
> >
> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
> > > >>> - you can need to inline the yaml depending you docker compose
> > > >>> version/setup, multiline is not always well supported.
> > > >>>
> > > >>>
> > > >>>
> > > >>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <
> > > [hidden email]>
> > > >>> a
> > > >>> écrit :
> > > >>>
> > > >>> > Hey guys I am having a hard time to setup TomEE with OpenTracing
> > > 1.0.2
> > > >>> +
> > > >>> > Zipkin.
> > > >>> >
> > > >>> > When I send the payload to the zipkin API
> > > >>> > http://localhost:9411/api/v2/spans, I keep getting back:
> > > >>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
> > > >>> >
> > > >>> > My payload is:
> > > >>> > [
> > > >>> >   {
> > > >>> >     "annotations": [
> > > >>> >       {
> > > >>> >         "timestamp": 1555097175276000,
> > > >>> >         "value": "sr"
> > > >>> >       },
> > > >>> >       {
> > > >>> >         "timestamp": 1555097175402000,
> > > >>> >         "value": "ss"
> > > >>> >       }
> > > >>> >     ],
> > > >>> >     "binaryAnnotations": [
> > > >>> >       {
> > > >>> >         "key": "http.status_code",
> > > >>> >         "type": 3,
> > > >>> >         "value": 200
> > > >>> >       },
> > > >>> >       {
> > > >>> >         "key": "component",
> > > >>> >         "type": 6,
> > > >>> >         "value": "jaxrs"
> > > >>> >       },
> > > >>> >       {
> > > >>> >         "key": "span.kind",
> > > >>> >         "type": 6,
> > > >>> >         "value": "server"
> > > >>> >       },
> > > >>> >       {
> > > >>> >         "key": "http.url",
> > > >>> >         "type": 6,
> > > >>> >         "value": "
> > http://localhost:8081/number-api/numbers/generate"
> > > >>> >       },
> > > >>> >       {
> > > >>> >         "key": "http.method",
> > > >>> >         "type": 6,
> > > >>> >         "value": "GET"
> > > >>> >       }
> > > >>> >     ],
> > > >>> >     "duration": 126000,
> > > >>> >     "id": 2,
> > > >>> >     "kind": "SERVER",
> > > >>> >     "localEndpoint": {
> > > >>> >       "ipv4": "127.0.0.1",
> > > >>> >       "port": 8081,
> > > >>> >       "serviceName": "number-api"
> > > >>> >     },
> > > >>> >     "name":
> > > >>> >
> > > >>>
> > >
> >
> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
> > > >>> >     "parentId": 1,
> > > >>> >     "tags": {
> > > >>> >       "http.status_code": "200",
> > > >>> >       "component": "jaxrs",
> > > >>> >       "http.url": "
> > http://localhost:8081/number-api/numbers/generate
> > > ",
> > > >>> >       "http.method": "GET"
> > > >>> >     },
> > > >>> >     "timestamp": 1555097175276000,
> > > >>> >     "traceId": 24
> > > >>> >   }
> > > >>> > ]
> > > >>> >
> > > >>> > Any ideas how to fix this?  Anyone was able to configure zipkin
> as
> > a
> > > >>> > collector using TomEE?
> > > >>> >
> > > >>>
> > > >>
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

jgallimore
Chasing this one down. Stripping out the binary annotations from the
payload to Zipkin looks like it works. I did wire up a test with a
ZipkinRule which creates an in-memory instance of Zipkin for the test with
a mock web server. That works, but the exact same payload sent to the
Zipkin server fails, so I'm digging into that some more.

Jon

On Wed, 24 Apr 2019, 14:53 Jonathan Gallimore, <[hidden email]>
wrote:

> Thanks Ivan! Applying that now.
>
> Jon
>
> On Wed, Apr 24, 2019 at 2:45 PM Ivan Junckes Filho <[hidden email]>
> wrote:
>
>> Hi Jon, config was the one below. But couldn't make it work. Also changing
>> collector for http://localhost:9411/api/v1/spans does not work as well.
>>
>> geronimo.opentracing.span.converter.zipkin.sender=http
>> geronimo.opentracing.span.converter.zipkin.http.collector=
>> http://localhost:9411/api/v2/spans
>> geronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=6000
>> geronimo.opentracing.span.converter.zipkin.http.maxSpansPerBulk=1
>> geronimo.opentracing.span.converter.zipkin.http.maxSpansIteration=1
>> geronimo.opentracing.span.converter.zipkin.http.bufferSize=1
>>
>> Thanks!
>>
>> On Wed, Apr 24, 2019 at 9:00 AM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > Hey Ivan,
>> >
>> > What config are you using? I have this setup here with the following
>> > properties, and absolutely nothing goes over the wire to ZipKin. I put a
>> > debugger on the server and the CDI event for FinishedSpan never gets
>> fired,
>> > so nothing gets collected to be sent to ZipKin. I can probably help with
>> > your issue, but I'll need to get to a point where something gets sent,
>> even
>> > if its rejected at the ZipKin end.
>> >
>> >         -Dgeronimo.opentracing.zipkin.serviceName=demo
>> >         -Dgeronimo.opentracing.span.converter.zipkin.sender=http
>> >         -Dgeronimo.opentracing.span.converter.zipkin.http.collector=
>> > http://zipkin:9411/api/v2/spans
>> >
>> > -Dgeronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=5000
>> >
>> > Jon
>> >
>> > On Mon, Apr 15, 2019 at 11:19 PM Ivan Junckes Filho <
>> [hidden email]
>> > >
>> > wrote:
>> >
>> > > Cool, these are good tips I will try both. I didn't try v1 yet.
>> > >
>> > > On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <
>> > [hidden email]>
>> > > wrote:
>> > >
>> > > > Hmm, missed that but did you try using v1 instead of v2 endpoint?
>> > > >
>> > > > Side note: if it helps you to test move the delay to -1 to not wait
>> the
>> > > > interval.
>> > > >
>> > > > Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <
>> > [hidden email]>
>> > > > a écrit :
>> > > >
>> > > >> Romain I was actually using this docker-compose from JL as
>> reference,
>> > > but
>> > > >> wasn't able to make it work.
>> > > >>
>> > > >> I will have a look at it again this week, if I have improvement I
>> will
>> > > >> let you know.
>> > > >>
>> > > >> If you have any other tips let me know.
>> > > >>
>> > > >> Thanks for the reply!
>> > > >>
>> > > >> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <
>> > > [hidden email]>
>> > > >> wrote:
>> > > >>
>> > > >>> Hi Ivan
>> > > >>>
>> > > >>> Did you debug ZipkinHttp?
>> > > >>>
>> > > >>> Depending your server/app config you can need some config like
>> > > providers
>> > > >>> etc. This class is a good start to check what is happening.
>> > > >>>
>> > > >>> A good config start is
>> > > >>>
>> > > >>>
>> > >
>> >
>> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
>> > > >>> - you can need to inline the yaml depending you docker compose
>> > > >>> version/setup, multiline is not always well supported.
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <
>> > > [hidden email]>
>> > > >>> a
>> > > >>> écrit :
>> > > >>>
>> > > >>> > Hey guys I am having a hard time to setup TomEE with OpenTracing
>> > > 1.0.2
>> > > >>> +
>> > > >>> > Zipkin.
>> > > >>> >
>> > > >>> > When I send the payload to the zipkin API
>> > > >>> > http://localhost:9411/api/v2/spans, I keep getting back:
>> > > >>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
>> > > >>> >
>> > > >>> > My payload is:
>> > > >>> > [
>> > > >>> >   {
>> > > >>> >     "annotations": [
>> > > >>> >       {
>> > > >>> >         "timestamp": 1555097175276000,
>> > > >>> >         "value": "sr"
>> > > >>> >       },
>> > > >>> >       {
>> > > >>> >         "timestamp": 1555097175402000,
>> > > >>> >         "value": "ss"
>> > > >>> >       }
>> > > >>> >     ],
>> > > >>> >     "binaryAnnotations": [
>> > > >>> >       {
>> > > >>> >         "key": "http.status_code",
>> > > >>> >         "type": 3,
>> > > >>> >         "value": 200
>> > > >>> >       },
>> > > >>> >       {
>> > > >>> >         "key": "component",
>> > > >>> >         "type": 6,
>> > > >>> >         "value": "jaxrs"
>> > > >>> >       },
>> > > >>> >       {
>> > > >>> >         "key": "span.kind",
>> > > >>> >         "type": 6,
>> > > >>> >         "value": "server"
>> > > >>> >       },
>> > > >>> >       {
>> > > >>> >         "key": "http.url",
>> > > >>> >         "type": 6,
>> > > >>> >         "value": "
>> > http://localhost:8081/number-api/numbers/generate"
>> > > >>> >       },
>> > > >>> >       {
>> > > >>> >         "key": "http.method",
>> > > >>> >         "type": 6,
>> > > >>> >         "value": "GET"
>> > > >>> >       }
>> > > >>> >     ],
>> > > >>> >     "duration": 126000,
>> > > >>> >     "id": 2,
>> > > >>> >     "kind": "SERVER",
>> > > >>> >     "localEndpoint": {
>> > > >>> >       "ipv4": "127.0.0.1",
>> > > >>> >       "port": 8081,
>> > > >>> >       "serviceName": "number-api"
>> > > >>> >     },
>> > > >>> >     "name":
>> > > >>> >
>> > > >>>
>> > >
>> >
>> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
>> > > >>> >     "parentId": 1,
>> > > >>> >     "tags": {
>> > > >>> >       "http.status_code": "200",
>> > > >>> >       "component": "jaxrs",
>> > > >>> >       "http.url": "
>> > http://localhost:8081/number-api/numbers/generate
>> > > ",
>> > > >>> >       "http.method": "GET"
>> > > >>> >     },
>> > > >>> >     "timestamp": 1555097175276000,
>> > > >>> >     "traceId": 24
>> > > >>> >   }
>> > > >>> > ]
>> > > >>> >
>> > > >>> > Any ideas how to fix this?  Anyone was able to configure zipkin
>> as
>> > a
>> > > >>> > collector using TomEE?
>> > > >>> >
>> > > >>>
>> > > >>
>> > >
>> >
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: OpenTracing Zipkin

jgallimore
Here's where zipkin drops this:
https://github.com/apache/incubator-zipkin/blob/2.12.9/zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java#L191-L202
-
this check isn't included in ZipkinRule:
https://github.com/apache/incubator-zipkin/blob/2.12.9/zipkin-junit/src/main/java/zipkin2/junit/ZipkinRule.java

Jon

On Thu, May 2, 2019 at 1:27 PM Jonathan Gallimore <
[hidden email]> wrote:

> Chasing this one down. Stripping out the binary annotations from the
> payload to Zipkin looks like it works. I did wire up a test with a
> ZipkinRule which creates an in-memory instance of Zipkin for the test with
> a mock web server. That works, but the exact same payload sent to the
> Zipkin server fails, so I'm digging into that some more.
>
> Jon
>
> On Wed, 24 Apr 2019, 14:53 Jonathan Gallimore, <
> [hidden email]> wrote:
>
>> Thanks Ivan! Applying that now.
>>
>> Jon
>>
>> On Wed, Apr 24, 2019 at 2:45 PM Ivan Junckes Filho <[hidden email]>
>> wrote:
>>
>>> Hi Jon, config was the one below. But couldn't make it work. Also
>>> changing
>>> collector for http://localhost:9411/api/v1/spans does not work as well.
>>>
>>> geronimo.opentracing.span.converter.zipkin.sender=http
>>> geronimo.opentracing.span.converter.zipkin.http.collector=
>>> http://localhost:9411/api/v2/spans
>>> geronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=6000
>>> geronimo.opentracing.span.converter.zipkin.http.maxSpansPerBulk=1
>>> geronimo.opentracing.span.converter.zipkin.http.maxSpansIteration=1
>>> geronimo.opentracing.span.converter.zipkin.http.bufferSize=1
>>>
>>> Thanks!
>>>
>>> On Wed, Apr 24, 2019 at 9:00 AM Jonathan Gallimore <
>>> [hidden email]> wrote:
>>>
>>> > Hey Ivan,
>>> >
>>> > What config are you using? I have this setup here with the following
>>> > properties, and absolutely nothing goes over the wire to ZipKin. I put
>>> a
>>> > debugger on the server and the CDI event for FinishedSpan never gets
>>> fired,
>>> > so nothing gets collected to be sent to ZipKin. I can probably help
>>> with
>>> > your issue, but I'll need to get to a point where something gets sent,
>>> even
>>> > if its rejected at the ZipKin end.
>>> >
>>> >         -Dgeronimo.opentracing.zipkin.serviceName=demo
>>> >         -Dgeronimo.opentracing.span.converter.zipkin.sender=http
>>> >         -Dgeronimo.opentracing.span.converter.zipkin.http.collector=
>>> > http://zipkin:9411/api/v2/spans
>>> >
>>> > -Dgeronimo.opentracing.span.converter.zipkin.http.bulkSendInterval=5000
>>> >
>>> > Jon
>>> >
>>> > On Mon, Apr 15, 2019 at 11:19 PM Ivan Junckes Filho <
>>> [hidden email]
>>> > >
>>> > wrote:
>>> >
>>> > > Cool, these are good tips I will try both. I didn't try v1 yet.
>>> > >
>>> > > On Mon, Apr 15, 2019 at 5:00 PM Romain Manni-Bucau <
>>> > [hidden email]>
>>> > > wrote:
>>> > >
>>> > > > Hmm, missed that but did you try using v1 instead of v2 endpoint?
>>> > > >
>>> > > > Side note: if it helps you to test move the delay to -1 to not
>>> wait the
>>> > > > interval.
>>> > > >
>>> > > > Le lun. 15 avr. 2019 à 20:36, Ivan Junckes Filho <
>>> > [hidden email]>
>>> > > > a écrit :
>>> > > >
>>> > > >> Romain I was actually using this docker-compose from JL as
>>> reference,
>>> > > but
>>> > > >> wasn't able to make it work.
>>> > > >>
>>> > > >> I will have a look at it again this week, if I have improvement I
>>> will
>>> > > >> let you know.
>>> > > >>
>>> > > >> If you have any other tips let me know.
>>> > > >>
>>> > > >> Thanks for the reply!
>>> > > >>
>>> > > >> On Fri, Apr 12, 2019 at 6:25 PM Romain Manni-Bucau <
>>> > > [hidden email]>
>>> > > >> wrote:
>>> > > >>
>>> > > >>> Hi Ivan
>>> > > >>>
>>> > > >>> Did you debug ZipkinHttp?
>>> > > >>>
>>> > > >>> Depending your server/app config you can need some config like
>>> > > providers
>>> > > >>> etc. This class is a good start to check what is happening.
>>> > > >>>
>>> > > >>> A good config start is
>>> > > >>>
>>> > > >>>
>>> > >
>>> >
>>> https://github.com/jeanouii/microprofile-samples/blob/master/docker-compose.yaml
>>> > > >>> - you can need to inline the yaml depending you docker compose
>>> > > >>> version/setup, multiline is not always well supported.
>>> > > >>>
>>> > > >>>
>>> > > >>>
>>> > > >>> Le ven. 12 avr. 2019 à 22:10, Ivan Junckes Filho <
>>> > > [hidden email]>
>>> > > >>> a
>>> > > >>> écrit :
>>> > > >>>
>>> > > >>> > Hey guys I am having a hard time to setup TomEE with
>>> OpenTracing
>>> > > 1.0.2
>>> > > >>> +
>>> > > >>> > Zipkin.
>>> > > >>> >
>>> > > >>> > When I send the payload to the zipkin API
>>> > > >>> > http://localhost:9411/api/v2/spans, I keep getting back:
>>> > > >>> > 400 - "Expected a JSON_V2 encoded list, but received: JSON_V1"
>>> > > >>> >
>>> > > >>> > My payload is:
>>> > > >>> > [
>>> > > >>> >   {
>>> > > >>> >     "annotations": [
>>> > > >>> >       {
>>> > > >>> >         "timestamp": 1555097175276000,
>>> > > >>> >         "value": "sr"
>>> > > >>> >       },
>>> > > >>> >       {
>>> > > >>> >         "timestamp": 1555097175402000,
>>> > > >>> >         "value": "ss"
>>> > > >>> >       }
>>> > > >>> >     ],
>>> > > >>> >     "binaryAnnotations": [
>>> > > >>> >       {
>>> > > >>> >         "key": "http.status_code",
>>> > > >>> >         "type": 3,
>>> > > >>> >         "value": 200
>>> > > >>> >       },
>>> > > >>> >       {
>>> > > >>> >         "key": "component",
>>> > > >>> >         "type": 6,
>>> > > >>> >         "value": "jaxrs"
>>> > > >>> >       },
>>> > > >>> >       {
>>> > > >>> >         "key": "span.kind",
>>> > > >>> >         "type": 6,
>>> > > >>> >         "value": "server"
>>> > > >>> >       },
>>> > > >>> >       {
>>> > > >>> >         "key": "http.url",
>>> > > >>> >         "type": 6,
>>> > > >>> >         "value": "
>>> > http://localhost:8081/number-api/numbers/generate"
>>> > > >>> >       },
>>> > > >>> >       {
>>> > > >>> >         "key": "http.method",
>>> > > >>> >         "type": 6,
>>> > > >>> >         "value": "GET"
>>> > > >>> >       }
>>> > > >>> >     ],
>>> > > >>> >     "duration": 126000,
>>> > > >>> >     "id": 2,
>>> > > >>> >     "kind": "SERVER",
>>> > > >>> >     "localEndpoint": {
>>> > > >>> >       "ipv4": "127.0.0.1",
>>> > > >>> >       "port": 8081,
>>> > > >>> >       "serviceName": "number-api"
>>> > > >>> >     },
>>> > > >>> >     "name":
>>> > > >>> >
>>> > > >>>
>>> > >
>>> >
>>> "GET:com.microprofile.samples.services.number.resource.NumberResource.generate",
>>> > > >>> >     "parentId": 1,
>>> > > >>> >     "tags": {
>>> > > >>> >       "http.status_code": "200",
>>> > > >>> >       "component": "jaxrs",
>>> > > >>> >       "http.url": "
>>> > http://localhost:8081/number-api/numbers/generate
>>> > > ",
>>> > > >>> >       "http.method": "GET"
>>> > > >>> >     },
>>> > > >>> >     "timestamp": 1555097175276000,
>>> > > >>> >     "traceId": 24
>>> > > >>> >   }
>>> > > >>> > ]
>>> > > >>> >
>>> > > >>> > Any ideas how to fix this?  Anyone was able to configure
>>> zipkin as
>>> > a
>>> > > >>> > collector using TomEE?
>>> > > >>> >
>>> > > >>>
>>> > > >>
>>> > >
>>> >
>>>
>>