New Issue and PR

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

New Issue and PR

David Salter-2
Hi,

I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.

I’ve created a PR for this on GitHub at:

https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>

Can someone assign the issue to me and take a look to see if the PR is ok?

Thanks.

David
Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Blevins-2
Thank you, David!  Merged and I'm republishing the website now.


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 24, 2019, at 8:56 AM, David Salter <[hidden email]> wrote:
>
> Hi,
>
> I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.
>
> I’ve created a PR for this on GitHub at:
>
> https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>
>
> Can someone assign the issue to me and take a look to see if the PR is ok?
>
> Thanks.
>
> David

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Blevins-2
You should be all published now, David!  Check take a peak at the site and let me know if you don't see your change.


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 24, 2019, at 7:20 PM, David Blevins <[hidden email]> wrote:
>
> Thank you, David!  Merged and I'm republishing the website now.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>> On May 24, 2019, at 8:56 AM, David Salter <[hidden email]> wrote:
>>
>> Hi,
>>
>> I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.
>>
>> I’ve created a PR for this on GitHub at:
>>
>> https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>
>>
>> Can someone assign the issue to me and take a look to see if the PR is ok?
>>
>> Thanks.
>>
>> David
>

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Salter-2
Thanks David :)

I don’t see the changes on the site though. They should be available at:

http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html

Have I done something wrong?

Thanks

David.

> On 25 May 2019, at 04:04, David Blevins <[hidden email]> wrote:
>
> You should be all published now, David!  Check take a peak at the site and let me know if you don't see your change.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>> On May 24, 2019, at 7:20 PM, David Blevins <[hidden email]> wrote:
>>
>> Thank you, David!  Merged and I'm republishing the website now.
>>
>>
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>>
>>> On May 24, 2019, at 8:56 AM, David Salter <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>> I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.
>>>
>>> I’ve created a PR for this on GitHub at:
>>>
>>> https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>
>>>
>>> Can someone assign the issue to me and take a look to see if the PR is ok?
>>>
>>> Thanks.
>>>
>>> David
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Blevins-2
You didn't do anything wrong.  We had some blockage in the CMS recently do the fact that we have *so* much more doc action going on:

 - https://issues.apache.org/jira/browse/INFRA-18328

We've been pushing the CMS :)  Yay, us!

It appears to be functioning, but some docs are "stuck" and it just seems to take some manual work to get them unstuck and synching properly.

Not sure I'll get to it today, but I'll see if I can push on it again tomorrow.


--
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On May 25, 2019, at 7:25 AM, David Salter <[hidden email]> wrote:
>
> Thanks David :)
>
> I don’t see the changes on the site though. They should be available at:
>
> http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html
>
> Have I done something wrong?
>
> Thanks
>
> David.
>
>> On 25 May 2019, at 04:04, David Blevins <[hidden email]> wrote:
>>
>> You should be all published now, David!  Check take a peak at the site and let me know if you don't see your change.
>>
>>
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>>
>>> On May 24, 2019, at 7:20 PM, David Blevins <[hidden email]> wrote:
>>>
>>> Thank you, David!  Merged and I'm republishing the website now.
>>>
>>>
>>> --
>>> David Blevins
>>> http://twitter.com/dblevins
>>> http://www.tomitribe.com
>>>
>>>> On May 24, 2019, at 8:56 AM, David Salter <[hidden email]> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.
>>>>
>>>> I’ve created a PR for this on GitHub at:
>>>>
>>>> https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>
>>>>
>>>> Can someone assign the issue to me and take a look to see if the PR is ok?
>>>>
>>>> Thanks.
>>>>
>>>> David
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Salter-2
Thanks. That makes sense.

As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll create issues and PRs for :)

Thanks

David.


> On 26 May 2019, at 02:32, David Blevins <[hidden email]> wrote:
>
> You didn't do anything wrong.  We had some blockage in the CMS recently do the fact that we have *so* much more doc action going on:
>
> - https://issues.apache.org/jira/browse/INFRA-18328
>
> We've been pushing the CMS :)  Yay, us!
>
> It appears to be functioning, but some docs are "stuck" and it just seems to take some manual work to get them unstuck and synching properly.
>
> Not sure I'll get to it today, but I'll see if I can push on it again tomorrow.
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
>> On May 25, 2019, at 7:25 AM, David Salter <[hidden email]> wrote:
>>
>> Thanks David :)
>>
>> I don’t see the changes on the site though. They should be available at:
>>
>> http://tomee.apache.org/tomee-8.0/docs/activemqresourceadapter-config.html
>>
>> Have I done something wrong?
>>
>> Thanks
>>
>> David.
>>
>>> On 25 May 2019, at 04:04, David Blevins <[hidden email]> wrote:
>>>
>>> You should be all published now, David!  Check take a peak at the site and let me know if you don't see your change.
>>>
>>>
>>> --
>>> David Blevins
>>> http://twitter.com/dblevins
>>> http://www.tomitribe.com
>>>
>>>> On May 24, 2019, at 7:20 PM, David Blevins <[hidden email]> wrote:
>>>>
>>>> Thank you, David!  Merged and I'm republishing the website now.
>>>>
>>>>
>>>> --
>>>> David Blevins
>>>> http://twitter.com/dblevins
>>>> http://www.tomitribe.com
>>>>
>>>>> On May 24, 2019, at 8:56 AM, David Salter <[hidden email]> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I’ve just created an issue in Jira (https://issues.apache.org/jira/browse/TOMEE-252 <https://issues.apache.org/jira/browse/TOMEE-252>) about the Active MQ Resource Adapter config page not rendering correctly.
>>>>>
>>>>> I’ve created a PR for this on GitHub at:
>>>>>
>>>>> https://github.com/apache/tomee/pull/472 <https://github.com/apache/tomee/pull/472>
>>>>>
>>>>> Can someone assign the issue to me and take a look to see if the PR is ok?
>>>>>
>>>>> Thanks.
>>>>>
>>>>> David
>>>>
>>>
>

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Blevins-2
> On May 26, 2019, at 3:53 AM, David Salter <[hidden email]> wrote:
>
> Thanks. That makes sense.
>
> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll create issues and PRs for :)

That sounds fantastic!  On this example, I regenerated and did a manual tweak of the resulting html -- this seems to be what's required on "stuck" pages for some reason.  Does this look good?

 - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html

Side note, it's fun to have another David on the project again :)  People used to mistake me for David Jencks quite regularly.

I wonder how many Davids we can get on this thread :)


-David

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Salter-2
Davids FTW !

Thanks David.

The page looks all good now :)

I’ve added a comment into Jira stating this, so the issue can now be closed:

https://issues.apache.org/jira/browse/TOMEE-2527 <https://issues.apache.org/jira/browse/TOMEE-2527>

Thanks.

David.

> On 27 May 2019, at 06:04, David Blevins <[hidden email]> wrote:
>
>> On May 26, 2019, at 3:53 AM, David Salter <[hidden email]> wrote:
>>
>> Thanks. That makes sense.
>>
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll create issues and PRs for :)
>
> That sounds fantastic!  On this example, I regenerated and did a manual tweak of the resulting html -- this seems to be what's required on "stuck" pages for some reason.  Does this look good?
>
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
>
> Side note, it's fun to have another David on the project again :)  People used to mistake me for David Jencks quite regularly.
>
> I wonder how many Davids we can get on this thread :)
>
>
> -David
>

Reply | Threaded
Open this post in threaded view
|

Re: New Issue and PR

David Jencks-3
In reply to this post by David Blevins-2
DavidCount++; //Dropping by to say hi…

David Jencks



> On May 26, 2019, at 10:04 PM, David Blevins <[hidden email]> wrote:
>
>> On May 26, 2019, at 3:53 AM, David Salter <[hidden email]> wrote:
>>
>> Thanks. That makes sense.
>>
>> As long as I’m on track, I’ll keep going. I’ve got a few more updates I’ll create issues and PRs for :)
>
> That sounds fantastic!  On this example, I regenerated and did a manual tweak of the resulting html -- this seems to be what's required on "stuck" pages for some reason.  Does this look good?
>
> - http://localhost:8080/tomee-8.0/docs/activemqresourceadapter-config.html
>
> Side note, it's fun to have another David on the project again :)  People used to mistake me for David Jencks quite regularly.
>
> I wonder how many Davids we can get on this thread :)
>
>
> -David
>