JAX-RS Filter Example (TOMEE-2485)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

JAX-RS Filter Example (TOMEE-2485)

jgallimore
I've merged this in - thanks for the PR!

A couple of suggestions (none of them blocking):

1. I'd be tempted to rename this to something other than Servlet:
https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
- just so its clear that its a JAX-RS endpoint and not a servlet.
2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
boot TomEE and run your example. Hopefully that's as easy as adding this
plugin:

      <plugin>
        <groupId>org.apache.tomee.maven</groupId>
        <artifactId>tomee-maven-plugin</artifactId>
        <version>8.0.0-SNAPSHOT</version>
        <configuration>
          <args>-Xmx512m -XX:PermSize=256m</args>
        </configuration>
      </plugin>

3. An Arquillian test would be great - slightly more involved than (2), but
we're happy to give some pointers to help.

Cheers!

Jon

On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) <[hidden email]>
wrote:

>
>      [
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Sherman Marshall updated TOMEE-2485:
> ------------------------------------
>     Issue Type: Sub-task  (was: New Feature)
>         Parent: TOMEE-2482
>
> > JAX-RS Filter Example
> > ---------------------
> >
> >                 Key: TOMEE-2485
> >                 URL: https://issues.apache.org/jira/browse/TOMEE-2485
> >             Project: TomEE
> >          Issue Type: Sub-task
> >          Components: Examples and Documentation
> >            Reporter: Sherman Marshall
> >            Priority: Minor
> >
> > Basic example of how to incorporate JAX-RS filters into an application.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
Reply | Threaded
Open this post in threaded view
|

Re: JAX-RS Filter Example (TOMEE-2485)

Sherman Marshall
Thanks Jon,

I should have followed the naming convention, I will remember that for
future submissions.

I will have to read up on the build instructions a bit more, but I will
make note to do that as well where applicable!

Regards,

Sherman


On Mon, Mar 4, 2019, 2:31 AM Jonathan Gallimore <
[hidden email]> wrote:

> I've merged this in - thanks for the PR!
>
> A couple of suggestions (none of them blocking):
>
> 1. I'd be tempted to rename this to something other than Servlet:
>
> https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
> - just so its clear that its a JAX-RS endpoint and not a servlet.
> 2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
> boot TomEE and run your example. Hopefully that's as easy as adding this
> plugin:
>
>       <plugin>
>         <groupId>org.apache.tomee.maven</groupId>
>         <artifactId>tomee-maven-plugin</artifactId>
>         <version>8.0.0-SNAPSHOT</version>
>         <configuration>
>           <args>-Xmx512m -XX:PermSize=256m</args>
>         </configuration>
>       </plugin>
>
> 3. An Arquillian test would be great - slightly more involved than (2), but
> we're happy to give some pointers to help.
>
> Cheers!
>
> Jon
>
> On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) <[hidden email]>
> wrote:
>
> >
> >      [
> >
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > ]
> >
> > Sherman Marshall updated TOMEE-2485:
> > ------------------------------------
> >     Issue Type: Sub-task  (was: New Feature)
> >         Parent: TOMEE-2482
> >
> > > JAX-RS Filter Example
> > > ---------------------
> > >
> > >                 Key: TOMEE-2485
> > >                 URL: https://issues.apache.org/jira/browse/TOMEE-2485
> > >             Project: TomEE
> > >          Issue Type: Sub-task
> > >          Components: Examples and Documentation
> > >            Reporter: Sherman Marshall
> > >            Priority: Minor
> > >
> > > Basic example of how to incorporate JAX-RS filters into an application.
> >
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v7.6.3#76005)
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: JAX-RS Filter Example (TOMEE-2485)

jgallimore
Not a problem, and thanks again for the submission - its a great example.
Just wanted to provide that feedback in case you wanted to tinker around
with that example a little more and send some more PRs :-).

Cheers!

Jon

On Mon, Mar 4, 2019 at 3:25 PM Sherman Marshall <
[hidden email]> wrote:

> Thanks Jon,
>
> I should have followed the naming convention, I will remember that for
> future submissions.
>
> I will have to read up on the build instructions a bit more, but I will
> make note to do that as well where applicable!
>
> Regards,
>
> Sherman
>
>
> On Mon, Mar 4, 2019, 2:31 AM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > I've merged this in - thanks for the PR!
> >
> > A couple of suggestions (none of them blocking):
> >
> > 1. I'd be tempted to rename this to something other than Servlet:
> >
> >
> https://github.com/apache/tomee/blob/64c2649966dad626d97725ebfaa66366e70d5ba6/examples/jaxrs-filter/src/main/java/org/superbiz/filterexample/ExampleServlet.java#L21
> > - just so its clear that its a JAX-RS endpoint and not a servlet.
> > 2. Try adding the TomEE Maven Plugin - that enables a "mvn tomee:run" to
> > boot TomEE and run your example. Hopefully that's as easy as adding this
> > plugin:
> >
> >       <plugin>
> >         <groupId>org.apache.tomee.maven</groupId>
> >         <artifactId>tomee-maven-plugin</artifactId>
> >         <version>8.0.0-SNAPSHOT</version>
> >         <configuration>
> >           <args>-Xmx512m -XX:PermSize=256m</args>
> >         </configuration>
> >       </plugin>
> >
> > 3. An Arquillian test would be great - slightly more involved than (2),
> but
> > we're happy to give some pointers to help.
> >
> > Cheers!
> >
> > Jon
> >
> > On Sun, Mar 3, 2019 at 4:14 PM Sherman Marshall (JIRA) <[hidden email]>
> > wrote:
> >
> > >
> > >      [
> > >
> >
> https://issues.apache.org/jira/browse/TOMEE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > ]
> > >
> > > Sherman Marshall updated TOMEE-2485:
> > > ------------------------------------
> > >     Issue Type: Sub-task  (was: New Feature)
> > >         Parent: TOMEE-2482
> > >
> > > > JAX-RS Filter Example
> > > > ---------------------
> > > >
> > > >                 Key: TOMEE-2485
> > > >                 URL:
> https://issues.apache.org/jira/browse/TOMEE-2485
> > > >             Project: TomEE
> > > >          Issue Type: Sub-task
> > > >          Components: Examples and Documentation
> > > >            Reporter: Sherman Marshall
> > > >            Priority: Minor
> > > >
> > > > Basic example of how to incorporate JAX-RS filters into an
> application.
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian JIRA
> > > (v7.6.3#76005)
> > >
> >
>