[GitHub] [tomee] tandraschko opened a new pull request #761: MyFaces 2.3.8

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] tandraschko opened a new pull request #761: MyFaces 2.3.8

GitBox

tandraschko opened a new pull request #761:
URL: https://github.com/apache/tomee/pull/761


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] tandraschko commented on pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox

tandraschko commented on pull request #761:
URL: https://github.com/apache/tomee/pull/761#issuecomment-773928770


   here we go :)
   https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12349324


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 commented on pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox
In reply to this post by GitBox

rzo1 commented on pull request #761:
URL: https://github.com/apache/tomee/pull/761#issuecomment-773929564


   Thanks. I included it in the JIRA: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&version=12349324


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 edited a comment on pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox
In reply to this post by GitBox

rzo1 edited a comment on pull request #761:
URL: https://github.com/apache/tomee/pull/761#issuecomment-773929564






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 edited a comment on pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox
In reply to this post by GitBox

rzo1 edited a comment on pull request #761:
URL: https://github.com/apache/tomee/pull/761#issuecomment-773929564


   Thanks. I included it in the JIRA.
   
   I just triggered a **re-run** of the PR build with tests to see, if something will break.
   
   Update:
   
   The PR build failed, but the related tests are working locally. So I think, it is not related to the PR itself. Thus, I will going to merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 merged pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox
In reply to this post by GitBox

rzo1 merged pull request #761:
URL: https://github.com/apache/tomee/pull/761


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cesarhernandezgt commented on pull request #761: TOMEE-2969 - Upgrade MyFaces to 2.3.8

GitBox
In reply to this post by GitBox

cesarhernandezgt commented on pull request #761:
URL: https://github.com/apache/tomee/pull/761#issuecomment-774275590


   Thanks for the PR @tandraschko and also the review from @Daniel-Dos and @rzo1
   
   Indeed the 4 (*) failing tests are related to the Jenkins CI node environment since the current master and this PR locally are green as a good apple :).
   
   [*]
   org.apache.openejb.AuthentWithRequestTest.invoke
   org.superbiz.calculator.CalculatorTest.remoteCallWithSslClient
   org.superbiz.calculator.CalculatorTest.testCalculatorViaWsInterfaceWithUsernameTokenPlainPasswordEncrypt
   org.superbiz.calculator.CalculatorTest.testCalculatorViaWsInterfaceWithSign


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]