[GitHub] [tomee] rzo1 opened a new pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 opened a new pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

GitBox

rzo1 opened a new pull request #762:
URL: https://github.com/apache/tomee/pull/762


   # What does this PR do?
   
   -  custom configured `MaxWait`, `TimeBetweenEvictionRunsMillis` and `MinEvictableIdleTimeMillis` properties for a datasource are **not** ignored when `TomEEDataSourceCreator` is used.
   - adds a unit test to reproduce the behaviour described in TOMEE-2125 (also affects 7.0.x, 7.1.x and 8.0.x - we might need to backport it)
   
   # References
   
   - https://issues.apache.org/jira/browse/TOMEE-2125
   - https://www.mail-archive.com/users@.../msg17591.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] jgallimore commented on pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

GitBox

jgallimore commented on pull request #762:
URL: https://github.com/apache/tomee/pull/762#issuecomment-778156707


   I think you're good to go ahead and commit that. Thanks @rzo1 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 commented on pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

GitBox
In reply to this post by GitBox

rzo1 commented on pull request #762:
URL: https://github.com/apache/tomee/pull/762#issuecomment-778163688


   Alright. I will also backport it to 7.0.x and 7.1.x


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 commented on pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

GitBox
In reply to this post by GitBox

rzo1 commented on pull request #762:
URL: https://github.com/apache/tomee/pull/762#issuecomment-778163763


   Thanks for the review @jgallimore


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 merged pull request #762: TOMEE-2125: Datasource Config: MaxWait, TimeBetweenEvictionRunsMillis and MinEvictableIdleTimeMillis are ignored

GitBox
In reply to this post by GitBox

rzo1 merged pull request #762:
URL: https://github.com/apache/tomee/pull/762


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]