[GitHub] tomee pull request #349: Some of the returned values are performance dependa...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #349: Some of the returned values are performance dependa...

cotnic
GitHub user doychin opened a pull request:

    https://github.com/apache/tomee/pull/349

    Some of the returned values are performance dependant - stddev

    This one is more complex as change. stdDev value in histogram depends on how fast values are added to the histogram on the server. In order to reuse existing expected values and filter the value that is not always the same, I've had to implement some parsing before comparing the returned string with expected string.
    In case you don't like it I'm open for suggestions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/doychin/tomee performance-dependant-values

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
   
----
commit ebb58300750026ed93f5501e392f5d31f88f4b03
Author: Doychin Bondzhev <doychin@...>
Date:   2019-01-02T12:51:13Z

    Some of the returned values are performance dependant - stddev for histogram
    This one is more complex as change. In order to reuse existing expected values and filter the value that is not always the same I've implemented some parsing before comparing the returned string with expected string.
    In case you don't like it I'm open for suggestions.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #349: Some of the returned values are performance dependant - st...

cotnic
Github user brunobat commented on the issue:

    https://github.com/apache/tomee/pull/349
 
    Hi @doychin.
    Thanks for the PR.
    Can you please resolve the conflict?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #349: Some of the returned values are performance dependant - st...

cotnic
In reply to this post by cotnic
Github user doychin commented on the issue:

    https://github.com/apache/tomee/pull/349
 
    Conflict was introduced by commit https://github.com/apache/tomee/commit/e7e80823b6014eb2e2a45d25234a5b661eeed8b1
   
    This commit also contains the fix I propose in #347.


---