[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
GitHub user otaviojava opened a pull request:

    https://github.com/apache/tomee/pull/283

    Tomee 2330 backport 7 0

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/otaviojava/tomee TOMEE-2330_backport_7_0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
   
----
commit 64337e7c97b0a6f3c74416a418b3eb2ef8bee426
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T11:51:18Z

    TOMEE-2295 test for <mapping-file> element being ignored

commit e97d3e966d3f05c941a90fad55bee0da5717e219
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T13:53:40Z

    TOMEE-2295 Improvements for JPA/CMP mapping

commit 87d837c5515b08f14403fea63186eb6535e936a9
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T20:00:45Z

    TOMEE-2295 PMD

commit 79c9dbb6b00dadfe1c26a69360676a4d5f88583a
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-29T10:21:24Z

    TOMEE-2295 use single class imports

commit 1b5b3c571c3a958084d73e38c4ccce9a28aa8970
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-29T21:43:40Z

    TOMEE-2295 add arquillian test using custom ORM file

commit 51893f4cabf21af6bbc2afc87de8945f1a3179a9
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-03T16:46:52Z

    TOMEE-2295 WIP - fails with a NullPointerException which I'm trying to track down

commit f210fdc5bae89b5819989c5911056edbaa6b4a2b
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-03T16:56:21Z

    TOMEE-2295 this is redundant

commit 69406e9c62c3ae9f84f1e6c005a5fa8cf3328a25
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:29:14Z

    TOMEE-2295 - ripping a lot of stuff out of this. Still not working.

commit 89b319ef81ff0ea206924e565f652cb618976a92
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:45:20Z

    TOMEE-2295 attempting something else

commit 758665d2a3d159fc622d52b4cf6da53455b80a3c
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:52:56Z

    Ripped everything out

commit 128a9c76ad8a749ae6e4073e670771a823b30612
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T10:57:42Z

    TOMEE-2295 working sample

commit 3647d2ce2e3c87a4148a1bfbfba9d8452d82a4d4
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T12:35:58Z

    Finals and formatting

commit 176b95d25e32bbf6d5ad33220b34e2624203bd10
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T13:55:47Z

    TOMEE-2295 add custom mapping back

commit a1de7ae7a8f06a0e15e18138b5abc33aeae800dd
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T14:55:40Z

    TOMEE-2295 check the correct database schema is in place

commit cfb51c45edd6cbb10e3528cd1a78dfc7bf4a1064
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T16:53:24Z

    TOMEE-2295 ensure this works across all profiles

commit 9946dfece763c81c4dbf3aab614d5eedb44596cb
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T21:56:49Z

    TOMEE-2295 fixing test

commit 68004b36d8140a822d69230362add911868683ba
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-10T14:16:43Z

    TOMEE-2330 fix issue with incorrect base URL for generated persistence units

commit fd73c7c967a2e1a2cedef0ffc245c05b0456ded6
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-16T12:39:20Z

    Add simple test to ensure overrides from openejb-cmp-orm.xml work

commit 29ab1f47719b4f63f12ccbc8dcc5df81aeddd6ab
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-16T15:06:17Z

    Adding further basic CMP tests

commit 2befcebab201e847923ae20da7e370d91d14c6b4
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-16T21:13:19Z

    defines a new umarshal, this time, not using the filter

commit f4ccf4ca12cc570668ede182f197befeb4ce45bf
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-19T11:34:03Z

    keeps the original behavior of the filter

commit 68e4acb93cf82a2fea8e263b506fd06cba26bab5
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-19T14:43:21Z

    adds entity and CMD test

commit d141a3705914df78328057faa78ce7b1962ba9ad
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-12-17T11:14:35Z

    fixes to Java 6

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #283: Tomee 2330 backport 7 0

cotnic
Github user brunobat commented on the issue:

    https://github.com/apache/tomee/pull/283
 
    I'm running a full build with Java 7


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242120895
 
    --- Diff: container/openejb-core/src/test/java/org/apache/openejb/core/webservices/JPACMDIntegrationTest.java ---
    @@ -0,0 +1,325 @@
    +package org.apache.openejb.core.webservices;
    --- End diff --
   
    This file is missing a header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121418
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyCmpBean.java ---
    @@ -0,0 +1,53 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121229
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyRemoteObject.java ---
    @@ -0,0 +1,9 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121288
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyLocalObject.java ---
    @@ -0,0 +1,7 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121257
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyRemoteHome.java ---
    @@ -0,0 +1,14 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121452
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/CmpServlet.java ---
    @@ -0,0 +1,30 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/283#discussion_r242121386
 
    --- Diff: arquillian/arquillian-tomee-tests/arquillian-tomee-webprofile-tests/src/test/java/org/apache/openejb/arquillian/tests/cmp/MyLocalHome.java ---
    @@ -0,0 +1,14 @@
    +package org.apache.openejb.arquillian.tests.cmp;
    --- End diff --
   
    Missing the Header


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user otaviojava commented on the issue:

    https://github.com/apache/tomee/pull/283
 
    @brunobat fixed


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user otaviojava closed the pull request at:

    https://github.com/apache/tomee/pull/283


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
GitHub user otaviojava reopened a pull request:

    https://github.com/apache/tomee/pull/283

    Tomee 2330 backport 7 0

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/otaviojava/tomee TOMEE-2330_backport_7_0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
   
----
commit 64337e7c97b0a6f3c74416a418b3eb2ef8bee426
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T11:51:18Z

    TOMEE-2295 test for <mapping-file> element being ignored

commit e97d3e966d3f05c941a90fad55bee0da5717e219
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T13:53:40Z

    TOMEE-2295 Improvements for JPA/CMP mapping

commit 87d837c5515b08f14403fea63186eb6535e936a9
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-28T20:00:45Z

    TOMEE-2295 PMD

commit 79c9dbb6b00dadfe1c26a69360676a4d5f88583a
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-29T10:21:24Z

    TOMEE-2295 use single class imports

commit 1b5b3c571c3a958084d73e38c4ccce9a28aa8970
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-29T21:43:40Z

    TOMEE-2295 add arquillian test using custom ORM file

commit 51893f4cabf21af6bbc2afc87de8945f1a3179a9
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-03T16:46:52Z

    TOMEE-2295 WIP - fails with a NullPointerException which I'm trying to track down

commit f210fdc5bae89b5819989c5911056edbaa6b4a2b
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-03T16:56:21Z

    TOMEE-2295 this is redundant

commit 69406e9c62c3ae9f84f1e6c005a5fa8cf3328a25
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:29:14Z

    TOMEE-2295 - ripping a lot of stuff out of this. Still not working.

commit 89b319ef81ff0ea206924e565f652cb618976a92
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:45:20Z

    TOMEE-2295 attempting something else

commit 758665d2a3d159fc622d52b4cf6da53455b80a3c
Author: Jonathan Gallimore <jon@...>
Date:   2018-12-04T14:52:56Z

    Ripped everything out

commit 128a9c76ad8a749ae6e4073e670771a823b30612
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T10:57:42Z

    TOMEE-2295 working sample

commit 3647d2ce2e3c87a4148a1bfbfba9d8452d82a4d4
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T12:35:58Z

    Finals and formatting

commit 176b95d25e32bbf6d5ad33220b34e2624203bd10
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T13:55:47Z

    TOMEE-2295 add custom mapping back

commit a1de7ae7a8f06a0e15e18138b5abc33aeae800dd
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T14:55:40Z

    TOMEE-2295 check the correct database schema is in place

commit cfb51c45edd6cbb10e3528cd1a78dfc7bf4a1064
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T16:53:24Z

    TOMEE-2295 ensure this works across all profiles

commit 9946dfece763c81c4dbf3aab614d5eedb44596cb
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-05T21:56:49Z

    TOMEE-2295 fixing test

commit 68004b36d8140a822d69230362add911868683ba
Author: Jonathan Gallimore <jgallimore@...>
Date:   2018-12-10T14:16:43Z

    TOMEE-2330 fix issue with incorrect base URL for generated persistence units

commit fd73c7c967a2e1a2cedef0ffc245c05b0456ded6
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-16T12:39:20Z

    Add simple test to ensure overrides from openejb-cmp-orm.xml work

commit 29ab1f47719b4f63f12ccbc8dcc5df81aeddd6ab
Author: Jonathan Gallimore <jon@...>
Date:   2018-11-16T15:06:17Z

    Adding further basic CMP tests

commit 2befcebab201e847923ae20da7e370d91d14c6b4
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-16T21:13:19Z

    defines a new umarshal, this time, not using the filter

commit f4ccf4ca12cc570668ede182f197befeb4ce45bf
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-19T11:34:03Z

    keeps the original behavior of the filter

commit 68e4acb93cf82a2fea8e263b506fd06cba26bab5
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-11-19T14:43:21Z

    adds entity and CMD test

commit d141a3705914df78328057faa78ce7b1962ba9ad
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-12-17T11:14:35Z

    fixes to Java 6

commit 7099ae6c9e068732a4f3d0df6b687ee1ac5d5ee3
Author: Otavio Santana <otaviopolianasantana@...>
Date:   2018-12-17T12:13:50Z

    adds header

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user brunobat commented on the issue:

    https://github.com/apache/tomee/pull/283
 
    The full build has some **unrelated** tests failing:
    MaxSizePoolEndpointHandlerTest.shouldSendMessage:109 expected:<30> but was:<1>
    AutoConnectionTrackerTest.test:207 expected:<1> but was:<0>
    [ERROR]   TomEECliIT.testTomEECliWithJar:79
    [ERROR]   TomEECliIT.testTomEECliWithJarCallingAnotherMain:174
    MessageDrivenBeanInterceptorInvocationTest>Arquillian.run:164->testMessageDrivenBeanMethodIntercepted:92 expected [true] but found [false]
   
    The build hanged on me after a while. Running again.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #283: Tomee 2330 backport 7 0

cotnic
In reply to this post by cotnic
Github user asfgit closed the pull request at:

    https://github.com/apache/tomee/pull/283


---
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] tomee pull request #283: Tomee 2330 backport 7 0

Otávio Gonçalves de Santana
Nice, please don't forget the backport to version 7.1.x

https://github.com/apache/tomee/pull/285


On Wed, Dec 19, 2018 at 7:53 PM asfgit <[hidden email]> wrote:

> Github user asfgit closed the pull request at:
>
>     https://github.com/apache/tomee/pull/283
>
>
> ---
>