[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
GitHub user brunobat opened a pull request:

    https://github.com/apache/tomee/pull/257

    TOMEE-2326 - Define description and rules to create new examples

    Signed-off-by: brunobat <[hidden email]>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brunobat/tomee examples-readme

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #257
   
----
commit e68d4a57f899cb01e04e043dd3b5976bc5eb956c
Author: brunobat <brunobat@...>
Date:   2018-12-06T13:40:11Z

    TOMEE-2326 - Define description and rules to create new examples
   
    Signed-off-by: brunobat <[hidden email]>

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
Github user jeanouii commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239478456
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    --- End diff --
   
    JEE should be Java EE
    JEE is not an authorized acronyme.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user jeanouii commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239478675
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    +developers in the creation of their own applications.
    +
    +The idea is that each example focuses in a very specific framework feature and
    +demonstrates it's usage and behaviour in a simple way.
    +
    +== Rules to create a new example.
    +
    +* Demo just one feaure with simple business logic.
    --- End diff --
   
    feaure --> feature


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user jeanouii commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239478563
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    +developers in the creation of their own applications.
    +
    +The idea is that each example focuses in a very specific framework feature and
    +demonstrates it's usage and behaviour in a simple way.
    --- End diff --
   
    it's --> its


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239482157
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    --- End diff --
   
    Thanks, Done


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239482263
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    +developers in the creation of their own applications.
    +
    +The idea is that each example focuses in a very specific framework feature and
    +demonstrates it's usage and behaviour in a simple way.
    --- End diff --
   
    thanks. Done


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/257#discussion_r239482358
 
    --- Diff: examples/README.adoc ---
    @@ -0,0 +1,21 @@
    += TomEE Examples
    +
    +These examples demonstrate particular features of the JEE ecosystem to help
    +developers in the creation of their own applications.
    +
    +The idea is that each example focuses in a very specific framework feature and
    +demonstrates it's usage and behaviour in a simple way.
    +
    +== Rules to create a new example.
    +
    +* Demo just one feaure with simple business logic.
    --- End diff --
   
    thanks. Done


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #257: TOMEE-2326 - Define description and rules to create new ex...

mpredli01
In reply to this post by mpredli01
Github user jeanouii commented on the issue:

    https://github.com/apache/tomee/pull/257
 
    Ok looks good. I'll merge it when my current build is done.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #257: TOMEE-2326 - Define description and rules to create...

mpredli01
In reply to this post by mpredli01
Github user asfgit closed the pull request at:

    https://github.com/apache/tomee/pull/257


---