[GitHub] tomee pull request #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not...

mpredli01
GitHub user danielsoro opened a pull request:

    https://github.com/apache/tomee/pull/236

     [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not working properly with Java 11

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielsoro/tomee tomee-7.0.x-2253-backport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #236
   
----
commit e5ad4b2d769aafc93f8817b23ddc55dea9327b1b
Author: Daniel Cunha (soro) <danielsoro@...>
Date:   2018-10-23T20:29:37Z

    TOMEE-2253 - tomee.sh -version not working properly with Java 11

commit 72740957235e31acfdc7672136da83035d23bd05
Author: Daniel Cunha (soro) <danielsoro@...>
Date:   2018-11-20T18:56:36Z

    Added test to call cli command from jaxrs

commit 232c246338a8b2b49c81e68b0eb822b23a361d03
Author: Daniel Cunha (soro) <danielsoro@...>
Date:   2018-11-26T13:07:02Z

    Test classloader change

commit 71702dc6bafb715b7a9f8bd8e36f9d33285a4af1
Author: Daniel Cunha (soro) <danielsoro@...>
Date:   2018-12-04T10:06:55Z

    No needed classpath override

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not workin...

mpredli01
Github user jeanouii commented on the issue:

    https://github.com/apache/tomee/pull/236
 
    @danielsoro can you please check if your branch was up to date with apache?
    Looks like I get a lot of conflicts when I try to merge this one
   
    Thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee issue #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not workin...

mpredli01
In reply to this post by mpredli01
Github user jeanouii commented on the issue:

    https://github.com/apache/tomee/pull/236
 
    @jgallimore Can you give it a try. I have no idea why it does not work for this one. I might I messed up with something.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #236: [BACKPORT 7.0.x] TOMEE-2253 - tomee.sh -version not...

mpredli01
In reply to this post by mpredli01
Github user asfgit closed the pull request at:

    https://github.com/apache/tomee/pull/236


---