[GitHub] tomee pull request #220: [WIP] TOMEE-2292 - Config Microprofile Example

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #220: [WIP] TOMEE-2292 - Config Microprofile Example

cotnic
GitHub user danielsoro opened a pull request:

    https://github.com/apache/tomee/pull/220

    [WIP] TOMEE-2292 - Config Microprofile Example

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielsoro/tomee mp-config-sample

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #220
   
----
commit 3ba14b8d86dd7d83667f6c33827c3cc42a44741b
Author: Daniel Cunha (soro) <danielsoro@...>
Date:   2018-11-26T14:45:15Z

    TOMEE-2292 - Config Microprofile Example

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #220: TOMEE-2292 - Config Microprofile Example

cotnic
Github user brunobat commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/220#discussion_r240168601
 
    --- Diff: examples/mp-config-example/pom.xml ---
    @@ -0,0 +1,72 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<project xmlns="http://maven.apache.org/POM/4.0.0"
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <parent>
    --- End diff --
   
    Hi Daniel,
    Thanks for your PR.
    Can you please make the example work without a Parent definition? Please check: https://github.com/apache/tomee/blob/master/examples/README.adoc


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] tomee pull request #220: TOMEE-2292 - Config Microprofile Example

cotnic
In reply to this post by cotnic
Github user asfgit closed the pull request at:

    https://github.com/apache/tomee/pull/220


---