[GitHub] [tomee] cocorossello opened a new pull request #776: TOMEE-2988: Xbean 4.18 + asm9

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cocorossello opened a new pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox

cocorossello opened a new pull request #776:
URL: https://github.com/apache/tomee/pull/776


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 commented on pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox

rzo1 commented on pull request #776:
URL: https://github.com/apache/tomee/pull/776#issuecomment-810179254


   @cesarhernandezgt Do you have an idea, why we lost the Jenkins PR builder checks for (newer) pull requests?


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 commented on a change in pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

rzo1 commented on a change in pull request #776:
URL: https://github.com/apache/tomee/pull/776#discussion_r605572170



##########
File path: container/openejb-core/pom.xml
##########
@@ -562,11 +562,31 @@
     <!-- End: JavaMail -->
     <dependency>
       <groupId>org.apache.xbean</groupId>
-      <artifactId>xbean-asm7-shaded</artifactId>
+      <artifactId>xbean-asm9-shaded</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>org.ow2.asm</groupId>
+          <artifactId>asm</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.ow2.asm</groupId>
+          <artifactId>asm-commons</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.xbean</groupId>
       <artifactId>xbean-finder-shaded</artifactId>
+      <exclusions>

Review comment:
       see above

##########
File path: arquillian/arquillian-tomee-common/pom.xml
##########
@@ -86,6 +86,16 @@
       <artifactId>xbean-finder-shaded</artifactId>
       <version>${xbeanVersion}</version>
       <scope>provided</scope>
+      <exclusions>

Review comment:
       I am wondering:
   
   Is this needed?  Afaik [xbean-finder-shaded](https://mvnrepository.com/artifact/org.apache.xbean/xbean-finder-shaded/4.18) only has a compile dependency towards `xbean-asm9-shaded`. The `org.ow2.asm` stuff is a transient dependency of `xbean-asm9-shaded`. So shouldn't we exclude  `xbean-asm9-shaded` here as it comes from `openwebbeans` anyway?
   




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rmannibucau commented on a change in pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

rmannibucau commented on a change in pull request #776:
URL: https://github.com/apache/tomee/pull/776#discussion_r605586552



##########
File path: arquillian/arquillian-tomee-common/pom.xml
##########
@@ -86,6 +86,16 @@
       <artifactId>xbean-finder-shaded</artifactId>
       <version>${xbeanVersion}</version>
       <scope>provided</scope>
+      <exclusions>

Review comment:
       ow2 deps should be excluded in root pom in dependency management of xbean-asm9-shaded dependency declaration to ensure the whole tree gets it for free.




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 edited a comment on pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

rzo1 edited a comment on pull request #776:
URL: https://github.com/apache/tomee/pull/776#issuecomment-810179254


   @cesarhernandezgt Do you have an idea, why we lost the Jenkins PR builder checks for (newer) pull requests?
   
   EDIT: seems to be back again for newer PRs.


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cocorossello commented on a change in pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

cocorossello commented on a change in pull request #776:
URL: https://github.com/apache/tomee/pull/776#discussion_r605976022



##########
File path: arquillian/arquillian-tomee-common/pom.xml
##########
@@ -86,6 +86,16 @@
       <artifactId>xbean-finder-shaded</artifactId>
       <version>${xbeanVersion}</version>
       <scope>provided</scope>
+      <exclusions>

Review comment:
       Ok, let me change it tomorrow. Thanks for the hint, didn't really now where to exclude or if all exclusions were needed




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cocorossello commented on a change in pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

cocorossello commented on a change in pull request #776:
URL: https://github.com/apache/tomee/pull/776#discussion_r606112237



##########
File path: arquillian/arquillian-tomee-common/pom.xml
##########
@@ -86,6 +86,16 @@
       <artifactId>xbean-finder-shaded</artifactId>
       <version>${xbeanVersion}</version>
       <scope>provided</scope>
+      <exclusions>

Review comment:
       Changed it, only that exclusion is enough




--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] rzo1 merged pull request #776: TOMEE-2988: Xbean 4.18 + asm9

GitBox
In reply to this post by GitBox

rzo1 merged pull request #776:
URL: https://github.com/apache/tomee/pull/776


   


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]