[GitHub] [tomee] cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl

GitBox
cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl
URL: https://github.com/apache/tomee/pull/613#issuecomment-558222651
 
 
   Hi,
   
   In the code acl.Group is used basically as a Principal with members support, is not used as a Policy, as far as I can see.
   
   With this change our environment works  in jdk11, 12, 13 and 14, I don't see any reason why it wouldn't work in jdk8 (but of course I don't know all the use cases here).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] [tomee] cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility: remove usage of javax.security.acl

Richard Monson-Haefel
I think the nightly CI uses Java 8, isn't that right, @Jonathan Gallimore
<[hidden email]> ?  So if its passing can we assume that the PR
is good to go?

On Mon, Nov 25, 2019 at 10:04 AM GitBox <[hidden email]> wrote:

> cocorossello commented on issue #613: TOMEE-2744: JD14 compatibility:
> remove usage of javax.security.acl
> URL: https://github.com/apache/tomee/pull/613#issuecomment-558222651
>
>
>    Hi,
>
>    In the code acl.Group is used basically as a Principal with members
> support, is not used as a Policy, as far as I can see.
>
>    With this change our environment works  in jdk11, 12, 13 and 14, I
> don't see any reason why it wouldn't work in jdk8 (but of course I don't
> know all the use cases here).
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> [hidden email]
>
>
> With regards,
> Apache Git Services
>


--
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/