[GitHub] [tomee] cesarhernandezgt commented on pull request #752: TOMEE-2960 added basic github actions for tomee-7.1.x branch

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tomee] cesarhernandezgt commented on pull request #752: TOMEE-2960 added basic github actions for tomee-7.1.x branch

GitBox

cesarhernandezgt commented on pull request #752:
URL: https://github.com/apache/tomee/pull/752#issuecomment-764978908


   > On the `master`, we define an additional step
   >
   > ```
   >     steps:
   >     - uses: actions/checkout@v2
   >     - name: Set up JDK 1.8
   >       uses: actions/setup-java@v1
   >       with:
   >         java-version: '8'
   > ```
   >
   > to create a `tmp` directory and set it in the subsequent steps as `java.io.tmpdir`.
   >
   > **Question:**
   >
   > * Do we need it here too?
   > * Should we align the `master` workflow with this changes too? Separating the steps seems reasonable to me.
   
   Really good questions @rzo1 .
   The `tmp` directory in the github action I created on master was basically inherited form what I saw on buildbot: https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1426
   
   > * Do we need it here too?
   I think we don't need it. My understanding is this was required in buildbot but now we are not using it on Jenkins and I don't think we need it on Github Actions.
   
   > * Should we align the `master` workflow with this changes too?
   Yes, I think we should remove this from master: https://github.com/apache/tomee/blob/master/.github/workflows/main.yml#L23-L24
   
   > Separating the steps seems reasonable to me.
   I like it too, I'm familiar with Jenkins pipelines, and having the ability to see specific step when something went wrong is easier than trying to search within a unique file with a lot of data. To implement this approach on master will require to double-check the result we currently have when executing the profile created a couple of weeks ago that has been useful for TCK related work: -Pstyle,rat
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]