Fixing TomEE 7.1.x Build

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

Fixing TomEE 7.1.x Build

Daniel Cunha-2
Hi folks,

I opened a PR to fix the build for tomee-7.1.x branch: https://github.com/apache/tomee/pull/450
Please review it.

That is the current status for that branch:



--
Daniel "soro" Cunha

Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

jgallimore
Merged - thanks for sending that over!

Jon

On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[hidden email]> wrote:

> Hi folks,
>
> I opened a PR to fix the build for tomee-7.1.x branch:
> https://github.com/apache/tomee/pull/450
> Please review it.
>
> That is the current status for that branch:
>
> [image: Screenshot from 2019-03-22 09-18-24.png]
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
I'll keep my eyes on the buildbot. :)

Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
[hidden email]> escreveu:

> Merged - thanks for sending that over!
>
> Jon
>
> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[hidden email]>
> wrote:
>
> > Hi folks,
> >
> > I opened a PR to fix the build for tomee-7.1.x branch:
> > https://github.com/apache/tomee/pull/450
> > Please review it.
> >
> > That is the current status for that branch:
> >
> > [image: Screenshot from 2019-03-22 09-18-24.png]
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
> >
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Thanks for review it and merge Jon.

Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <[hidden email]>
escreveu:

> I'll keep my eyes on the buildbot. :)
>
> Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> [hidden email]> escreveu:
>
>> Merged - thanks for sending that over!
>>
>> Jon
>>
>> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[hidden email]>
>> wrote:
>>
>> > Hi folks,
>> >
>> > I opened a PR to fix the build for tomee-7.1.x branch:
>> > https://github.com/apache/tomee/pull/450
>> > Please review it.
>> >
>> > That is the current status for that branch:
>> >
>> > [image: Screenshot from 2019-03-22 09-18-24.png]
>> >
>> >
>> > --
>> > Daniel "soro" Cunha
>> > https://twitter.com/dvlc_
>> >
>> >
>>
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Gurkan Erdogdu-5
Hi
As a general idea:
I advise to attach a JIRA issue for each commit. Otherwise, the community
are not able to follow the commits and their exact reasons.
Regards.
Gurkan

On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]> wrote:

> Thanks for review it and merge Jon.
>
> Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <[hidden email]>
> escreveu:
>
> > I'll keep my eyes on the buildbot. :)
> >
> > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> > [hidden email]> escreveu:
> >
> >> Merged - thanks for sending that over!
> >>
> >> Jon
> >>
> >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[hidden email]>
> >> wrote:
> >>
> >> > Hi folks,
> >> >
> >> > I opened a PR to fix the build for tomee-7.1.x branch:
> >> > https://github.com/apache/tomee/pull/450
> >> > Please review it.
> >> >
> >> > That is the current status for that branch:
> >> >
> >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> >> >
> >> >
> >> > --
> >> > Daniel "soro" Cunha
> >> > https://twitter.com/dvlc_
> >> >
> >> >
> >>
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Hi Gurkan,

You right! My fault from my last two Pull Request.
I'll work to it not happenings again.

Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <[hidden email]>
escreveu:

> Hi
> As a general idea:
> I advise to attach a JIRA issue for each commit. Otherwise, the community
> are not able to follow the commits and their exact reasons.
> Regards.
> Gurkan
>
> On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]>
> wrote:
>
> > Thanks for review it and merge Jon.
> >
> > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <[hidden email]>
> > escreveu:
> >
> > > I'll keep my eyes on the buildbot. :)
> > >
> > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> > > [hidden email]> escreveu:
> > >
> > >> Merged - thanks for sending that over!
> > >>
> > >> Jon
> > >>
> > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <[hidden email]>
> > >> wrote:
> > >>
> > >> > Hi folks,
> > >> >
> > >> > I opened a PR to fix the build for tomee-7.1.x branch:
> > >> > https://github.com/apache/tomee/pull/450
> > >> > Please review it.
> > >> >
> > >> > That is the current status for that branch:
> > >> >
> > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> > >> >
> > >> >
> > >> > --
> > >> > Daniel "soro" Cunha
> > >> > https://twitter.com/dvlc_
> > >> >
> > >> >
> > >>
> > >
> > >
> > > --
> > > Daniel "soro" Cunha
> > > https://twitter.com/dvlc_
> > >
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Gurkan Erdogdu-5
Cool, thank you!

On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]> wrote:

> Hi Gurkan,
>
> You right! My fault from my last two Pull Request.
> I'll work to it not happenings again.
>
> Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <[hidden email]>
> escreveu:
>
> > Hi
> > As a general idea:
> > I advise to attach a JIRA issue for each commit. Otherwise, the community
> > are not able to follow the commits and their exact reasons.
> > Regards.
> > Gurkan
> >
> > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]>
> > wrote:
> >
> > > Thanks for review it and merge Jon.
> > >
> > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
> [hidden email]>
> > > escreveu:
> > >
> > > > I'll keep my eyes on the buildbot. :)
> > > >
> > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> > > > [hidden email]> escreveu:
> > > >
> > > >> Merged - thanks for sending that over!
> > > >>
> > > >> Jon
> > > >>
> > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
> [hidden email]>
> > > >> wrote:
> > > >>
> > > >> > Hi folks,
> > > >> >
> > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
> > > >> > https://github.com/apache/tomee/pull/450
> > > >> > Please review it.
> > > >> >
> > > >> > That is the current status for that branch:
> > > >> >
> > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> > > >> >
> > > >> >
> > > >> > --
> > > >> > Daniel "soro" Cunha
> > > >> > https://twitter.com/dvlc_
> > > >> >
> > > >> >
> > > >>
> > > >
> > > >
> > > > --
> > > > Daniel "soro" Cunha
> > > > https://twitter.com/dvlc_
> > > >
> > >
> > >
> > > --
> > > Daniel "soro" Cunha
> > > https://twitter.com/dvlc_
> > >
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Well,

Seems that we still have a module with test failing!
Investigating what is it. It build well yesterday here. :)

https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
[ERROR] Please refer to
/home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
for the individual test results.

Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <[hidden email]>
escreveu:

> Cool, thank you!
>
> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]>
> wrote:
>
> > Hi Gurkan,
> >
> > You right! My fault from my last two Pull Request.
> > I'll work to it not happenings again.
> >
> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <[hidden email]>
> > escreveu:
> >
> > > Hi
> > > As a general idea:
> > > I advise to attach a JIRA issue for each commit. Otherwise, the
> community
> > > are not able to follow the commits and their exact reasons.
> > > Regards.
> > > Gurkan
> > >
> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]>
> > > wrote:
> > >
> > > > Thanks for review it and merge Jon.
> > > >
> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
> > [hidden email]>
> > > > escreveu:
> > > >
> > > > > I'll keep my eyes on the buildbot. :)
> > > > >
> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> > > > > [hidden email]> escreveu:
> > > > >
> > > > >> Merged - thanks for sending that over!
> > > > >>
> > > > >> Jon
> > > > >>
> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
> > [hidden email]>
> > > > >> wrote:
> > > > >>
> > > > >> > Hi folks,
> > > > >> >
> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
> > > > >> > https://github.com/apache/tomee/pull/450
> > > > >> > Please review it.
> > > > >> >
> > > > >> > That is the current status for that branch:
> > > > >> >
> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> > > > >> >
> > > > >> >
> > > > >> > --
> > > > >> > Daniel "soro" Cunha
> > > > >> > https://twitter.com/dvlc_
> > > > >> >
> > > > >> >
> > > > >>
> > > > >
> > > > >
> > > > > --
> > > > > Daniel "soro" Cunha
> > > > > https://twitter.com/dvlc_
> > > > >
> > > >
> > > >
> > > > --
> > > > Daniel "soro" Cunha
> > > > https://twitter.com/dvlc_
> > > >
> > >
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Bit stuck with those tests:

Failed tests:
  ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected [500]
but found [200]
  SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but
found [200]

For some reason I can't debug it. That is the two tests is failing on
MicroProfile JWT TCK for TomEE 7.1.x.
(I'm asking for help)


Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <[hidden email]>
escreveu:

> Well,
>
> Seems that we still have a module with test failing!
> Investigating what is it. It build well yesterday here. :)
>
> https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
> [ERROR] Please refer to
> /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
> for the individual test results.
>
> Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <[hidden email]>
> escreveu:
>
>> Cool, thank you!
>>
>> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]>
>> wrote:
>>
>> > Hi Gurkan,
>> >
>> > You right! My fault from my last two Pull Request.
>> > I'll work to it not happenings again.
>> >
>> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <[hidden email]
>> >
>> > escreveu:
>> >
>> > > Hi
>> > > As a general idea:
>> > > I advise to attach a JIRA issue for each commit. Otherwise, the
>> community
>> > > are not able to follow the commits and their exact reasons.
>> > > Regards.
>> > > Gurkan
>> > >
>> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]>
>> > > wrote:
>> > >
>> > > > Thanks for review it and merge Jon.
>> > > >
>> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
>> > [hidden email]>
>> > > > escreveu:
>> > > >
>> > > > > I'll keep my eyes on the buildbot. :)
>> > > > >
>> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
>> > > > > [hidden email]> escreveu:
>> > > > >
>> > > > >> Merged - thanks for sending that over!
>> > > > >>
>> > > > >> Jon
>> > > > >>
>> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
>> > [hidden email]>
>> > > > >> wrote:
>> > > > >>
>> > > > >> > Hi folks,
>> > > > >> >
>> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
>> > > > >> > https://github.com/apache/tomee/pull/450
>> > > > >> > Please review it.
>> > > > >> >
>> > > > >> > That is the current status for that branch:
>> > > > >> >
>> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
>> > > > >> >
>> > > > >> >
>> > > > >> > --
>> > > > >> > Daniel "soro" Cunha
>> > > > >> > https://twitter.com/dvlc_
>> > > > >> >
>> > > > >> >
>> > > > >>
>> > > > >
>> > > > >
>> > > > > --
>> > > > > Daniel "soro" Cunha
>> > > > > https://twitter.com/dvlc_
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > Daniel "soro" Cunha
>> > > > https://twitter.com/dvlc_
>> > > >
>> > >
>> >
>> >
>> > --
>> > Daniel "soro" Cunha
>> > https://twitter.com/dvlc_
>> >
>>
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

jgallimore
These ring a bell. I think I have a fix for them - I'll check.

Jon

On Sat, Mar 23, 2019 at 2:11 PM Daniel Cunha <[hidden email]> wrote:

> Bit stuck with those tests:
>
> Failed tests:
>   ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected [500]
> but found [200]
>   SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but
> found [200]
>
> For some reason I can't debug it. That is the two tests is failing on
> MicroProfile JWT TCK for TomEE 7.1.x.
> (I'm asking for help)
>
>
> Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <[hidden email]>
> escreveu:
>
> > Well,
> >
> > Seems that we still have a module with test failing!
> > Investigating what is it. It build well yesterday here. :)
> >
> > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
> > [ERROR] Please refer to
> >
> /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
> > for the individual test results.
> >
> > Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <[hidden email]>
> > escreveu:
> >
> >> Cool, thank you!
> >>
> >> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]>
> >> wrote:
> >>
> >> > Hi Gurkan,
> >> >
> >> > You right! My fault from my last two Pull Request.
> >> > I'll work to it not happenings again.
> >> >
> >> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <
> [hidden email]
> >> >
> >> > escreveu:
> >> >
> >> > > Hi
> >> > > As a general idea:
> >> > > I advise to attach a JIRA issue for each commit. Otherwise, the
> >> community
> >> > > are not able to follow the commits and their exact reasons.
> >> > > Regards.
> >> > > Gurkan
> >> > >
> >> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <[hidden email]
> >
> >> > > wrote:
> >> > >
> >> > > > Thanks for review it and merge Jon.
> >> > > >
> >> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
> >> > [hidden email]>
> >> > > > escreveu:
> >> > > >
> >> > > > > I'll keep my eyes on the buildbot. :)
> >> > > > >
> >> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> >> > > > > [hidden email]> escreveu:
> >> > > > >
> >> > > > >> Merged - thanks for sending that over!
> >> > > > >>
> >> > > > >> Jon
> >> > > > >>
> >> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
> >> > [hidden email]>
> >> > > > >> wrote:
> >> > > > >>
> >> > > > >> > Hi folks,
> >> > > > >> >
> >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
> >> > > > >> > https://github.com/apache/tomee/pull/450
> >> > > > >> > Please review it.
> >> > > > >> >
> >> > > > >> > That is the current status for that branch:
> >> > > > >> >
> >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> >> > > > >> >
> >> > > > >> >
> >> > > > >> > --
> >> > > > >> > Daniel "soro" Cunha
> >> > > > >> > https://twitter.com/dvlc_
> >> > > > >> >
> >> > > > >> >
> >> > > > >>
> >> > > > >
> >> > > > >
> >> > > > > --
> >> > > > > Daniel "soro" Cunha
> >> > > > > https://twitter.com/dvlc_
> >> > > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Daniel "soro" Cunha
> >> > > > https://twitter.com/dvlc_
> >> > > >
> >> > >
> >> >
> >> >
> >> > --
> >> > Daniel "soro" Cunha
> >> > https://twitter.com/dvlc_
> >> >
> >>
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
> >
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

jgallimore
Changes pushed and its building:
https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/48

On Sun, Mar 24, 2019 at 9:46 AM Jonathan Gallimore <
[hidden email]> wrote:

> These ring a bell. I think I have a fix for them - I'll check.
>
> Jon
>
> On Sat, Mar 23, 2019 at 2:11 PM Daniel Cunha <[hidden email]>
> wrote:
>
>> Bit stuck with those tests:
>>
>> Failed tests:
>>   ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected
>> [500]
>> but found [200]
>>   SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but
>> found [200]
>>
>> For some reason I can't debug it. That is the two tests is failing on
>> MicroProfile JWT TCK for TomEE 7.1.x.
>> (I'm asking for help)
>>
>>
>> Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <[hidden email]>
>> escreveu:
>>
>> > Well,
>> >
>> > Seems that we still have a module with test failing!
>> > Investigating what is it. It build well yesterday here. :)
>> >
>> > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
>> > [ERROR] Please refer to
>> >
>> /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
>> > for the individual test results.
>> >
>> > Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <[hidden email]
>> >
>> > escreveu:
>> >
>> >> Cool, thank you!
>> >>
>> >> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]>
>> >> wrote:
>> >>
>> >> > Hi Gurkan,
>> >> >
>> >> > You right! My fault from my last two Pull Request.
>> >> > I'll work to it not happenings again.
>> >> >
>> >> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <
>> [hidden email]
>> >> >
>> >> > escreveu:
>> >> >
>> >> > > Hi
>> >> > > As a general idea:
>> >> > > I advise to attach a JIRA issue for each commit. Otherwise, the
>> >> community
>> >> > > are not able to follow the commits and their exact reasons.
>> >> > > Regards.
>> >> > > Gurkan
>> >> > >
>> >> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <
>> [hidden email]>
>> >> > > wrote:
>> >> > >
>> >> > > > Thanks for review it and merge Jon.
>> >> > > >
>> >> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
>> >> > [hidden email]>
>> >> > > > escreveu:
>> >> > > >
>> >> > > > > I'll keep my eyes on the buildbot. :)
>> >> > > > >
>> >> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
>> >> > > > > [hidden email]> escreveu:
>> >> > > > >
>> >> > > > >> Merged - thanks for sending that over!
>> >> > > > >>
>> >> > > > >> Jon
>> >> > > > >>
>> >> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
>> >> > [hidden email]>
>> >> > > > >> wrote:
>> >> > > > >>
>> >> > > > >> > Hi folks,
>> >> > > > >> >
>> >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
>> >> > > > >> > https://github.com/apache/tomee/pull/450
>> >> > > > >> > Please review it.
>> >> > > > >> >
>> >> > > > >> > That is the current status for that branch:
>> >> > > > >> >
>> >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
>> >> > > > >> >
>> >> > > > >> >
>> >> > > > >> > --
>> >> > > > >> > Daniel "soro" Cunha
>> >> > > > >> > https://twitter.com/dvlc_
>> >> > > > >> >
>> >> > > > >> >
>> >> > > > >>
>> >> > > > >
>> >> > > > >
>> >> > > > > --
>> >> > > > > Daniel "soro" Cunha
>> >> > > > > https://twitter.com/dvlc_
>> >> > > > >
>> >> > > >
>> >> > > >
>> >> > > > --
>> >> > > > Daniel "soro" Cunha
>> >> > > > https://twitter.com/dvlc_
>> >> > > >
>> >> > >
>> >> >
>> >> >
>> >> > --
>> >> > Daniel "soro" Cunha
>> >> > https://twitter.com/dvlc_
>> >> >
>> >>
>> >
>> >
>> > --
>> > Daniel "soro" Cunha
>> > https://twitter.com/dvlc_
>> >
>>
>>
>> --
>> Daniel "soro" Cunha
>> https://twitter.com/dvlc_
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Thank you Jon! :)

Em dom, 24 de mar de 2019 às 11:07, Jonathan Gallimore <
[hidden email]> escreveu:

> Changes pushed and its building:
> https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/48
>
> On Sun, Mar 24, 2019 at 9:46 AM Jonathan Gallimore <
> [hidden email]> wrote:
>
> > These ring a bell. I think I have a fix for them - I'll check.
> >
> > Jon
> >
> > On Sat, Mar 23, 2019 at 2:11 PM Daniel Cunha <[hidden email]>
> > wrote:
> >
> >> Bit stuck with those tests:
> >>
> >> Failed tests:
> >>   ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected
> >> [500]
> >> but found [200]
> >>   SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but
> >> found [200]
> >>
> >> For some reason I can't debug it. That is the two tests is failing on
> >> MicroProfile JWT TCK for TomEE 7.1.x.
> >> (I'm asking for help)
> >>
> >>
> >> Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <[hidden email]
> >
> >> escreveu:
> >>
> >> > Well,
> >> >
> >> > Seems that we still have a module with test failing!
> >> > Investigating what is it. It build well yesterday here. :)
> >> >
> >> > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
> >> > [ERROR] Please refer to
> >> >
> >>
> /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
> >> > for the individual test results.
> >> >
> >> > Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <
> [hidden email]
> >> >
> >> > escreveu:
> >> >
> >> >> Cool, thank you!
> >> >>
> >> >> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]>
> >> >> wrote:
> >> >>
> >> >> > Hi Gurkan,
> >> >> >
> >> >> > You right! My fault from my last two Pull Request.
> >> >> > I'll work to it not happenings again.
> >> >> >
> >> >> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <
> >> [hidden email]
> >> >> >
> >> >> > escreveu:
> >> >> >
> >> >> > > Hi
> >> >> > > As a general idea:
> >> >> > > I advise to attach a JIRA issue for each commit. Otherwise, the
> >> >> community
> >> >> > > are not able to follow the commits and their exact reasons.
> >> >> > > Regards.
> >> >> > > Gurkan
> >> >> > >
> >> >> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <
> >> [hidden email]>
> >> >> > > wrote:
> >> >> > >
> >> >> > > > Thanks for review it and merge Jon.
> >> >> > > >
> >> >> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
> >> >> > [hidden email]>
> >> >> > > > escreveu:
> >> >> > > >
> >> >> > > > > I'll keep my eyes on the buildbot. :)
> >> >> > > > >
> >> >> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
> >> >> > > > > [hidden email]> escreveu:
> >> >> > > > >
> >> >> > > > >> Merged - thanks for sending that over!
> >> >> > > > >>
> >> >> > > > >> Jon
> >> >> > > > >>
> >> >> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
> >> >> > [hidden email]>
> >> >> > > > >> wrote:
> >> >> > > > >>
> >> >> > > > >> > Hi folks,
> >> >> > > > >> >
> >> >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
> >> >> > > > >> > https://github.com/apache/tomee/pull/450
> >> >> > > > >> > Please review it.
> >> >> > > > >> >
> >> >> > > > >> > That is the current status for that branch:
> >> >> > > > >> >
> >> >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
> >> >> > > > >> >
> >> >> > > > >> >
> >> >> > > > >> > --
> >> >> > > > >> > Daniel "soro" Cunha
> >> >> > > > >> > https://twitter.com/dvlc_
> >> >> > > > >> >
> >> >> > > > >> >
> >> >> > > > >>
> >> >> > > > >
> >> >> > > > >
> >> >> > > > > --
> >> >> > > > > Daniel "soro" Cunha
> >> >> > > > > https://twitter.com/dvlc_
> >> >> > > > >
> >> >> > > >
> >> >> > > >
> >> >> > > > --
> >> >> > > > Daniel "soro" Cunha
> >> >> > > > https://twitter.com/dvlc_
> >> >> > > >
> >> >> > >
> >> >> >
> >> >> >
> >> >> > --
> >> >> > Daniel "soro" Cunha
> >> >> > https://twitter.com/dvlc_
> >> >> >
> >> >>
> >> >
> >> >
> >> > --
> >> > Daniel "soro" Cunha
> >> > https://twitter.com/dvlc_
> >> >
> >>
> >>
> >> --
> >> Daniel "soro" Cunha
> >> https://twitter.com/dvlc_
> >>
> >
>


--
Daniel "soro" Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|

Re: Fixing TomEE 7.1.x Build

Daniel Cunha-2
Build fixed. Thank you Jon! :)

On Sun, Mar 24, 2019, 11:10 AM Daniel Cunha <[hidden email]> wrote:

> Thank you Jon! :)
>
> Em dom, 24 de mar de 2019 às 11:07, Jonathan Gallimore <
> [hidden email]> escreveu:
>
>> Changes pushed and its building:
>> https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/48
>>
>> On Sun, Mar 24, 2019 at 9:46 AM Jonathan Gallimore <
>> [hidden email]> wrote:
>>
>> > These ring a bell. I think I have a fix for them - I'll check.
>> >
>> > Jon
>> >
>> > On Sat, Mar 23, 2019 at 2:11 PM Daniel Cunha <[hidden email]>
>> > wrote:
>> >
>> >> Bit stuck with those tests:
>> >>
>> >> Failed tests:
>> >>   ServletTest>Arquillian.run:164->getServletSubjectClass:119 expected
>> >> [500]
>> >> but found [200]
>> >>   SubjectTest>Arquillian.run:164->getSubjectClass:94 expected [500] but
>> >> found [200]
>> >>
>> >> For some reason I can't debug it. That is the two tests is failing on
>> >> MicroProfile JWT TCK for TomEE 7.1.x.
>> >> (I'm asking for help)
>> >>
>> >>
>> >> Em sex, 22 de mar de 2019 às 12:59, Daniel Cunha <
>> [hidden email]>
>> >> escreveu:
>> >>
>> >> > Well,
>> >> >
>> >> > Seems that we still have a module with test failing!
>> >> > Investigating what is it. It build well yesterday here. :)
>> >> >
>> >> > https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8/builds/47
>> >> > [ERROR] Please refer to
>> >> >
>> >>
>> /home/buildslave/slave/tomee-7.1.x-ubuntu-jvm8/build/tck/microprofile-tck/jwt/target/surefire-reports
>> >> > for the individual test results.
>> >> >
>> >> > Em sex, 22 de mar de 2019 às 12:56, Gurkan Erdogdu <
>> [hidden email]
>> >> >
>> >> > escreveu:
>> >> >
>> >> >> Cool, thank you!
>> >> >>
>> >> >> On Fri, Mar 22, 2019 at 6:56 PM Daniel Cunha <[hidden email]
>> >
>> >> >> wrote:
>> >> >>
>> >> >> > Hi Gurkan,
>> >> >> >
>> >> >> > You right! My fault from my last two Pull Request.
>> >> >> > I'll work to it not happenings again.
>> >> >> >
>> >> >> > Em sex, 22 de mar de 2019 às 12:52, Gurkan Erdogdu <
>> >> [hidden email]
>> >> >> >
>> >> >> > escreveu:
>> >> >> >
>> >> >> > > Hi
>> >> >> > > As a general idea:
>> >> >> > > I advise to attach a JIRA issue for each commit. Otherwise, the
>> >> >> community
>> >> >> > > are not able to follow the commits and their exact reasons.
>> >> >> > > Regards.
>> >> >> > > Gurkan
>> >> >> > >
>> >> >> > > On Fri, Mar 22, 2019 at 5:41 PM Daniel Cunha <
>> >> [hidden email]>
>> >> >> > > wrote:
>> >> >> > >
>> >> >> > > > Thanks for review it and merge Jon.
>> >> >> > > >
>> >> >> > > > Em sex, 22 de mar de 2019 às 11:41, Daniel Cunha <
>> >> >> > [hidden email]>
>> >> >> > > > escreveu:
>> >> >> > > >
>> >> >> > > > > I'll keep my eyes on the buildbot. :)
>> >> >> > > > >
>> >> >> > > > > Em sex, 22 de mar de 2019 às 11:34, Jonathan Gallimore <
>> >> >> > > > > [hidden email]> escreveu:
>> >> >> > > > >
>> >> >> > > > >> Merged - thanks for sending that over!
>> >> >> > > > >>
>> >> >> > > > >> Jon
>> >> >> > > > >>
>> >> >> > > > >> On Fri, Mar 22, 2019 at 12:20 PM Daniel Cunha <
>> >> >> > [hidden email]>
>> >> >> > > > >> wrote:
>> >> >> > > > >>
>> >> >> > > > >> > Hi folks,
>> >> >> > > > >> >
>> >> >> > > > >> > I opened a PR to fix the build for tomee-7.1.x branch:
>> >> >> > > > >> > https://github.com/apache/tomee/pull/450
>> >> >> > > > >> > Please review it.
>> >> >> > > > >> >
>> >> >> > > > >> > That is the current status for that branch:
>> >> >> > > > >> >
>> >> >> > > > >> > [image: Screenshot from 2019-03-22 09-18-24.png]
>> >> >> > > > >> >
>> >> >> > > > >> >
>> >> >> > > > >> > --
>> >> >> > > > >> > Daniel "soro" Cunha
>> >> >> > > > >> > https://twitter.com/dvlc_
>> >> >> > > > >> >
>> >> >> > > > >> >
>> >> >> > > > >>
>> >> >> > > > >
>> >> >> > > > >
>> >> >> > > > > --
>> >> >> > > > > Daniel "soro" Cunha
>> >> >> > > > > https://twitter.com/dvlc_
>> >> >> > > > >
>> >> >> > > >
>> >> >> > > >
>> >> >> > > > --
>> >> >> > > > Daniel "soro" Cunha
>> >> >> > > > https://twitter.com/dvlc_
>> >> >> > > >
>> >> >> > >
>> >> >> >
>> >> >> >
>> >> >> > --
>> >> >> > Daniel "soro" Cunha
>> >> >> > https://twitter.com/dvlc_
>> >> >> >
>> >> >>
>> >> >
>> >> >
>> >> > --
>> >> > Daniel "soro" Cunha
>> >> > https://twitter.com/dvlc_
>> >> >
>> >>
>> >>
>> >> --
>> >> Daniel "soro" Cunha
>> >> https://twitter.com/dvlc_
>> >>
>> >
>>
>
>
> --
> Daniel "soro" Cunha
> https://twitter.com/dvlc_
>