Finish the bval setup

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Finish the bval setup

Romain Manni-Bucau
Hi guys,

Wonder if somebody wants to review https://github.com/apache/tomee/pull/180
for merge

From my point of view it looks good and would enable us (bval+tomee) to
appear on bean validation site being certified once we'll release bval
2.0.1.

If anyone has a few cycles to check the PR and potentially do the javafx
setup it would be awesome.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Reply | Threaded
Open this post in threaded view
|

Re: Finish the bval setup

Matthew Broadhead-2
does that mean pull the branch including the PR and compile?

On 31/10/2018 12:09, Romain Manni-Bucau wrote:

> Hi guys,
>
> Wonder if somebody wants to review https://github.com/apache/tomee/pull/180
> for merge
>
>  From my point of view it looks good and would enable us (bval+tomee) to
> appear on bean validation site being certified once we'll release bval
> 2.0.1.
>
> If anyone has a few cycles to check the PR and potentially do the javafx
> setup it would be awesome.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>

Reply | Threaded
Open this post in threaded view
|

Re: Finish the bval setup

Matthew Broadhead-2
i  installed JavaFX on OpenJDK as I use it on another project.  but is
he saying to use a flag to include it in TomEE??

On 31/10/2018 14:25, Matthew Broadhead wrote:

> does that mean pull the branch including the PR and compile?
>
> On 31/10/2018 12:09, Romain Manni-Bucau wrote:
>> Hi guys,
>>
>> Wonder if somebody wants to review
>> https://github.com/apache/tomee/pull/180
>> for merge
>>
>>  From my point of view it looks good and would enable us (bval+tomee) to
>> appear on bean validation site being certified once we'll release bval
>> 2.0.1.
>>
>> If anyone has a few cycles to check the PR and potentially do the javafx
>> setup it would be awesome.
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> |
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: Finish the bval setup

Romain Manni-Bucau
It is mainly about ensuring it is ok then merge yes

The jfx tests are not executed if not configured as such, the flag does it
If I got it right

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mer. 31 oct. 2018 à 14:32, Matthew Broadhead
<[hidden email]> a écrit :

> i  installed JavaFX on OpenJDK as I use it on another project.  but is
> he saying to use a flag to include it in TomEE??
>
> On 31/10/2018 14:25, Matthew Broadhead wrote:
> > does that mean pull the branch including the PR and compile?
> >
> > On 31/10/2018 12:09, Romain Manni-Bucau wrote:
> >> Hi guys,
> >>
> >> Wonder if somebody wants to review
> >> https://github.com/apache/tomee/pull/180
> >> for merge
> >>
> >>  From my point of view it looks good and would enable us (bval+tomee) to
> >> appear on bean validation site being certified once we'll release bval
> >> 2.0.1.
> >>
> >> If anyone has a few cycles to check the PR and potentially do the javafx
> >> setup it would be awesome.
> >>
> >> Romain Manni-Bucau
> >> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> >> <https://rmannibucau.metawerx.net/> | Old Blog
> >> <http://rmannibucau.wordpress.com> | Github
> >> <https://github.com/rmannibucau> |
> >> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
> >>
> >>
> >
>
>