Default resources for Java EE 7.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Default resources for Java EE 7.

Daniel Cunha-2
Hi folks,

I started some works with concurrency API and got some troubles with
default resources, let me know what do you think about my PRs:

https://github.com/apache/tomee/pull/102
https://github.com/apache/tomee/pull/103


Best regard.
--
Daniel Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

jgallimore
Can you add a test? Other than that, they should be good.

Thanks

Jon

On 6 Aug 2017 1:06 am, "Daniel Cunha" <[hidden email]> wrote:

Hi folks,

I started some works with concurrency API and got some troubles with
default resources, let me know what do you think about my PRs:

https://github.com/apache/tomee/pull/102
https://github.com/apache/tomee/pull/103


Best regard.
--
Daniel Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

Romain Manni-Bucau
In reply to this post by Daniel Cunha-2
Hi Daniel

The side note here is: having them by default was intended cause it breaks
tomee deeply in term of resource matching and user existing config. Idea
was to set the flag if you want ee7 behavior to stay backward compat (and
this solution is fine for a EE container).




Le 6 août 2017 02:06, "Daniel Cunha" <[hidden email]> a écrit :

> Hi folks,
>
> I started some works with concurrency API and got some troubles with
> default resources, let me know what do you think about my PRs:
>
> https://github.com/apache/tomee/pull/102
> https://github.com/apache/tomee/pull/103
>
>
> Best regard.
> --
> Daniel Cunha
> https://twitter.com/dvlc_
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

Daniel Cunha
Hi Romain,

well, I get it. But If you don't want the defaults resources then I'll set
the flag to false. The server should always start with default resource
IMHO.

On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau <[hidden email]>
wrote:

> Hi Daniel
>
> The side note here is: having them by default was intended cause it breaks
> tomee deeply in term of resource matching and user existing config. Idea
> was to set the flag if you want ee7 behavior to stay backward compat (and
> this solution is fine for a EE container).
>
>
>
>
> Le 6 août 2017 02:06, "Daniel Cunha" <[hidden email]> a écrit :
>
> > Hi folks,
> >
> > I started some works with concurrency API and got some troubles with
> > default resources, let me know what do you think about my PRs:
> >
> > https://github.com/apache/tomee/pull/102
> > https://github.com/apache/tomee/pull/103
> >
> >
> > Best regard.
> > --
> > Daniel Cunha
> > https://twitter.com/dvlc_
> >
>



--
Daniel Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

Daniel Cunha-2
Hi Romain,

Well, I see that:
Https://github.com/apache/tomee/blob/master/tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java#L729

So, do we forget the '\ n' on the previous line? It seems that this is
already expected to be true by default. So make sense we have that:
https://github.com/apache/tomee/pull/102/files#diff-77912d8fbbbfd389a1d3cbb339561e3cR369

IMHO.


Hi Jon,

I updated tests for this one:
https://github.com/apache/tomee/pull/103


On Sun, Aug 6, 2017 at 8:46 AM, Daniel Cunha <[hidden email]> wrote:

> Hi Romain,
>
> well, I get it. But If you don't want the defaults resources then I'll set
> the flag to false. The server should always start with default resource
> IMHO.
>
> On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau <[hidden email]>
> wrote:
>
>> Hi Daniel
>>
>> The side note here is: having them by default was intended cause it breaks
>> tomee deeply in term of resource matching and user existing config. Idea
>> was to set the flag if you want ee7 behavior to stay backward compat (and
>> this solution is fine for a EE container).
>>
>>
>>
>>
>> Le 6 août 2017 02:06, "Daniel Cunha" <[hidden email]> a écrit :
>>
>> > Hi folks,
>> >
>> > I started some works with concurrency API and got some troubles with
>> > default resources, let me know what do you think about my PRs:
>> >
>> > https://github.com/apache/tomee/pull/102
>> > https://github.com/apache/tomee/pull/103
>> >
>> >
>> > Best regard.
>> > --
>> > Daniel Cunha
>> > https://twitter.com/dvlc_
>> >
>>
>
>
>
> --
> Daniel Cunha
> https://twitter.com/dvlc_
>



--
Daniel Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

Romain Manni-Bucau
Le 6 août 2017 14:12, "Daniel Cunha" <[hidden email]> a écrit :

Hi Romain,

Well, I see that:
Https://github.com/apache/tomee/blob/master/tomee/tomee-
common/src/main/java/org/apache/tomee/installer/Installer.java#L729

So, do we forget the '\ n' on the previous line? It seems that this is
already expected to be true by default. So make sense we have that:
https://github.com/apache/tomee/pull/102/files#diff-
77912d8fbbbfd389a1d3cbb339561e3cR369

IMHO.



No, in standalone it was set to match the spec but it covers ~1% of the
real world usage (remove tests, remove base/home instances etc...) so think
we are good with current defaults. We can surely enhance Comp merging when
there is no webapp - you second addDefault diff - bit this is unrelated to
default resources, more to jndi shared namespace handling outside webapps.




Hi Jon,

I updated tests for this one:
https://github.com/apache/tomee/pull/103


On Sun, Aug 6, 2017 at 8:46 AM, Daniel Cunha <[hidden email]> wrote:

> Hi Romain,
>
> well, I get it. But If you don't want the defaults resources then I'll set
> the flag to false. The server should always start with default resource
> IMHO.
>
> On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau <[hidden email]>
> wrote:
>
>> Hi Daniel
>>
>> The side note here is: having them by default was intended cause it
breaks

>> tomee deeply in term of resource matching and user existing config. Idea
>> was to set the flag if you want ee7 behavior to stay backward compat (and
>> this solution is fine for a EE container).
>>
>>
>>
>>
>> Le 6 août 2017 02:06, "Daniel Cunha" <[hidden email]> a écrit :
>>
>> > Hi folks,
>> >
>> > I started some works with concurrency API and got some troubles with
>> > default resources, let me know what do you think about my PRs:
>> >
>> > https://github.com/apache/tomee/pull/102
>> > https://github.com/apache/tomee/pull/103
>> >
>> >
>> > Best regard.
>> > --
>> > Daniel Cunha
>> > https://twitter.com/dvlc_
>> >
>>
>
>
>
> --
> Daniel Cunha
> https://twitter.com/dvlc_
>



--
Daniel Cunha
https://twitter.com/dvlc_
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Default resources for Java EE 7.

Daniel Cunha
Ok. I get it. I'll close it.

Thank you, Romain.

On Sun, Aug 6, 2017 at 11:05 AM, Romain Manni-Bucau <[hidden email]>
wrote:

> Le 6 août 2017 14:12, "Daniel Cunha" <[hidden email]> a écrit :
>
> Hi Romain,
>
> Well, I see that:
> Https://github.com/apache/tomee/blob/master/tomee/tomee-
> common/src/main/java/org/apache/tomee/installer/Installer.java#L729
>
> So, do we forget the '\ n' on the previous line? It seems that this is
> already expected to be true by default. So make sense we have that:
> https://github.com/apache/tomee/pull/102/files#diff-
> 77912d8fbbbfd389a1d3cbb339561e3cR369
>
> IMHO.
>
>
>
> No, in standalone it was set to match the spec but it covers ~1% of the
> real world usage (remove tests, remove base/home instances etc...) so think
> we are good with current defaults. We can surely enhance Comp merging when
> there is no webapp - you second addDefault diff - bit this is unrelated to
> default resources, more to jndi shared namespace handling outside webapps.
>
>
>
>
> Hi Jon,
>
> I updated tests for this one:
> https://github.com/apache/tomee/pull/103
>
>
> On Sun, Aug 6, 2017 at 8:46 AM, Daniel Cunha <[hidden email]> wrote:
>
> > Hi Romain,
> >
> > well, I get it. But If you don't want the defaults resources then I'll
> set
> > the flag to false. The server should always start with default resource
> > IMHO.
> >
> > On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau <
> [hidden email]>
> > wrote:
> >
> >> Hi Daniel
> >>
> >> The side note here is: having them by default was intended cause it
> breaks
> >> tomee deeply in term of resource matching and user existing config. Idea
> >> was to set the flag if you want ee7 behavior to stay backward compat
> (and
> >> this solution is fine for a EE container).
> >>
> >>
> >>
> >>
> >> Le 6 août 2017 02:06, "Daniel Cunha" <[hidden email]> a écrit :
> >>
> >> > Hi folks,
> >> >
> >> > I started some works with concurrency API and got some troubles with
> >> > default resources, let me know what do you think about my PRs:
> >> >
> >> > https://github.com/apache/tomee/pull/102
> >> > https://github.com/apache/tomee/pull/103
> >> >
> >> >
> >> > Best regard.
> >> > --
> >> > Daniel Cunha
> >> > https://twitter.com/dvlc_
> >> >
> >>
> >
> >
> >
> > --
> > Daniel Cunha
> > https://twitter.com/dvlc_
> >
>
>
>
> --
> Daniel Cunha
> https://twitter.com/dvlc_
>



--
Daniel Cunha
https://twitter.com/dvlc_
Loading...